ezcater_rubocop 0.51.5 → 0.51.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2e1e4b74af46fc4543ab92ab20a575118a881c72
-  data.tar.gz: 864de83177e58cdcb3af668d6e10feb53dd1f2ae
+  metadata.gz: cb603231a4a17aa675551667fb1f67f0b876414f
+  data.tar.gz: 819384ef596abaea34c4b50ca2286710c86fe338
 SHA512:
-  metadata.gz: 3efb0a9492f109fa603cab846955dcf90265b3c0f93213ecba47dbc63cf0ec4ca95691aa69f30ea423130be54d3b8010e3951343de43b17567125045a4d72cf3
-  data.tar.gz: d3bb33303ea534109ff12c212ac32cfc70282a364f2bfb49328a6358f06cb5474a226655dea568d1e93e2e8edb4e0e122568ca98f1e0b4e5b5284e8d95fa161f
+  metadata.gz: ee79e5b54329bb19650f9c2c6edc5c1850abf2f167faf9103ad69192178296ba3f3612da5fef786ebe5fbdeb5b80dc907213427c9872cd1e70d03ea07cf7a2ad
+  data.tar.gz: 6a0302fdae0d7174034bf7e2543d5b11258c6d7201f9fad2de6245c692a488cf06d25eb6dd99e7724b4eaf797c668c36014c467969f4bd9eeeec0424051448ff

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # ezcater_rubocop
 
+## v0.51.6
+- Add `Ezcater/RailsConfiguration` cop.
+- Exclude `config/environments/*.rb` for the `Metrics/BlockLength` cop.
+
 ## v0.51.5
 - Add `Ezcater/RspecRequireGqlErrorHelpers` cop.
 

data/README.md

@@ -83,6 +83,7 @@ is updated.
 
 ## Custom Cops
 1. [PrivateAttr](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/private_attr.rb) - Require methods from the `private_attr` gem.
+1. [RailsConfiguration](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rails_configuration.rb) - Enforce use of `Rails.configuration` instead of `Rails.application.config`.
 1. [RspecDotNotSelfDot](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb) - Enforce ".<class method>" instead of "self.<class method>" for example group description.
 1. [RspecRequireBrowserMock](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb) - Enforce use of `mock_ezcater_app`, `mock_chrome_browser` & `mock_custom_browser` helpers instead of mocking `Browser` or `EzBrowser` directly.
 1. [RspecRequireFeatureFlagMock](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb) - Enforce use of `mock_feature_flag` helper instead of mocking `FeatureFlag.is_active?` directly.

data/conf/rubocop.yml

@@ -14,6 +14,7 @@ Metrics/BlockLength:
   - "*.gemspec"
   - "spec/**/*.rb"
   - "lib/tasks/**/*.rake"
+  - "config/environments/*.rb"
 
 Metrics/CyclomaticComplexity:
   Enabled: false

data/config/default.yml

@@ -2,6 +2,10 @@ Ezcater/PrivateAttr:
   Description: 'Require methods from the private_attr gem'
   Enabled: true
 
+Ezcater/RailsConfiguration:
+  Description: 'Enforce the use of `Rails.configuration` instead of `Rails.application.config`.'
+  Enabled: true
+
 Ezcater/RspecDotNotSelfDot:
   Description: 'Enforce ".<class method>" instead of "self.<class method>" for example group description.'
   Enabled: true

data/lib/ezcater_rubocop.rb

@@ -13,6 +13,7 @@ config = RuboCop::ConfigLoader.merge_with_default(config, path)
 RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, config)
 
 require "rubocop/cop/ezcater/private_attr"
+require "rubocop/cop/ezcater/rails_configuration"
 require "rubocop/cop/ezcater/rspec_require_browser_mock"
 require "rubocop/cop/ezcater/rspec_require_feature_flag_mock"
 require "rubocop/cop/ezcater/rspec_require_gql_error_helpers"

data/lib/ezcater_rubocop/version.rb

@@ -1,3 +1,3 @@
 module EzcaterRubocop
-  VERSION = "0.51.5".freeze
+  VERSION = "0.51.6".freeze
 end

data/lib/rubocop/cop/ezcater/rails_configuration.rb

@@ -0,0 +1,26 @@
+module RuboCop
+  module Cop
+    module Ezcater
+      class RailsConfiguration < Cop
+        MSG = "Use `Rails.configuration` instead of `Rails.application.config`.".freeze
+        RAILS_CONFIGURATION = "Rails.configuration".freeze
+
+        def_node_matcher "rails_application_config", <<-PATTERN
+          (send (send (const _ :Rails) :application) :config)
+        PATTERN
+
+        def on_send(node)
+          rails_application_config(node) do
+            add_offense(node, location: :expression, message: MSG)
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.replace(node.source_range, RAILS_CONFIGURATION)
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.51.5
+  version: 0.51.6
 platform: ruby
 authors:
 - ezCater, Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-15 00:00:00.000000000 Z
+date: 2018-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -128,6 +128,7 @@ files:
 - lib/ezcater_rubocop.rb
 - lib/ezcater_rubocop/version.rb
 - lib/rubocop/cop/ezcater/private_attr.rb
+- lib/rubocop/cop/ezcater/rails_configuration.rb
 - lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb
 - lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb
 - lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb
@@ -155,7 +156,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: ezCater custom cops and shared configuration