ezcater_rubocop 0.50.0 → 0.50.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 506db29e071d65b4cdb7f397b5b5d4a9251ec56f
-  data.tar.gz: ae1917de476959e962b786408bf788bae33ad31d
+  metadata.gz: 4c63e90ad7d1b2099f2aab6305c3d0123d1c6e3e
+  data.tar.gz: d25866a9801f2a127476ee40f918b236465310e0
 SHA512:
-  metadata.gz: 02aed155f78cda26fdf898a66aae1e798bb77dca7b6aa29ab975d855ff1dbab87baacf20509dd234bbe8be7e7e87a60c68ef31d559bfd14a88e5766b60e80917
-  data.tar.gz: 1b5e49ff7b0cf8c3f66d597b02f26bc85dedbbe7a8e7e02bcf7f30c1dc746c2534f43f0c4beea6cf2bbcb361273afec8622a6044bdb833a71e459d26de34c0ed
+  metadata.gz: 24ba565cd9d863890700d15fd65702fbc4cb7b27fcd1fa6ed1b71c78ba007b68cca518ecb9eb15a75e9d049d8d34849353631a46ba58db0422ac2d3d07a2446f
+  data.tar.gz: e54da354c72bf4a6a01927b0eb89dc3bae0dd38e8b469b9d771f4ce66e0ee620f0fcc116293e3e1835e5e06f3ff012ce7922a33610454a1ff8f474e9e398f4c3

data/.rubocop.yml

@@ -1,27 +1,6 @@
-AllCops:
-  DisplayCopNames: true
+inherit_from:
+  - conf/rubocop.yml
 
-Metrics/AbcSize:
+# Disable because aggregate_failures is configured globally
+RSpec/MultipleExpectations:
   Enabled: false
-
-Metrics/BlockLength:
-  Exclude:
-  - "*.gemspec"
-  - "spec/**/*.rb"
-
-Metrics/MethodLength:
-  Enabled: true
-  CountComments: false
-  Max: 25
-
-Metrics/LineLength:
-  Max: 120
-
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-Style/Documentation:
-  Enabled: false
-
-Style/StringLiterals:
-  EnforcedStyle: double_quotes

data/CHANGELOG.md

@@ -1,13 +1,23 @@
 # ezcater_rubocop
 
-# v0.50.0
+## v0.50.1
+- Add shared configuration.
+- Do not apply `Ezcater/StyleDig` to access using a range.
+
+## v0.50.0
 - Update to rubocop v0.50.0 and rubocop-rspec v1.18.0.
 - Do not apply `Ezcater/StyleDig` to assignments with nested access.
 
-# v0.49.1
+# v0.49.3
+- Do not apply `Ezcater/StyleDig` to access using a range.
+
+# v0.49.2
+- Do not apply `Ezcater/StyleDig` to assignments to with nested access.
+
+## v0.49.1
 - Add `Ezcater/RspecRequireBrowserMock` cop.
 
-# v0.49.0
+## v0.49.0
 - Initial release.
 - Add `Ezcater/RspecRequireFeatureFlagMock` cop.
 - Add `Ezcater/RspecDotNotSelfDot` cop.

data/README.md

@@ -1,6 +1,6 @@
 # ezcater_rubocop
 
-ezCater custom cops, and eventually shared rubocop configuration.
+ezCater custom cops and shared RuboCop configuration.
 
 [RuboCop](https://github.com/bbatsov/rubocop) is a static code analyzer that
 can enforce style conventions as well as identify common problems.
@@ -15,6 +15,12 @@ group :development do
 end
 ```
 
+Or to your gem's gemspec file:
+
+```ruby
+spec.add_development_dependency "ezcater_rubocop"
+```
+
 And then execute:
 
     $ bundle install
@@ -23,6 +29,24 @@ Or install it yourself as:
 
     $ gem install ezcater_rubocop
 
+## Configuration
+
+To use one of the shared RuboCop configurations from this gem, you must define a
+.rubocop.yml file in your project:
+
+```yaml
+inherit_gem:
+  ezcater_rubocop: conf/rubocop_rails.yml
+```
+
+Further customization of RuboCop for your local project may be added to this file.
+
+### Available Configurations
+
+- **rubocop**: Assumes RSpec is used and requires [rubocop-rspec](https://github.com/backus/rubocop-rspec).
+  This configuration should be used for gems.
+- **rubocop_rails**: For Rails projects, this inherits from the **rubocop** configuration.
+
 ## Usage
 
 Run `rubocop` for an entire project:

data/conf/rubocop.yml

@@ -0,0 +1,48 @@
+require: ezcater_rubocop
+
+AllCops:
+  DisplayCopNames: true
+
+Layout/DotPosition:
+  EnforcedStyle: trailing
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/BlockLength:
+  Exclude:
+  - "*.gemspec"
+  - "spec/**/*.rb"
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Metrics/LineLength:
+  Max: 120
+
+Metrics/MethodLength:
+  Enabled: true
+  CountComments: false
+  Max: 25
+
+Metrics/PerceivedComplexity:
+  Enabled: false
+
+Rails:
+  Enabled: false
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+# This cop does not yet support a style to prevent underscores
+Style/NumericLiterals:
+  Enabled: false
+
+Style/SingleLineBlockParams:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes

data/conf/rubocop_rails.yml

@@ -0,0 +1,14 @@
+inherit_from:
+  - ../conf/rubocop.yml
+
+AllCops:
+  TargetRailsVersion: 5.1
+
+Rails:
+  Enabled: true
+
+Rails/RelativeDateConstant:
+  # Auto-correct is broken for this cops in some cases. It replaces the
+  # constant but does not update references to it.
+  AutoCorrect: false
+

data/lib/ezcater_rubocop/version.rb

@@ -1,3 +1,3 @@
 module EzcaterRubocop
-  VERSION = "0.50.0".freeze
+  VERSION = "0.50.1".freeze
 end

data/lib/rubocop/cop/ezcater/style_dig.rb

@@ -22,7 +22,7 @@ module RuboCop
         MSG = "Use `dig` for nested access.".freeze
 
         def_node_matcher :nested_access_match, <<-PATTERN
-          (send (send (send _receiver !:[]) :[] _) :[] _)
+          (send (send (send _receiver !:[]) :[] !{irange erange}) :[] !{irange erange})
         PATTERN
 
         def on_send(node)
@@ -57,7 +57,11 @@ module RuboCop
         end
 
         def access_node?(node)
-          node&.send_type? && node.method_name == :[]
+          node&.send_type? && node.method_name == :[] && !range?(node.first_argument)
+        end
+
+        def range?(node)
+          node.irange_type? || node.erange_type?
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.50.0
+  version: 0.50.1
 platform: ruby
 authors:
 - ezCater, Inc
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-10-09 00:00:00.000000000 Z
+date: 2017-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -129,6 +129,8 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
+- conf/rubocop.yml
+- conf/rubocop_rails.yml
 - config/default.yml
 - ezcater_rubocop.gemspec
 - lib/ezcater_rubocop.rb