ezcater_rubocop 0.49.6 → 0.49.7.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e32a7e2e0abe14baf6fa3593746512ced2390928f8f4226cd1fe50ffe1c08514
-  data.tar.gz: c5604b7ea96840afbe48428d31e2b6690e903eca71ec1bfa6f7ce19302d7e32f
+  metadata.gz: 21616f4a6237e3b0d46df21c1f9cd1ce7b0841c4810ab3a0fb43ac6b5d0fad0a
+  data.tar.gz: e81db7bbd7dbcdbdeb7485ad7d3a58a95c74ce4271dd6e23feebce084d57bd9a
 SHA512:
-  metadata.gz: 8c67093957e4064f049040d145edd3ffe9aa2df350a1146b7e5bdc1071a0bcf4f54c548fdcd93e32b8c516d3dd8e2a4f800c53a25005365190cacb07764ca0a3
-  data.tar.gz: 9789e2c32a477cb1ef87526af0aeed545d889f8404263f5a4cc5889c5b70102946b91d856316f40f052ba0b70cf58ecb395e93cdf25db16f93c402dc1bfa1538
+  metadata.gz: b06b3574202e1da217ee1596732897ac28f4171c5860d50d3bf85dfc542e1d929eb7011f7400d94b4c9e65c6faa53c6e679a77621e560853749a535751c4b24f
+  data.tar.gz: 870d38c1c5d743cabe12b857c74056336f263a224ad7af64cacc1eb9457bf35c7d0078f6386d21357c576d6343091706f1dcf08dd390b8163a98d59b8fae1026

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # ezcater_rubocop
 
+## v0.49.7
+- Add `Ezcater/RspecRequireHttpStatusMatcher` cop.
+- Enable `Rails/HttpStatus` cop and enforce symbols.
+
 ## v0.49.6
 - Rename `Ezcater/RspecRequireGqlErrorHelpers` cop to `Ezcater/RequireGqlErrorHelpers`.
 

data/README.md

@@ -52,6 +52,7 @@ is updated.
 1. [RspecDotNotSelfDot](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb) - Enforce ".<class method>" instead of "self.<class method>" for example group description.
 1. [RspecRequireBrowserMock](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb) - Enforce use of `mock_ezcater_app`, `mock_chrome_browser` & `mock_custom_browser` helpers instead of mocking `Browser` or `EzBrowser` directly.
 1. [RspecRequireFeatureFlagMock](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb) - Enforce use of `mock_feature_flag` helper instead of mocking `FeatureFlag.is_active?` directly.
+1. [RspecRequireHttpStatusMatcher](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_http_status_matcher.rb) - Use the HTTP status code matcher, like `expect(response).to have_http_status :bad_request`, rather than `expect(response.code).to eq 400`
 1. [StyleDig](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/style_dig.rb) - Recommend `dig` for deeply nested access.
 
 ## Development

data/config/default.yml

@@ -20,6 +20,12 @@ Ezcater/RspecRequireFeatureFlagMock:
   Include:
     - '**/*_spec.rb'
 
+Ezcater/RspecRequireHttpStatusMatcher:
+  Description: 'Use the HTTP status code matcher, like `expect(response).to have_http_status :bad_request`, rather than `expect(response.code).to eq 400`'
+  Enabled: true
+  Include:
+    - '**/*_spec.rb'
+
 Ezcater/RequireGqlErrorHelpers:
   Description: 'Use the helpers provided by `GQLErrors` instead of raising `GraphQL::ExecutionError` directly.'
   Enabled: true

data/lib/ezcater_rubocop.rb

@@ -16,5 +16,6 @@ require "rubocop/cop/ezcater/rails_configuration"
 require "rubocop/cop/ezcater/require_gql_error_helpers"
 require "rubocop/cop/ezcater/rspec_require_browser_mock"
 require "rubocop/cop/ezcater/rspec_require_feature_flag_mock"
+require "rubocop/cop/ezcater/rspec_require_http_status_matcher"
 require "rubocop/cop/ezcater/rspec_dot_not_self_dot"
 require "rubocop/cop/ezcater/style_dig"

data/lib/ezcater_rubocop/version.rb

@@ -1,3 +1,3 @@
 module EzcaterRubocop
-  VERSION = "0.49.6".freeze
+  VERSION = "0.49.7.rc1".freeze
 end

data/lib/rubocop/cop/ezcater/rspec_require_http_status_matcher.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Ezcater
+      # Enforce use of HTTP status code matchers rather than asserting on on random numbers.
+      #
+      # @example
+      #
+      #   # good
+      #   expect(response).to have_http_status :created
+      #   expect(response).to have_http_status :bad_request
+      #
+      #   # bad
+      #   expect(response.code).to eq 201
+      #   expect(response.code).to eq 400
+      class RspecRequireHttpStatusMatcher < Cop
+        MSG = "Use the `have_http_status` matcher, like `expect(response).to have_http_status :bad_request`, "\
+          "rather than `%<node_source>s`"
+
+        def_node_matcher :response_code_assertion, <<~PATTERN
+          (send (send _ :expect (send (send _ :response) :code)) :to (send _ :eq (int _)))
+        PATTERN
+
+        def on_send(node)
+          return unless response_code_assertion(node)
+
+          add_offense(node,
+                      location: :expression,
+                      message: format(MSG, node_source: node.source))
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.49.6
+  version: 0.49.7.rc1
 platform: ruby
 authors:
 - ezCater, Inc
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-01-24 00:00:00.000000000 Z
+date: 2018-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -138,6 +138,7 @@ files:
 - lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb
 - lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb
 - lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb
+- lib/rubocop/cop/ezcater/rspec_require_http_status_matcher.rb
 - lib/rubocop/cop/ezcater/style_dig.rb
 - lib/rubocop/rspec/language/each_selector.rb
 homepage: https://github.com/ezcater/ezcater_rubocop
@@ -156,9 +157,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.7.4