ezcater_rubocop 0.49.4 → 0.49.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b1eebe376c776e260d533d0ed1df2af63fea9bd3
-  data.tar.gz: 8152ea09ee64ece4592a5bd03f8e03c45530de30
+  metadata.gz: 042fd2cde603837cb71e9828f944affc13c9f899
+  data.tar.gz: be970a40f1a3540c909a1ccd30af5dae8b05aee0
 SHA512:
-  metadata.gz: 07b710a2d92db3db77b6eb9bdc2fd5c1b615f97d4356ee2af26ab0e176e93770db146efb3ae08e0cf532e08cd4355d7c1619179b580658fcc8f5b8baaff8dfd6
-  data.tar.gz: 93047bd242a44230b4d30e78dcb27ac32580eafcd767b9c6b1128500a620b8a5f008c28012f5ffea2726121ff903251d96d4cf851a7456d9f06d53c55f2542af
+  metadata.gz: 685336eb500893de2e1d0e099dd4283980f1d66edf5df2447e11dc983e57c2f07d561b049653a62334197067aaf3c6f1e5f5f25406ffe695a0ba09ee7f7af461
+  data.tar.gz: 1b4f84114d5c91a1e4ed5ec63aaacab85142b528da6f636a25b141d6a4c8ffd9a1b65af0685943ecddc7297b567e5e604aa8845c5a221da53db17e85996adfb1

data/CHANGELOG.md

@@ -1,18 +1,21 @@
 # ezcater_rubocop
 
-# v0.49.4
+## v0.49.5
+- Add `Ezcater/RailsConfiguration` cop.
+
+## v0.49.4
 - Add `Ezcater/RspecRequireGqlErrorHelpers` cop.
 
-# v0.49.3
+## v0.49.3
 - Do not apply `Ezcater/StyleDig` to access using a range.
 
-# v0.49.2
+## v0.49.2
 - Do not apply `Ezcater/StyleDig` to assignments to with nested access.
 
-# v0.49.1
+## v0.49.1
 - Add `Ezcater/RspecRequireBrowserMock` cop.
 
-# v0.49.0
+## v0.49.0
 - Initial release.
 - Add `Ezcater/RspecRequireFeatureFlagMock` cop.
 - Add `Ezcater/RspecDotNotSelfDot` cop.

data/README.md

@@ -47,6 +47,7 @@ the latest compatible version each time that the MAJOR.MINOR version of `rubocop
 is updated.
 
 ## Custom Cops
+1. [RailsConfiguration](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rails_configuration.rb) - Enforce use of `Rails.configuration` instead of `Rails.application.config`.
 1. [RspecDotNotSelfDot](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb) - Enforce ".<class method>" instead of "self.<class method>" for example group description.
 1. [RspecRequireBrowserMock](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb) - Enforce use of `mock_ezcater_app`, `mock_chrome_browser` & `mock_custom_browser` helpers instead of mocking `Browser` or `EzBrowser` directly.
 1. [RspecRequireFeatureFlagMock](https://github.com/ezcater/ezcater_rubocop/blob/master/lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb) - Enforce use of `mock_feature_flag` helper instead of mocking `FeatureFlag.is_active?` directly.

data/config/default.yml

@@ -1,3 +1,7 @@
+Ezcater/RailsConfiguration:
+  Description: 'Enforce the use of `Rails.configuration` instead of `Rails.application.config`.'
+  Enabled: true
+
 Ezcater/RspecDotNotSelfDot:
   Description: 'Enforce ".<class method>" instead of "self.<class method>" for example group description.'
   Enabled: true

data/lib/ezcater_rubocop.rb

@@ -12,6 +12,7 @@ puts "configuration from #{DEFAULT_FILES}" if RuboCop::ConfigLoader.debug?
 config = RuboCop::ConfigLoader.merge_with_default(config, path)
 RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, config)
 
+require "rubocop/cop/ezcater/rails_configuration"
 require "rubocop/cop/ezcater/rspec_require_browser_mock"
 require "rubocop/cop/ezcater/rspec_require_feature_flag_mock"
 require "rubocop/cop/ezcater/rspec_require_gql_error_helpers"

data/lib/ezcater_rubocop/version.rb

@@ -1,3 +1,3 @@
 module EzcaterRubocop
-  VERSION = "0.49.4".freeze
+  VERSION = "0.49.5".freeze
 end

data/lib/rubocop/cop/ezcater/rails_configuration.rb

@@ -0,0 +1,26 @@
+module RuboCop
+  module Cop
+    module Ezcater
+      class RailsConfiguration < Cop
+        MSG = "Use `Rails.configuration` instead of `Rails.application.config`.".freeze
+        RAILS_CONFIGURATION = "Rails.configuration".freeze
+
+        def_node_matcher "rails_application_config", <<-PATTERN
+          (send (send (const _ :Rails) :application) :config)
+        PATTERN
+
+        def on_send(node)
+          rails_application_config(node) do
+            add_offense(node, :expression, MSG)
+          end
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.replace(node.source_range, RAILS_CONFIGURATION)
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ezcater_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.49.4
+  version: 0.49.5
 platform: ruby
 authors:
 - ezCater, Inc
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-01-15 00:00:00.000000000 Z
+date: 2018-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -133,6 +133,7 @@ files:
 - ezcater_rubocop.gemspec
 - lib/ezcater_rubocop.rb
 - lib/ezcater_rubocop/version.rb
+- lib/rubocop/cop/ezcater/rails_configuration.rb
 - lib/rubocop/cop/ezcater/rspec_dot_not_self_dot.rb
 - lib/rubocop/cop/ezcater/rspec_require_browser_mock.rb
 - lib/rubocop/cop/ezcater/rspec_require_feature_flag_mock.rb
@@ -160,7 +161,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: ezCater custom cops and shared configuration