eyes_selenium 3.16.12 → 3.16.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba3eadfe2c452a73b20e1799f85ea0aeeba69763613c2b3cda8dbecf9d79f572
-  data.tar.gz: f34fbe1de164517186249039ae6852fc1d03dc14d75a6d65bdf1eb0614b97ec0
+  metadata.gz: bf34f32517a64146b3254405709c8c07af4992496429fe55d67fc48d77aaf547
+  data.tar.gz: '083bd5f9fbdded908ed6a8eebb3eef403bb01abeb93cb5fcdabeae9a8696c294'
 SHA512:
-  metadata.gz: 186e03f4d409c73ec8e2e9b3c3c6488293f816f3fe65b0d8ae6db992cc85680b0e4a4141d173cd9389041a3be16c16915590eef5e59ebf78af95dc075574f9b7
-  data.tar.gz: 4b0041a83f5703bc297fdeaee40c4393b5545d58baf08b235bec102a9dc48de497acfa2a125fd8eff7d0f8b5e21a92e9799768db9e0334b757283008430bcdb5
+  metadata.gz: 960f6da1af7347ce928d5d474e767fb75d2c3462fac995f046804cf2548c4bce9d143e65623ae824de511a31957c4dbf475ed216ed4805163761f358be1659f3
+  data.tar.gz: a189c58ec060ce51ea151d6d1b9c466fb28a37206ec39109ae8cae7570cc7bd89dee319d9f4b8b3d3835f00adb4821df5775f1eff6401264282084aa3841d668

data/lib/applitools/selenium/configuration.rb

@@ -11,7 +11,7 @@ module Applitools
           force_full_page_screenshot: false,
           wait_before_screenshots: 0.1,
           stitch_mode: Applitools::Selenium::StitchModes::CSS,
-          hide_scrollbars: false,
+          hide_scrollbars: true,
           hide_caret: false,
           browsers_info: Applitools::Selenium::BrowsersInfo.new,
           accessibility_validation: Applitools::AccessibilityLevel::NONE,

data/lib/applitools/selenium/css_parser/find_embedded_resources.rb

@@ -49,7 +49,7 @@ module Applitools
         end
 
         def fetch_urls(nodes)
-          nodes.map { |n| url(n) }.flatten.compact #rescue []
+          nodes.map { |n| url(n) }.flatten.compact
         end
 
         def import_rules

data/lib/applitools/selenium/selenium_eyes.rb

@@ -117,7 +117,6 @@ module Applitools::Selenium
       self.region_to_check = nil
       self.force_full_page_screenshot = false
       self.dont_get_title = false
-      self.hide_scrollbars = false
       self.device_pixel_ratio = UNKNOWN_DEVICE_PIXEL_RATIO
       self.stitch_mode = Applitools::STITCH_MODE[:scroll]
       self.wait_before_screenshots = DEFAULT_WAIT_BEFORE_SCREENSHOTS
@@ -246,7 +245,6 @@ module Applitools::Selenium
       original_position_provider = position_provider
       original_force_full_page_screenshot = force_full_page_screenshot
 
-      eyes_element = nil
       timeout = target_to_check.options[:timeout] || USE_DEFAULT_MATCH_TIMEOUT
 
       self.eyes_screenshot_factory = lambda do |image|
@@ -256,14 +254,9 @@ module Applitools::Selenium
         )
       end
 
-      # self.prevent_dom_processing = !((!target.options[:send_dom].nil? && target.options[:send_dom]) ||
-      #     send_dom || stitch_mode == Applitools::STITCH_MODE[:css])
-      #
-      # require 'pry'
-      # binding.pry
-
       self.prevent_dom_processing = send_dom?(target_to_check) ? false : true
 
+      # rubocop:disable BlockLength
       check_in_frame target_frames: target_to_check.frames do
         begin
           match_data = Applitools::MatchWindowData.new(default_match_settings)
@@ -307,6 +300,24 @@ module Applitools::Selenium
                 driver,
                 eyes_element
               )
+              ensure_block = -> { eyes_element.overflow = original_overflow if original_overflow }
+            end
+          else
+            if hide_scrollbars
+              begin
+                original_overflow = Applitools::Utils::EyesSeleniumUtils.hide_scrollbars driver
+                driver.find_element(:css, 'html').overflow_data_attribute = original_overflow
+              rescue Applitools::EyesDriverOperationException => e
+                logger.warn "Failed to hide scrollbars! Error: #{e.message}"
+              ensure
+                ensure_block = lambda do
+                  begin
+                    Applitools::Utils::EyesSeleniumUtils.set_overflow driver, original_overflow if original_overflow
+                  rescue Applitools::EyesDriverOperationException => e
+                    logger.warn "Failed to revert overflow! Error: #{e.message}"
+                  end
+                end
+              end
             end
           end
 
@@ -314,7 +325,7 @@ module Applitools::Selenium
             region_provider, timeout, match_data
           )
         ensure
-          eyes_element.overflow = original_overflow unless original_overflow.nil?
+          ensure_block.call if ensure_block
           self.check_frame_or_element = false
           self.force_full_page_screenshot = original_force_full_page_screenshot
           self.position_provider = original_position_provider
@@ -417,33 +428,16 @@ module Applitools::Selenium
 
       update_scaling_params
 
-      if hide_scrollbars
-        begin
-          original_overflow = Applitools::Utils::EyesSeleniumUtils.hide_scrollbars driver
-          driver.find_element(:css, 'html').overflow_data_attribute = original_overflow
-        rescue Applitools::EyesDriverOperationException => e
-          logger.warn "Failed to hide scrollbars! Error: #{e.message}"
-        end
-      end
-
-      begin
-        algo = Applitools::Selenium::FullPageCaptureAlgorithm.new(
-          debug_screenshot_provider: debug_screenshot_provider
-        )
-        case screenshot_type
-        when ENTIRE_ELEMENT_SCREENSHOT
-          self.screenshot = entire_element_screenshot(algo)
-        when FULLPAGE_SCREENSHOT
-          self.screenshot = full_page_screenshot(algo)
-        when VIEWPORT_SCREENSHOT
-          self.screenshot = viewport_screenshot
-        end
-      ensure
-        begin
-          Applitools::Utils::EyesSeleniumUtils.set_overflow driver, original_overflow
-        rescue Applitools::EyesDriverOperationException => e
-          logger.warn "Failed to revert overflow! Error: #{e.message}"
-        end
+      algo = Applitools::Selenium::FullPageCaptureAlgorithm.new(
+        debug_screenshot_provider: debug_screenshot_provider
+      )
+      case screenshot_type
+      when ENTIRE_ELEMENT_SCREENSHOT
+        self.screenshot = entire_element_screenshot(algo)
+      when FULLPAGE_SCREENSHOT
+        self.screenshot = full_page_screenshot(algo)
+      when VIEWPORT_SCREENSHOT
+        self.screenshot = viewport_screenshot
       end
     end
 
@@ -465,7 +459,6 @@ module Applitools::Selenium
         stitching_overlap: stitching_overlap
       )
 
-      # binding.pry
       unless original_frame.empty?
         logger.info 'Switching back to original frame...'
         driver.switch_to.frames frame_chain: original_frame

data/lib/applitools/selenium/target.rb

@@ -29,7 +29,6 @@ module Applitools
       def initialize
         self.frames = []
         self.options = {
-          ignore_caret: true,
           ignore_mismatch: false,
           script_hooks: { beforeCaptureScreenshot: '' }
         }

data/lib/applitools/selenium/visual_grid/vg_resource.rb

@@ -57,6 +57,7 @@ module Applitools
                         .xpath("//@*[namespace-uri(.) = 'http://www.w3.org/1999/xlink'] | //@href")
                         .select { |a| a.name == 'href' }
                         .map(&:value)
+                        .select { |a| /^(?!#).*/.match(a) }
         handle_discovered_resources_block.call(attrs, url)
       end
 

data/lib/applitools/selenium/visual_grid/visual_grid_eyes.rb

@@ -29,6 +29,9 @@ module Applitools
       def initialize(visual_grid_manager, server_url = nil)
         ensure_config
         @server_connector = Applitools::Connectivity::ServerConnector.new(server_url)
+        @server_connector.obtain_agent_id do
+          full_agent_id
+        end
         self.server_url = server_url if server_url
         self.visual_grid_manager = visual_grid_manager
         self.test_list = Applitools::Selenium::TestList.new
@@ -41,6 +44,10 @@ module Applitools
         self.config = Applitools::Selenium::Configuration.new
       end
 
+      def full_agent_id
+        "eyes.selenium.visualgrid.ruby/#{Applitools::VERSION}"
+      end
+
       def configure
         return unless block_given?
         yield(config)

data/lib/applitools/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: false
 
 module Applitools
-  VERSION = '3.16.12'.freeze
+  VERSION = '3.16.13'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eyes_selenium
 version: !ruby/object:Gem::Version
-  version: 3.16.12
+  version: 3.16.13
 platform: ruby
 authors:
 - Applitools Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-30 00:00:00.000000000 Z
+date: 2020-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eyes_core
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.16.12
+        version: 3.16.13
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.16.12
+        version: 3.16.13
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement