eyes_selenium 3.14.8 → 3.14.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4d2a02a97471ca711cc4cee80ff6d948dbdbba3629a32dbf7711a072c5ae650d
-  data.tar.gz: e715d1aee3fbdd03f48a4caf5cf311d532b9d950f9a59dfbe5b467ff536b5a33
+  metadata.gz: d500101344559727659a517156d95e4653706a4de211db4d509d986aae06fde7
+  data.tar.gz: bd91da99dccd21c1519a9ce18bf00bc5761d90992e11aaefe539d16b144038d7
 SHA512:
-  metadata.gz: 548088ae090ff0fb5999e4102e4188dee92a51f4c16d0fb9c035f230a665b0239e02fc2a88d28ce51139cac6f93efe859111c42b557e35b2e7172a349be79c61
-  data.tar.gz: 706fa0ed4b57a1fd37a7405cb9a93959996c9ab48ba73a4151988727f9d48732eb7feb5e4ce720f29ab00310653b1ff2a6ada6a96ebbc207bed6d5f9a4718ac8
+  metadata.gz: 81577dcbe0e103115bf57fe76d5df2a466d072f71a5f8303f38dcf70ce9b1cc2dd2a570beca8b3ce9b7f3206a09ed18b9be9ad9ea2e2478ed82e54c72ba481ee
+  data.tar.gz: 87b4d229fb734f03896e716003a64f58355b9a24850fb85404d68f0f1c55aa2020e88d370bf032b220caecf1bbe0d723caae9789b2fd2ecf298ef0e6e4ac5a80

data/lib/applitools/selenium/element.rb

@@ -27,6 +27,8 @@ module Applitools::Selenium
 
     JS_GET_OVERFLOW = 'return arguments[0].style.overflow;'.freeze
     JS_SET_OVERFLOW_FORMATTED_STR = "arguments[0].style.overflow = '%s'".freeze
+    JS_SET_SCROLL_DATA_FORMATTED_STR = "arguments[0].setAttribute('data-applitools-scroll', '%s')".freeze
+    JS_SET_OVERFLOW_DATA_FORMATTED_STR = "arguments[0].setAttribute('data-applitools-original-overflow', '%s')".freeze
 
     TRACE_PREFIX = 'EyesWebElement'.freeze
 
@@ -127,6 +129,14 @@ module Applitools::Selenium
       driver.execute_script(JS_SET_OVERFLOW_FORMATTED_STR % overflow, self)
     end
 
+    def scroll_data_attribute=(value)
+      driver.execute_script(JS_SET_SCROLL_DATA_FORMATTED_STR % value, self)
+    end
+
+    def overflow_data_attribute=(value)
+      driver.execute_script(JS_SET_OVERFLOW_DATA_FORMATTED_STR % value, self)
+    end
+
     def computed_style(prop_style)
       driver.execute_script(JS_GET_COMPUTED_STYLE_FORMATTED_STR % prop_style, self).to_s
     end

data/lib/applitools/selenium/eyes.rb

@@ -98,7 +98,7 @@ module Applitools::Selenium
     attr_accessor :base_agent_id, :screenshot, :force_full_page_screenshot, :hide_scrollbars,
       :wait_before_screenshots, :debug_screenshots, :stitch_mode, :disable_horizontal_scrolling,
       :disable_vertical_scrolling, :explicit_entire_size, :debug_screenshot_provider, :stitching_overlap,
-      :full_page_capture_algorithm_left_top_offset, :screenshot_type, :use_dom
+      :full_page_capture_algorithm_left_top_offset, :screenshot_type, :send_dom
     attr_reader :driver
 
     def_delegators 'Applitools::EyesLogger', :logger, :log_handler, :log_handler=
@@ -129,7 +129,7 @@ module Applitools::Selenium
       self.force_driver_resolution_as_viewport_size = false
       self.stitching_overlap = DEFAULT_STITCHING_OVERLAP
       self.full_page_capture_algorithm_left_top_offset = Applitools::Location::TOP_LEFT
-      self.use_dom = false
+      self.send_dom = false
       self.prevent_dom_processing = false
     end
 
@@ -264,7 +264,11 @@ module Applitools::Selenium
         )
       end
 
-      self.prevent_dom_processing = !((!target.options[:use_dom].nil? && target.options[:use_dom]) || use_dom)
+      # self.prevent_dom_processing = !((!target.options[:send_dom].nil? && target.options[:send_dom]) ||
+      #     send_dom || stitch_mode == Applitools::STITCH_MODE[:css])
+
+      self.prevent_dom_processing = !((!target.options[:send_dom].nil? && target.options[:send_dom]) ||
+          send_dom)
 
       check_in_frame target_frames: target_to_check.frames do
         begin
@@ -276,6 +280,7 @@ module Applitools::Selenium
           unless force_full_page_screenshot
             region_visibility_strategy.move_to_region original_position_provider,
               Applitools::Location.new(eyes_element.location.x.to_i, eyes_element.location.y.to_i)
+            driver.find_element(:css, 'html').scroll_data_attribute = true
           end
 
           region_provider = Applitools::Selenium::RegionProvider.new(driver, region_for_element(eyes_element))
@@ -299,6 +304,8 @@ module Applitools::Selenium
             if eyes_element.is_a? Applitools::Selenium::Element
               original_overflow = eyes_element.overflow
               eyes_element.overflow = 'hidden'
+              eyes_element.scroll_data_attribute = true
+              eyes_element.overflow_data_attribute = original_overflow
               self.position_provider = Applitools::Selenium::CssTranslateElementPositionProvider.new(
                 driver,
                 eyes_element
@@ -524,6 +531,7 @@ module Applitools::Selenium
       if hide_scrollbars
         begin
           original_overflow = Applitools::Utils::EyesSeleniumUtils.hide_scrollbars driver
+          driver.find_element(:css, 'html').overflow_data_attribute = original_overflow
         rescue Applitools::EyesDriverOperationException => e
           logger.warn "Failed to hide scrollbars! Error: #{e.message}"
         end

data/lib/applitools/selenium/target.rb

@@ -163,6 +163,16 @@ module Applitools
         self
       end
 
+      def send_dom(value = true)
+        options[:send_dom] = value ? true : false
+        self
+      end
+
+      def use_dom(value = true)
+        options[:use_dom] = value ? true : false
+        self
+      end
+
       def finalize
         return self unless frame_or_element
         region = frame_or_element

data/lib/applitools/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: false
 
 module Applitools
-  VERSION = '3.14.8'.freeze
+  VERSION = '3.14.9'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eyes_selenium
 version: !ruby/object:Gem::Version
-  version: 3.14.8
+  version: 3.14.9
 platform: ruby
 authors:
 - Applitools Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-07 00:00:00.000000000 Z
+date: 2019-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eyes_core
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.14.8
+        version: 3.14.9
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.14.8
+        version: 3.14.9
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement