eyes_selenium 3.14.2 → 3.14.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6c3b7458d90ef5f55b65f8e0b42b41d0eaf7f746
-  data.tar.gz: 3751dc0f12798e472f7116240c2c80ef32c60132
+  metadata.gz: a85a4fbc19f3a4c5fd8e57fbd839ae3d92cbbd76
+  data.tar.gz: c345ecf5f123efdefe2ebb083b67f92ba0d6234d
 SHA512:
-  metadata.gz: d2a70ae337b3880c5bae8f49b936d25be1e6ae88f761d99dec56864501d3fb5715dcd3f88ad47aaa3771175257963d1b719ab00e3ff800a01a91f31cbe2717c4
-  data.tar.gz: 60da9624d81765441bb428865a82c54434c646b947156de02c931f1732b19c6e4fbf293eff161dbf62a8d1e07e07e53dcdced47dad97bc66498f50a0d95e9c73
+  metadata.gz: 9f7877bb8325b148309618f5ee68c8bd5ea396eecdfdc2cd48a0d23fbff3549189793883dacc6c15a438c71f36389cc0ba08c68070d2035c21f6d184df74b303
+  data.tar.gz: ef3229dc823585a9d62904d1c8bbac5fd90359826e61634811c84d9808eddff0eb84f34b6a551748ed44d6d41201d42e0cd7a3a26a5281a6ffe92334ddfef641

data/lib/applitools/selenium/driver.rb

@@ -75,7 +75,7 @@ module Applitools::Selenium
     # Returns +true+ if the driver orientation is landscape.
     def landscape_orientation?
       driver.orientation.to_s.upcase == LANDSCAPE
-    rescue NameError, Selenium::WebDriver::Error::UnknownError
+    rescue NameError, Selenium::WebDriver::Error::WebDriverError, Selenium::WebDriver::Error::UnknownError
       Applitools::EyesLogger.debug 'driver has no "orientation" attribute. Assuming: portrait.'
       false
     end

data/lib/applitools/selenium/eyes_target_locator.rb

@@ -24,15 +24,33 @@ module Applitools::Selenium
     # @option options [Fixnum] :index The index of the frame.
     # @option options [String] :name_or_id The name of the frame.
     # @option options [WebElement] :frameElement The element with the frame.
-    def frame(options = {})
-      raise Applitools::EyesIllegalArgument.new 'You must pass :index or :name_or_id or :frame_element option' unless
-          options[:index] || options[:name_or_id] || options[:frame_element]
-      if (needed_keys = (options.keys & [:index, :name_or_id, :frame_element])).length == 1
-        send "frame_by_#{needed_keys.first}", options[needed_keys.first]
+    def frame(*args)
+      case value = args[0]
+      when Hash
+        options = value
+        raise Applitools::EyesIllegalArgument.new 'You must pass :index or :name_or_id or :frame_element option' unless
+            options[:index] || options[:name_or_id] || options[:frame_element]
+        if (needed_keys = (options.keys & [:index, :name_or_id, :frame_element])).length == 1
+          send "frame_by_#{needed_keys.first}", options[needed_keys.first]
+        else
+          raise Applitools::EyesIllegalArgument.new 'You\'ve passed some extra keys!' /
+            'Only :index, :name_or_id or :frame_elenent are allowed.'
+        end
+      when Applitools::Selenium::Element
+        frame_by_frame_element(value)
       else
-        raise Applitools::EyesIllegalArgument.new 'You\'ve passed some extra keys!' /
-          'Only :index, :name_or_id or :frame_elenent are allowed.'
+        raise Applitools::EyesError 'Unknown frame selector to switch!'
       end
+      # require 'pry'
+      # binding.pry
+      # raise Applitools::EyesIllegalArgument.new 'You must pass :index or :name_or_id or :frame_element option' unless
+      #     options[:index] || options[:name_or_id] || options[:frame_element]
+      # if (needed_keys = (options.keys & [:index, :name_or_id, :frame_element])).length == 1
+      #   send "frame_by_#{needed_keys.first}", options[needed_keys.first]
+      # else
+      #   raise Applitools::EyesIllegalArgument.new 'You\'ve passed some extra keys!' /
+      #     'Only :index, :name_or_id or :frame_elenent are allowed.'
+      # end
     end
 
     # Switches to parent frame.

data/lib/applitools/version.rb

@@ -1,3 +1,3 @@
 module Applitools
-  VERSION = '3.14.2'.freeze
+  VERSION = '3.14.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eyes_selenium
 version: !ruby/object:Gem::Version
-  version: 3.14.2
+  version: 3.14.3
 platform: ruby
 authors:
 - Applitools Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-30 00:00:00.000000000 Z
+date: 2018-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eyes_core
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.14.2
+        version: 3.14.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.14.2
+        version: 3.14.3
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement
@@ -123,7 +123,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Applitools Ruby Images SDK