eyes_core 4.0.4 → 4.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 75034b315f72b3618b3dbf11275415ad4d6b6198
-  data.tar.gz: 141e9a4bda412f6744dfe27a18dd4724c80f07bf
+  metadata.gz: 594c8d4219a36eebaef4d76310a8c9525235891d
+  data.tar.gz: f098d430a1c294deb84141dd2b8fb2c8505e0b01
 SHA512:
-  metadata.gz: 83ac3e51133c6157ec47cffeba360aa78939a05d6e95afdb82b61e86e21051ac330ecd9aee8de40c1c2cdb69418c4e78388e8052e769fcacdf42bfd0420664ec
-  data.tar.gz: 45035b9600c21207ccc79649949968275d28ae1eddf523c97774a18eb5770eb024c6eea92314270b1bb667af12792dd49779ba26113ac020181b247331246e2e
+  metadata.gz: 6442028a1b2f6eee6c86538d50c4272310f8ec9928216deee68062f93b7e89b0d9df9a342affcd7aa996faba44128d43227e8b32f0b917e522753a0dc08daffd
+  data.tar.gz: 842eb9c9fab4f64621a7d15f508112c20ade9f80f04c4eb34c84f180a8c19a3140c8ef04bd71e23ddb7dd2d22b412c2b4adb6ac748c63235530505519e316918

data/lib/applitools/core/batch_info.rb

@@ -35,7 +35,9 @@ module Applitools
         self.id = PROCESS_DEFAULT_BATCH_ID
       end
       self.properties = properties if properties
-      self.notify_on_completion = 'true'.casecmp(env_notify_on_completion || '') == 0 ? true : false
+      unless env_notify_on_completion.nil?
+        self.notify_on_completion = 'true'.casecmp(env_notify_on_completion || '') == 0 ? true : false
+      end
     end
 
     def json_data

data/lib/applitools/core/eyes_runner.rb

@@ -27,5 +27,23 @@ module Applitools
     def close_all_eyes
       get_universal_eyes_manager.close_all_eyes
     end
+
+    # def close_batch(batch_id)
+    #   if 'true'.casecmp(ENV['APPLITOOLS_DONT_CLOSE_BATCHES'] || '') == 0
+    #     return Applitools::EyesLogger.info(
+    #       'APPLITOOLS_DONT_CLOSE_BATCHES environment variable set to true. Doing nothing.'
+    #     ) && false
+    #   end
+    #   Applitools::ArgumentGuard.not_nil(batch_id, 'batch_id')
+    #   Applitools::EyesLogger.info("Close batch called with #{batch_id}")
+    #
+    #   close_batches_result = universal_client.core_close_batches(batch_id)
+    #   if close_batches_result.is_a?(Hash) && close_batches_result[:message] && close_batches_result[:stack]
+    #     Applitools::EyesLogger.logger.debug "Eyes close Batch: #{close_batches_result[:message]}"
+    #     Applitools::EyesLogger.logger.debug "Stack for #{Applitools::Connectivity::UniversalClient::CORE_CLOSE_BATCHES} : #{close_batches_result[:stack]}"
+    #   else
+    #     Applitools::EyesLogger.info "delete batch is done with #{close_batches_result}"
+    #   end
+    # end
   end
 end

data/lib/applitools/universal_sdk/universal_client.rb

@@ -93,8 +93,15 @@ module Applitools::Connectivity
       await(->(cb) { @socket.request(CORE_SET_VIEWPORT_SIZE, {driver: driver, size: size}, cb) })
     end
 
-    def core_close_batches(close_batch_settings)
+    def core_close_batches(close_batch_settings=nil)
       # batchIds, serverUrl?, apiKey?, proxy?
+      unless close_batch_settings.is_a?(Hash)
+        batch_ids = [@open_config[:batch][:id]]
+        batch_ids = [close_batch_settings] if close_batch_settings.is_a?(String)
+        batch_ids = close_batch_settings if close_batch_settings.is_a?(Array)
+        optional = [:serverUrl, :apiKey, :proxy].map {|k| [k, @open_config[k]] }.to_h
+        close_batch_settings = { settings: ({ batchIds: batch_ids }.merge(optional).compact) }
+      end
       await(->(cb) { @socket.request(CORE_CLOSE_BATCHES, close_batch_settings, cb) })
     end
 

data/lib/applitools/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: false
 
 module Applitools
-  VERSION = '4.0.4'.freeze
-  UNIVERSAL_VERSION = '2.5.7'.freeze
+  VERSION = '4.0.5'.freeze
+  UNIVERSAL_VERSION = '2.5.11'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eyes_core
 version: !ruby/object:Gem::Version
-  version: 4.0.4
+  version: 4.0.5
 platform: ruby
 authors:
 - Applitools Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-05-13 00:00:00.000000000 Z
+date: 2022-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.5.7
+        version: 2.5.11
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.5.7
+        version: 2.5.11
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement