eyes_core 3.17.17 → 3.17.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bec0e3de9fa596430d8a46e5274359fafb24bf610223181263cc74c7da18cc74
-  data.tar.gz: 2949d1c8638ecb578569fd55b69e3eaafdfc81fd7ad05cd35f0f5dc9c17bba7e
+  metadata.gz: 61272f8c794f0a12c2eb824d096987716ddfbc0e4a7fd9346687a4ebc71cc95f
+  data.tar.gz: 22a3c71582d53d02dc6bfd0911c094830483f8fe9738ed445e7636304ab96752
 SHA512:
-  metadata.gz: d79a7817840dafdd6102d6442a71f63fd5db7885e6de70432d9fd0f43c66805f533e0c439f25330253ca17b87e05c752996ea6001a0a63ecb5b74e690704780a
-  data.tar.gz: 214446f6d9a8e1fafe461970f560a9b65d353578a820ad18fb0dae523752f0dd7f3eab74ca530d2400198f97d9f7f5731f79bbf77e85d4949b051c7940607b5b
+  metadata.gz: b46455cced31d0443c153654f657087ae06c37501d62de78a1cddaac33a4e81045f5876c24e4c11bd91a4b252de546c09c5a65c9c1c47907b59b94a7b76c9975
+  data.tar.gz: 46d878ddb0273372f69d835127dc86becbd190cbe34e77fc838b1e66c8d00f28838540ae226175f1395385ff334afa2af398de55d21ff2ec087b83dcc135c217

data/lib/applitools/appium/android_region_provider.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+require_relative 'region_provider'
+module Applitools
+  module Appium
+    class AndroidRegionProvider < ::Applitools::Appium::RegionProvider
+      private
+
+      def convert_element_coordinates
+        Applitools::Region.from_location_size(eye_region.location, eye_region.size)
+      end
+
+      def convert_viewport_rect_coordinates
+        region  = viewport_rect
+        Applitools::Region.new(
+            region['left'],
+            region['top'],
+            region['width'],
+            region['height']
+        )
+      end
+    end
+  end
+end

data/lib/applitools/appium/eyes.rb

@@ -2,6 +2,7 @@
 
 class Applitools::Appium::Eyes < Applitools::Selenium::SeleniumEyes
   attr_accessor :status_bar_height
+
   def perform_driver_settings_for_appium_driver
     self.region_visibility_strategy = Applitools::Selenium::NopRegionVisibilityStrategy.new
     self.force_driver_resolution_as_viewport_size = true
@@ -51,7 +52,7 @@ class Applitools::Appium::Eyes < Applitools::Selenium::SeleniumEyes
 
     eyes_element = target_to_check.region_to_check.call(driver)
     self.eyes_element_to_check = eyes_element
-    region_provider = Applitools::Appium::RegionProvider.new(driver, eyes_element)
+    region_provider = region_provider_class.new(driver, eyes_element)
     match_data.read_target(target_to_check, driver)
 
     check_window_base(
@@ -119,16 +120,19 @@ class Applitools::Appium::Eyes < Applitools::Selenium::SeleniumEyes
 
   def viewport_screenshot
     logger.info 'Viewport screenshot requested...'
-
-    self.screenshot = screenshot_class.new(
-      Applitools::Screenshot.from_datastream(driver.screenshot_as(:png))
-    )
+    obtain_viewport_screenshot
   end
 
   def element_screenshot
     logger.info 'Element screenshot requested...'
+    obtain_viewport_screenshot
+  end
+
+  def obtain_viewport_screenshot
     self.screenshot = screenshot_class.new(
-      Applitools::Screenshot.from_datastream(driver.element_screenshot_as(eyes_element_to_check, :png))
+        Applitools::Screenshot.from_datastream(driver.screenshot_as(:png)),
+        status_bar_height: Applitools::Utils::EyesSeleniumUtils.status_bar_height(driver),
+        device_pixel_ratio: Applitools::Utils::EyesSeleniumUtils.device_pixel_ratio(driver)
     )
   end
 
@@ -137,4 +141,10 @@ class Applitools::Appium::Eyes < Applitools::Selenium::SeleniumEyes
     return Applitools::Appium::AndroidScreenshot if Applitools::Utils::EyesSeleniumUtils.android?(Applitools::Appium::Driver::AppiumLib)
     raise Applitools::EyesError, 'Unknown device type'
   end
+
+  def region_provider_class
+    return Applitools::Appium::IosRegionProvider if Applitools::Utils::EyesSeleniumUtils.ios?(Applitools::Appium::Driver::AppiumLib)
+    return Applitools::Appium::AndroidRegionProvider if Applitools::Utils::EyesSeleniumUtils.android?(Applitools::Appium::Driver::AppiumLib)
+    raise Applitools::EyesError, 'Unknown device type'
+  end
 end

data/lib/applitools/appium/ios_region_provider.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+#
+require_relative 'region_provider'
+module Applitools
+  module Appium
+    class IosRegionProvider < ::Applitools::Appium::RegionProvider
+      private
+
+      def convert_element_coordinates
+        Applitools::Region.from_location_size(eye_region.location, eye_region.size).
+            scale_it!(scale_factor)
+      end
+
+      def convert_viewport_rect_coordinates
+        region  = viewport_rect
+        Applitools::Region.new(
+          region['left'],
+          region['top'],
+          region['width'],
+          region['height']
+        )
+      end
+    end
+  end
+end

data/lib/applitools/appium/region_provider.rb

@@ -3,23 +3,48 @@
 module Applitools
   module Appium
     class RegionProvider
-      attr_accessor :driver, :eye_region, :coordinate_type
+      attr_accessor :driver, :eye_region, :region_to_check
 
       def initialize(driver, eye_region)
         self.driver = driver
         self.eye_region = eye_region
+        self.region_to_check = Applitools::Region::EMPTY
+        convert_region_coordinates
       end
 
       def region
-        return Applitools::Region::EMPTY if
-            [::Selenium::WebDriver::Element, Applitools::Selenium::Element].include? eye_region.class
-        region = driver.session_capabilities['viewportRect']
-        Applitools::Region.new(
-          region['left'],
-          region['top'],
-          region['width'],
-          region['height']
-        )
+        region_to_check
+      end
+
+      def coordinate_type
+        nil
+      end
+
+      private
+
+      def viewport_rect
+        Applitools::Utils::EyesSeleniumUtils.viewport_rect(driver)
+      end
+
+      def convert_region_coordinates
+        self.region_to_check = case eye_region
+                               when ::Selenium::WebDriver::Element, Applitools::Selenium::Element
+                                  convert_element_coordinates
+                               else
+                                  convert_viewport_rect_coordinates
+                               end
+      end
+
+      def convert_element_coordinates
+        raise Applitools::AbstractMethodCalled.new(:convert_region_coordinates, 'Applitools::Appium::RegionProvider')
+      end
+
+      def convert_viewport_rect_coordinates
+        raise Applitools::AbstractMethodCalled.new(:convert_viewport_rect_coordinates, 'Applitools::Appium::RegionProvider')
+      end
+
+      def scale_factor
+        Applitools::Utils::EyesSeleniumUtils.device_pixel_ratio(driver)
       end
     end
   end

data/lib/applitools/appium/utils.rb

@@ -28,7 +28,7 @@ module Applitools::Appium
     def device_pixel_ratio(executor)
       session_info = session_capabilities(executor)
       return session_info['pixelRatio'].to_f if session_info['pixelRatio']
-      Applitools::Selenium::Eyes::UNKNOWN_DEVICE_PIXEL_RATIO
+      1
     end
 
     def status_bar_height(executor)
@@ -37,6 +37,17 @@ module Applitools::Appium
       0
     end
 
+    def viewport_rect(executor)
+      session_info = session_capabilities(executor)
+      return session_info['viewportRect'] if session_info['viewportRect']
+      {
+        'left' => 0,
+        'top' => 0,
+        'width' => 0,
+        'height' => 0
+      }
+    end
+
     def session_capabilities(executor)
        executor.session_capabilities if executor.respond_to? :session_capabilities
     end

data/lib/applitools/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: false
 
 module Applitools
-  VERSION = '3.17.17'.freeze
+  VERSION = '3.17.18'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eyes_core
 version: !ruby/object:Gem::Version
-  version: 3.17.17
+  version: 3.17.18
 platform: ruby
 authors:
 - Applitools Team
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-29 00:00:00.000000000 Z
+date: 2020-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oily_png
@@ -260,11 +260,13 @@ files:
 - ext/eyes_core/extconf.rb
 - ext/eyes_core/eyes_core.c
 - ext/eyes_core/eyes_core.h
+- lib/applitools/appium/android_region_provider.rb
 - lib/applitools/appium/android_screenshot.rb
 - lib/applitools/appium/driver.rb
 - lib/applitools/appium/eyes.rb
 - lib/applitools/appium/initialize_1.9.rb
 - lib/applitools/appium/initialize_2.0.rb
+- lib/applitools/appium/ios_region_provider.rb
 - lib/applitools/appium/ios_screenshot.rb
 - lib/applitools/appium/region_provider.rb
 - lib/applitools/appium/screenshot.rb