ey_services_api 0.3.15 → 0.3.16

data/EYIntegratedGemfile

@@ -6,6 +6,7 @@ gemspec
 group :test, :development do
   gemspec :path => "fake"
   gem 'rake'
+  gem 'timecop'
 
   #private Gem deps of fake_awsm
   gem 'ey_sso', :git => "git@github.com:engineyard/ey_sso.git", :ref => "v0.13.1"

data/Gemfile

@@ -5,6 +5,7 @@ gemspec
 
 group :test, :development do
   gemspec :path => "fake"
+  gem 'timecop'
 
   gem 'rake'
   gem 'guard-rspec'

data/lib/ey_services_api/connection.rb

@@ -63,6 +63,22 @@ module EY
         post(invoices_url, :invoice => invoice.to_hash)
       end
 
+      def list_invoices(invoices_url)
+        get(invoices_url) do |json_body, response_location|
+          json_body.map do |json_item|
+            invoice = Invoice.new(json_item["invoice"])
+            invoice.connection = self
+            invoice.url = json_item["invoice"]["url"]
+            invoice.status = json_item["invoice"]["status"]
+            invoice
+          end
+        end
+      end
+
+      def destroy_invoice(url)
+        delete(url)
+      end
+
     end
   end
 end

data/lib/ey_services_api/invoice.rb

@@ -1,6 +1,14 @@
 module EY
   module ServicesAPI
-    class Invoice < APIStruct.new(:total_amount_cents, :line_item_description)
+    class Invoice < APIStruct.new(:total_amount_cents, :line_item_description, :unique_id)
+      attr_accessor :connection
+      attr_accessor :url
+      attr_accessor :status
+
+      def destroy
+        connection.destroy_invoice(self.url)
+      end
+
     end
   end
 end

data/lib/ey_services_api/version.rb

@@ -1,5 +1,5 @@
 module EY
   module ServicesAPI
-    VERSION = "0.3.15"
+    VERSION = "0.3.16"
   end
 end

data/spec/invoice_spec.rb

@@ -1,11 +1,16 @@
 #because there may be multiple 'spec_helper' in load path when running from external test helper
 require File.expand_path('../spec_helper.rb', __FILE__)
+require 'timecop'
 
 describe EY::ServicesAPI::Invoice do
   before do
     @service_account = @tresfiestas.service_account
     @invoices_url = @service_account[:invoices_url]
     @connection = EY::ServicesAPI.connection
+    Timecop.return
+  end
+  after do
+    Timecop.return
   end
 
   it "can send an invoice" do
@@ -17,6 +22,104 @@ describe EY::ServicesAPI::Invoice do
     latest_invoice[:service_account_id].should eq @service_account[:id]
   end
 
+  it "duplicate blank uniq identifiers don't cause conflicts" do
+    invoice = EY::ServicesAPI::Invoice.new(:total_amount_cents => 500, :line_item_description => "good stuff", :unique_id => "")
+    @connection.send_invoice(@invoices_url, invoice)
+    invoice = EY::ServicesAPI::Invoice.new(:total_amount_cents => 5000, :line_item_description => "duplicate stuff ok", :unique_id => "")
+    @connection.send_invoice(@invoices_url, invoice)
+  end
+
+  internal_only_tests do
+
+    it "can send an invoice with uniq identifier, returns error for duplicates" do
+      invoice = EY::ServicesAPI::Invoice.new(:total_amount_cents => 500, :line_item_description => "good stuff", :unique_id => "ABCDEFG123")
+      @connection.send_invoice(@invoices_url, invoice)
+      lambda{
+        invoice = EY::ServicesAPI::Invoice.new(:total_amount_cents => 5000, :line_item_description => "duplicate stuff BAD", :unique_id => "ABCDEFG123")
+        @connection.send_invoice(@invoices_url, invoice)
+      }.should raise_error(EY::ServicesAPI::Connection::ValidationError, /Unique ID already exists on another invoice on this account/)
+    end
+
+  end
+
+  it "can list invoices, can delete pending invoices" do
+    invoice = EY::ServicesAPI::Invoice.new(:total_amount_cents => 500, :line_item_description => "good stuff", :unique_id => 123)
+    @connection.send_invoice(@invoices_url, invoice)
+    invoices = @connection.list_invoices(@invoices_url)
+    invoices.size.should eq 1
+    invoice = invoices.first
+    invoice.total_amount_cents.should eq 500
+    invoice.line_item_description.should eq "good stuff"
+    invoice.unique_id.should eq "123"
+    invoice.status.should eq "pending"
+    invoice.destroy
+    @connection.list_invoices(@invoices_url).size.should eq 0
+  end
+
+  internal_only_tests do
+
+    it "can list invoices, can delete pending invoices on the first of the month" do
+      Timecop.travel(Time.now.beginning_of_month + 12.hours)
+      invoice = EY::ServicesAPI::Invoice.new(:total_amount_cents => 500, :line_item_description => "good stuff", :unique_id => 123)
+      @connection.send_invoice(@invoices_url, invoice)
+      invoices = @connection.list_invoices(@invoices_url)
+      invoices.size.should eq 1
+      invoice = invoices.first
+      invoice.total_amount_cents.should eq 500
+      invoice.line_item_description.should eq "good stuff"
+      invoice.unique_id.should eq "123"
+      invoice.status.should eq "pending"
+      invoice.destroy
+      @connection.list_invoices(@invoices_url).size.should eq 0
+    end
+
+    it "invoices become locked 24 hours after the account is canceled, can't be deleted" do
+      @tresfiestas.destroy_service_account
+      invoice = EY::ServicesAPI::Invoice.new(:total_amount_cents => 500, :line_item_description => "good stuff", :unique_id => 123)
+      @connection.send_invoice(@invoices_url, invoice)
+      Timecop.travel(Time.now + 1.day + 1.minute)
+      invoices = @connection.list_invoices(@invoices_url)
+      invoices.size.should eq 1
+      invoice = invoices.first
+      invoice.total_amount_cents.should eq 500
+      invoice.line_item_description.should eq "good stuff"
+      invoice.unique_id.should eq "123"
+      invoice.status.should eq "locked"
+      lambda{
+        invoice.destroy
+      }.should raise_error(EY::ServicesAPI::Connection::ValidationError, /cannot delete locked invoices/)
+    end
+
+    it "invoices become locked 24 after end of month, and 24 hours after the account is canceled, can't be deleted" do
+      invoice = EY::ServicesAPI::Invoice.new(:total_amount_cents => 500, :line_item_description => "good stuff", :unique_id => 123)
+      @connection.send_invoice(@invoices_url, invoice)
+      Timecop.travel(Time.now.end_of_month + 1.day + 1.minute)
+      invoices = @connection.list_invoices(@invoices_url)
+      invoices.size.should eq 1
+      invoice = invoices.first
+      invoice.total_amount_cents.should eq 500
+      invoice.line_item_description.should eq "good stuff"
+      invoice.unique_id.should eq "123"
+      invoice.status.should eq "locked"
+      lambda{
+        invoice.destroy
+      }.should raise_error(EY::ServicesAPI::Connection::ValidationError, /cannot delete locked invoices/)
+    end
+
+    it "returns an error when posting invoices to canceled service accounts" do
+      @tresfiestas.destroy_service_account
+      invoice = EY::ServicesAPI::Invoice.new(:total_amount_cents => 500, :line_item_description => "good stuff")
+      @connection.send_invoice(@invoices_url, invoice)
+
+      Timecop.travel(Time.now + 1.day + 1.minute)
+      lambda{
+        invoice = EY::ServicesAPI::Invoice.new(:total_amount_cents => 500, :line_item_description => "good stuff")
+        @connection.send_invoice(@invoices_url, invoice)
+      }.should raise_error(EY::ServicesAPI::Connection::ValidationError, /Account is no longer active, and cannot accept any invoices/)
+    end
+
+  end
+
   it "returns an error for fractional ammounts for total_amount_cents" do
     lambda{
       invoice = EY::ServicesAPI::Invoice.new(:total_amount_cents => 4.50, :line_item_description => "fractional stuff")

data/spec/spec_helper.rb

@@ -16,3 +16,9 @@ RSpec.configure do |config|
     @tresfiestas = EY::ServicesAPI.mock_backend
   end
 end
+
+def internal_only_tests
+  if ENV["BUNDLE_GEMFILE"] == "EYIntegratedGemfile"
+    yield
+  end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: ey_services_api
 version: !ruby/object:Gem::Version 
-  hash: 13
+  hash: 51
   prerelease: 
   segments: 
   - 0
   - 3
-  - 15
-  version: 0.3.15
+  - 16
+  version: 0.3.16
 platform: ruby
 authors: 
 - Jacob & Thorben & David & mkb & Josh & Others
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-08-07 00:00:00 Z
+date: 2012-11-01 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rspec
@@ -147,7 +147,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: ey_services_api
-rubygems_version: 1.8.10
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: API for Partner Services (talks to services.engineyard.com)