ey_api_hmac 0.4.2 → 0.4.3

data/Gemfile

@@ -7,6 +7,7 @@ gem 'rake'
 gem 'json'
 
 group :test, :development do
+  gem 'pry'
   gem 'halorgium-auth-hmac'
   gem 'rack-client'
   gem 'rack-contrib'

data/lib/ey_api_hmac/authed_connection.rb

@@ -9,19 +9,7 @@ module EY
         @auth_id = auth_id
         @auth_key = auth_key
         super(user_agent)
-      end
-
-    protected
-
-      def client
-        bak = self.backend
-        #damn you scope!
-        auth_id_arg = auth_id
-        auth_key_arg = auth_key
-        @client ||= Rack::Client.new do
-          use EY::ApiHMAC::ApiAuth::Client, auth_id_arg, auth_key_arg
-          run bak
-        end
+        self.middlewares.unshift [EY::ApiHMAC::ApiAuth::Client, auth_id, auth_key]
       end
 
     end

data/lib/ey_api_hmac/base_connection.rb

@@ -1,4 +1,5 @@
 require 'rack/client'
+require 'rack-idempotent'
 require 'json'
 require 'time'
 
@@ -6,12 +7,15 @@ module EY
   module ApiHMAC
     class BaseConnection
 
+      attr_accessor :middlewares
+
       def initialize(user_agent = nil)
         @standard_headers = {
           'Accept' => 'application/json',
           'HTTP_DATE' => Time.now.httpdate,
           'USER_AGENT' => user_agent || default_user_agent
         }
+        self.middlewares = [Rack::Idempotent]
       end
 
       def default_user_agent
@@ -74,10 +78,14 @@ module EY
     protected
 
       def client
-        bak = self.backend
+        #damn you scope!
+        backend = self.backend
+        middlewares = self.middlewares
         @client ||= Rack::Client.new do
-          use Rack::Idempotent
-          run bak
+          middlewares.each do |middleware|
+            use *Array(middleware)
+          end
+          run backend
         end
       end
 

data/lib/ey_api_hmac/version.rb

@@ -1,5 +1,5 @@
 module EY
   module ApiHMAC
-    VERSION = "0.4.2"
+    VERSION = "0.4.3"
   end
 end

data/spec/authed_connection_spec.rb

@@ -9,7 +9,7 @@ describe EY::ApiHMAC::AuthedConnection do
     describe "on 500" do
       before do
         @connection.backend = lambda do |env|
-          ["500", {}, [""]]
+          [500, {}, [""]]
         end
       end
       it "raises an error" do
@@ -24,7 +24,7 @@ describe EY::ApiHMAC::AuthedConnection do
     describe "on bad body" do
       it "calls the error handler" do
         @connection.backend = lambda do |env|
-          ["200", {"Content-Type" => "application/json"}, ["200 OK"]]
+          [200, {"Content-Type" => "application/json"}, ["200 OK"]]
         end
         errors = []
         @connection.handle_errors_with{|*args| errors << args; false}
@@ -41,4 +41,14 @@ describe EY::ApiHMAC::AuthedConnection do
       end
     end
   end
+  describe "uses Rack Idempotent" do
+    before do
+      @connection.backend = lambda do |env|
+        [408, {}, [""]]
+      end
+    end
+    it "raises an error" do
+      lambda { @connection.get("/") }.should raise_exception(Rack::Idempotent::RetryLimitExceeded)
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+require 'pry'
+
 class MockAuth
   def initialize(is_found, auth_key)
     @is_found = is_found

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: ey_api_hmac
 version: !ruby/object:Gem::Version 
-  hash: 11
+  hash: 9
   prerelease: 
   segments: 
   - 0
   - 4
-  - 2
-  version: 0.4.2
+  - 3
+  version: 0.4.3
 platform: ruby
 authors: 
 - "Jacob Burkhart & Thorben Schr\xC3\xB6der & David Calavera & others"
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-07 00:00:00 Z
+date: 2012-02-09 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rack-client