ey_api_hmac 0.0.16 → 0.0.17

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ey_api_hmac (0.0.15)
+    ey_api_hmac (0.0.16)
       json
       rack-client
 

data/lib/ey_api_hmac/sso.rb

@@ -17,6 +17,7 @@ module EY
 
       def self.authenticated?(url, auth_id, auth_key)
         uri = URI.parse(url)
+        return false unless uri.query
         query_params = CGI::parse(uri.query)
         signature = query_params.delete("signature").to_s
         uri.query = params_to_string(query_params)

data/lib/ey_api_hmac/version.rb

@@ -1,5 +1,5 @@
 module EY
   module ApiHMAC
-    VERSION = "0.0.16"
+    VERSION = "0.0.17"
   end
 end

data/spec/sso_spec.rb

@@ -35,6 +35,10 @@ describe EY::ApiHMAC do
       EY::ApiHMAC::SSO.authenticated?(signed_url + 'a',  @auth_id, @auth_key).should be_false
     end
 
+    it "can verify requests with no query as invalid" do
+      EY::ApiHMAC::SSO.authenticated?("http://example.com/sign_test",  @auth_id, @auth_key).should be_false
+    end
+
     it "catches changes to the url" do
       signed_url = EY::ApiHMAC::SSO.sign(@url, @parameters, @auth_id, @auth_key)
       EY::ApiHMAC::SSO.authenticated?(signed_url,  @auth_id, @auth_key).should be_true

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: ey_api_hmac
 version: !ruby/object:Gem::Version 
-  hash: 63
+  hash: 61
   prerelease: 
   segments: 
   - 0
   - 0
-  - 16
-  version: 0.0.16
+  - 17
+  version: 0.0.17
 platform: ruby
 authors: 
 - "Jacob Burkhart & Thorben Schr\xC3\xB6der & David Calavera & others"