exwiw 0.2.7 → 0.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ad123bcfe1cadde34a031d1db34fb4592892b88765d3b979c2fb827b53578f7
-  data.tar.gz: 59b2263b51e51f95e9f8d79cbc214dc0f385202e7ca120d108f3f64e18832a52
+  metadata.gz: 21a9432692220a23b0109497b0ffcb3f1c7f0fc360248c3590f730a4a98452ec
+  data.tar.gz: bf0847f90a24c8da3cf078f1c18e5d22f9827b705bc13945ddfc28f8e42460f1
 SHA512:
-  metadata.gz: f79b7338d57d93eebbfba42d81ff6a3f3c232dbb9163118e42d4f67b73844c50234910d3add9eafe72ff4f854d5497191ac7cb37a4ec1da1647dfb1987c118be
-  data.tar.gz: 22c97b02f4cb68badb0bc3e404996af4a48f46f0c32f0366cf0845a6e683b5d4a6a1af3ed499dae425d9adafe131f5c86eca933d5f51eac3d3d4458e508f36a8
+  metadata.gz: c59e201f1180e2fb6191506647b78a82c43d7d124117c0d87e2cdcbfd8fa68ff30653accc9a22d82434d7e680496eed41d91c7b150b8b884b3b545b344b91d72
+  data.tar.gz: 600e4a3b8d134d43182b81017b8b4ad9a352824a76a351300ca3fc22ee4942ceccf6f8404eb6e04e2a2320a79849ddc6b3cacf0c3510c7b8acca0c06820eaa22

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## [Unreleased]
 
+## [0.2.8] - 2026-05-31
+
+### Added
+
+- `schema:generate` now supports polymorphic `belongs_to` associations. Each polymorphic relation (`belongs_to :reviewable, polymorphic: true`) is expanded into one `belongs_to` entry per concrete target table — discovered from the other models' `has_many` / `has_one ..., as:` declarations — carrying `foreign_type` (the type column, e.g. `reviewable_type`) and `type_value` (the stored type, e.g. `"Product"`). Targets are ordered by table name so the generated output is stable across Ruby versions. At dump time, a polymorphic `belongs_to` on the path to the dump target is constrained by both the foreign key and the type column — in both the `SELECT` and the `delete-*.sql` bulk-delete subquery — so only rows of the matching type are extracted. ([#43](https://github.com/heyinc/exwiw/pull/43))
+
 ## [0.2.7] - 2026-05-30
 
 ### Added

data/README.md

@@ -241,6 +241,47 @@ Constraints:
 - Specifying a skipped table as `--target-table` raises `ArgumentError`.
 - `skip: true` is preserved by `exwiw:schema:generate` regenerations (the receiver value wins over the auto-generated config).
 
+### Polymorphic `belongs_to`
+
+A Rails polymorphic association (`belongs_to :reviewable, polymorphic: true`) does not point at a single table — the target row is selected at runtime by a type column. exwiw models this as **one `belongs_to` entry per concrete target table**, each carrying two extra fields:
+
+- `foreign_type` — the type column on *this* table (e.g. `reviewable_type`).
+- `type_value` — the value stored in that column for this target (e.g. `"Product"`), i.e. the target model's `polymorphic_name`.
+
+```json
+{
+  "name": "reviews",
+  "primary_key": "id",
+  "belongs_tos": [
+    {
+      "table_name": "products",
+      "foreign_key": "reviewable_id",
+      "foreign_type": "reviewable_type",
+      "type_value": "Product"
+    },
+    {
+      "table_name": "shops",
+      "foreign_key": "reviewable_id",
+      "foreign_type": "reviewable_type",
+      "type_value": "Shop"
+    }
+  ],
+  "columns": [{ "name": "id" }, { "name": "reviewable_type" }, { "name": "reviewable_id" }]
+}
+```
+
+`exwiw:schema:generate` expands a polymorphic `belongs_to` automatically: it finds every model that registers the association as a target via `has_many` / `has_one ..., as: :reviewable` and emits one entry per target table (ordered by table name so the output is stable across Ruby versions). A plain (non-polymorphic) `belongs_to` simply omits `foreign_type` / `type_value`.
+
+At dump time, when a polymorphic `belongs_to` lies on the path to the dump target, exwiw constrains **both** the foreign key and the type column, so only rows of the matching type are extracted. For example, dumping `products` pulls only reviews whose `reviewable_type = 'Product'`:
+
+```sql
+SELECT reviews.* FROM reviews
+WHERE reviews.reviewable_id IN (/* products subquery */)
+  AND reviews.reviewable_type = 'Product'
+```
+
+The same type filter is applied on the join path — and in the matching `delete-*.sql` bulk-delete subquery — when the polymorphic table is an intermediate hop rather than the directly-dumped table.
+
 ### Rails-managed tables (special `type` values)
 
 Some tables are owned by Rails itself rather than the application — they have no ActiveRecord model and Rails reserves the right to evolve their column shape between versions (e.g. `schema_migrations`, `ar_internal_metadata`). exwiw treats them as a distinct category via the `type` field on a table config:

data/lib/exwiw/adapter/mysql2_adapter.rb

@@ -136,7 +136,18 @@ module Exwiw
 
         foreign_key = first_join.foreign_key
         subquery_sql = compile_ast(subquery_ast)
-        sql += "\nWHERE #{select_query_ast.from_table_name}.#{foreign_key} IN (#{subquery_sql});"
+        sql += "\nWHERE #{select_query_ast.from_table_name}.#{foreign_key} IN (#{subquery_sql})"
+
+        # first_join.base_where_clauses は外側の削除対象テーブル
+        # (from_table_name) 上の条件 (polymorphic 型カラム等)。subquery には
+        # 含まれないため、外側の WHERE に追加する。これにより、別の
+        # polymorphic 型に属する行まで削除してしまうのを防ぐ。
+        first_join.base_where_clauses.each do |where|
+          next unless where.is_a?(Exwiw::QueryAst::WhereClause)
+
+          sql += " AND #{compile_where_condition(where, select_query_ast.from_table_name)}"
+        end
+        sql += ";"
 
         sql
       end
@@ -159,6 +170,13 @@ module Exwiw
             compiled_where_condition = compile_where_condition(where, join.join_table_name)
             sql += " AND #{compiled_where_condition}"
           end
+
+          # base_where_clauses は結合元テーブル (base_table_name) に対して
+          # コンパイルする。polymorphic な結合元テーブルの型カラム絞り込み等。
+          join.base_where_clauses.each do |where|
+            compiled_where_condition = compile_where_condition(where, join.base_table_name)
+            sql += " AND #{compiled_where_condition}"
+          end
         end
 
         if query_ast.where_clauses.any?

data/lib/exwiw/adapter/postgresql_adapter.rb

@@ -178,7 +178,18 @@ module Exwiw
 
         foreign_key = first_join.foreign_key
         subquery_sql = compile_ast(subquery_ast)
-        sql += "\nWHERE #{select_query_ast.from_table_name}.#{foreign_key} IN (#{subquery_sql});"
+        sql += "\nWHERE #{select_query_ast.from_table_name}.#{foreign_key} IN (#{subquery_sql})"
+
+        # first_join.base_where_clauses は外側の削除対象テーブル
+        # (from_table_name) 上の条件 (polymorphic 型カラム等)。subquery には
+        # 含まれないため、外側の WHERE に追加する。これにより、別の
+        # polymorphic 型に属する行まで削除してしまうのを防ぐ。
+        first_join.base_where_clauses.each do |where|
+          next unless where.is_a?(Exwiw::QueryAst::WhereClause)
+
+          sql += " AND #{compile_where_condition(where, select_query_ast.from_table_name)}"
+        end
+        sql += ";"
 
         sql
       end
@@ -201,6 +212,13 @@ module Exwiw
             compiled_where_condition = compile_where_condition(where, join.join_table_name)
             sql += " AND #{compiled_where_condition}"
           end
+
+          # base_where_clauses は結合元テーブル (base_table_name) に対して
+          # コンパイルする。polymorphic な結合元テーブルの型カラム絞り込み等。
+          join.base_where_clauses.each do |where|
+            compiled_where_condition = compile_where_condition(where, join.base_table_name)
+            sql += " AND #{compiled_where_condition}"
+          end
         end
 
         if query_ast.where_clauses.any?

data/lib/exwiw/adapter/sqlite3_adapter.rb

@@ -123,7 +123,18 @@ module Exwiw
 
         foreign_key = first_join.foreign_key
         subquery_sql = compile_ast(subquery_ast)
-        sql += "\nWHERE #{select_query_ast.from_table_name}.#{foreign_key} IN (#{subquery_sql});"
+        sql += "\nWHERE #{select_query_ast.from_table_name}.#{foreign_key} IN (#{subquery_sql})"
+
+        # first_join.base_where_clauses は外側の削除対象テーブル
+        # (from_table_name) 上の条件 (polymorphic 型カラム等)。subquery には
+        # 含まれないため、外側の WHERE に追加する。これにより、別の
+        # polymorphic 型に属する行まで削除してしまうのを防ぐ。
+        first_join.base_where_clauses.each do |where|
+          next unless where.is_a?(Exwiw::QueryAst::WhereClause)
+
+          sql += " AND #{compile_where_condition(where, select_query_ast.from_table_name)}"
+        end
+        sql += ";"
 
         sql
       end
@@ -146,6 +157,13 @@ module Exwiw
             compiled_where_condition = compile_where_condition(where, join.join_table_name)
             sql += " AND #{compiled_where_condition}"
           end
+
+          # base_where_clauses は結合元テーブル (base_table_name) に対して
+          # コンパイルする。polymorphic な結合元テーブルの型カラム絞り込み等。
+          join.base_where_clauses.each do |where|
+            compiled_where_condition = compile_where_condition(where, join.base_table_name)
+            sql += " AND #{compiled_where_condition}"
+          end
         end
 
         if query_ast.where_clauses.any?

data/lib/exwiw/belongs_to.rb

@@ -6,9 +6,22 @@ module Exwiw
 
     attribute :foreign_key, String
     attribute :table_name, String
+    # polymorphic 関連の場合のみ設定される。`foreign_type` は型を格納するカラム名
+    # (例: `reviewable_type`)、`type_value` はそのカラムに入る値 (例: `"Product"`)。
+    # 非 polymorphic の belongs_to では両方とも nil。
+    attribute :foreign_type, optional(String), skip_serializing_if_nil: true
+    attribute :type_value, optional(String), skip_serializing_if_nil: true
 
     def self.from_symbol_keys(hash)
       from(hash.transform_keys(&:to_s))
     end
+
+    def polymorphic?
+      !foreign_type.nil?
+    end
+
+    def to_hash
+      super.compact
+    end
   end
 end

data/lib/exwiw/query_ast.rb

@@ -3,14 +3,20 @@
 module Exwiw
   module QueryAst
     class JoinClause
-      attr_reader :base_table_name, :foreign_key, :join_table_name, :primary_key, :where_clauses
+      # `where_clauses` はこの join の join_table_name (= 結合先テーブル) に対して
+      # コンパイルされる。一方 `base_where_clauses` は base_table_name (= 結合元
+      # テーブル) に対してコンパイルされる。後者は、結合元テーブルが結合先へ
+      # polymorphic belongs_to していて型カラム (foreign_type) が結合元テーブル
+      # 側に存在するケースのために使う。
+      attr_reader :base_table_name, :foreign_key, :join_table_name, :primary_key, :where_clauses, :base_where_clauses
 
-      def initialize(base_table_name:, foreign_key:, join_table_name:, primary_key:, where_clauses: [])
+      def initialize(base_table_name:, foreign_key:, join_table_name:, primary_key:, where_clauses: [], base_where_clauses: [])
         @base_table_name = base_table_name
         @foreign_key = foreign_key
         @join_table_name = join_table_name
         @primary_key = primary_key
         @where_clauses = where_clauses
+        @base_where_clauses = base_where_clauses
       end
 
       def to_h
@@ -23,6 +29,9 @@ module Exwiw
         if where_clauses.size.positive?
           hash[:where_clauses] = where_clauses.map { |wc| wc.is_a?(String) ? wc : wc.to_h }
         end
+        if base_where_clauses.size.positive?
+          hash[:base_where_clauses] = base_where_clauses.map { |wc| wc.is_a?(String) ? wc : wc.to_h }
+        end
         hash
       end
     end

data/lib/exwiw/query_ast_builder.rb

@@ -54,8 +54,23 @@ module Exwiw
           foreign_key: relation.foreign_key,
           join_table_name: to_table.name,
           primary_key: to_table.primary_key,
-          where_clauses: []
+          where_clauses: [],
+          base_where_clauses: []
         )
+
+        # この hop 自体が polymorphic belongs_to の場合 (例: comments が
+        # commentable として posts へ polymorphic belongs_to)、型カラム
+        # (foreign_type) は結合元テーブル (from_table = base_table_name) 側に
+        # 存在する。外部キーだけでは reviewable_id=1 のような値が別モデルの
+        # 行と衝突しうるため、base_where_clauses に型条件を追加して結合元
+        # テーブルを絞り込む。
+        if relation.polymorphic?
+          join_clause.base_where_clauses.push QueryAst::WhereClause.new(
+            column_name: relation.foreign_type,
+            operator: :eq,
+            value: [relation.type_value]
+          )
+        end
         relation_to_dump_target = to_table.belongs_to(dump_target.table_name)
         if relation_to_dump_target
           join_clause.where_clauses.push QueryAst::WhereClause.new(
@@ -63,6 +78,18 @@ module Exwiw
             operator: :eq,
             value: dump_target.ids
           )
+
+          # 中間テーブルが dump target へ polymorphic belongs_to している場合は、
+          # 型カラム (foreign_type) も join 条件に追加する。型カラムは to_table
+          # (= join_table_name) 上に存在するため、JoinClause の where_clauses が
+          # join_table_name に対してコンパイルされる仕組みにそのまま乗せられる。
+          if relation_to_dump_target.polymorphic?
+            join_clause.where_clauses.push QueryAst::WhereClause.new(
+              column_name: relation_to_dump_target.foreign_type,
+              operator: :eq,
+              value: [relation_to_dump_target.type_value]
+            )
+          end
         end
 
         # Add filter from intermediate table to join clause
@@ -98,6 +125,17 @@ module Exwiw
         value: dump_target.ids
       )
 
+      # polymorphic belongs_to の場合は外部キーだけでは型を区別できないため
+      # (例: reviewable_id=1 が Product なのか別モデルなのか判別できない)、
+      # 型カラム (foreign_type) を type_value で絞り込む条件を追加する。
+      if belongs_to.polymorphic?
+        clauses.push Exwiw::QueryAst::WhereClause.new(
+          column_name: belongs_to.foreign_type,
+          operator: :eq,
+          value: [belongs_to.type_value]
+        )
+      end
+
       if table.filter
         clauses.push table.filter
       end

data/lib/exwiw/schema_generator.rb

@@ -145,15 +145,44 @@ module Exwiw
     end
 
     private def aggregate_belongs_tos(models)
-      pairs = models
-        .flat_map { |m| m.reflect_on_all_associations(:belongs_to) }
-        .reject(&:polymorphic?) # XXX: Support polymorphic
-        .map { |assoc| [assoc.table_name, assoc.foreign_key] }
-        .uniq
-
-      pairs.map do |table_name, foreign_key|
-        { table_name: table_name, foreign_key: foreign_key }
-      end
+      belongs_to_assocs = models.flat_map { |m| m.reflect_on_all_associations(:belongs_to) }
+
+      non_polymorphic = belongs_to_assocs
+        .reject(&:polymorphic?)
+        .map { |assoc| { table_name: assoc.table_name, foreign_key: assoc.foreign_key } }
+
+      # polymorphic な belongs_to (`belongs_to :reviewable, polymorphic: true`) は
+      # 単一の対象テーブルを持たない。対象になりうるテーブルは、他モデルで
+      # `has_many/has_one ..., as: <association_name>` と宣言されている側から逆引き
+      # する。各候補テーブルごとに、型カラム (`foreign_type`) と格納される型の値
+      # (`type_value`) を添えた belongs_to を 1 件ずつ展開する。
+      polymorphic = belongs_to_assocs
+        .select(&:polymorphic?)
+        .flat_map do |assoc|
+          polymorphic_target_models(assoc.name).map do |target_model|
+            {
+              table_name: target_model.table_name,
+              foreign_key: assoc.foreign_key,
+              foreign_type: assoc.foreign_type,
+              type_value: target_model.polymorphic_name,
+            }
+          end
+        end
+
+      (non_polymorphic + polymorphic).uniq
+    end
+
+    # polymorphic 関連 `association_name` の対象となりうる具象モデルを、全モデルの
+    # `has_many` / `has_one` の `as:` オプションから逆引きして列挙する。
+    # `concrete_models` の並びは `ActiveRecord::Base.descendants` の順に依存し、
+    # Ruby バージョンによって変わりうるため、生成される belongs_to の並びが安定する
+    # よう `table_name` でソートして決定的に返す。
+    private def polymorphic_target_models(association_name)
+      concrete_models.select do |model|
+        (model.reflect_on_all_associations(:has_many) +
+         model.reflect_on_all_associations(:has_one))
+          .any? { |reflection| reflection.options[:as] == association_name }
+      end.sort_by(&:table_name)
     end
 
     # Identifies which database a model belongs to. With Rails multi-DB

data/lib/exwiw/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Exwiw
-  VERSION = "0.2.7"
+  VERSION = "0.2.8"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: exwiw
 version: !ruby/object:Gem::Version
-  version: 0.2.7
+  version: 0.2.8
 platform: ruby
 authors:
 - Shia