externallink 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8bd46ca3958d62bc101d1270763992cdf259d6e2
-  data.tar.gz: 442c4c5e96d31d5834148c1175eff5da5e875c89
+  metadata.gz: 087377f62b27385ffaaf1e13b1a710f3adb4fabd
+  data.tar.gz: eeda78989c34e51e86fd413fccefa1c75390547a
 SHA512:
-  metadata.gz: 20bea68e341fa1c413a818f22515ed2b1eb37fa7a1239433593de5a889bb219eac8aca81ee4190d400d26219c0be400dc4efd1273be5ac5cc00d22a1134252bf
-  data.tar.gz: 744c07f5db5f7311b3547303586541594b0626d821d262a5d4f756cfc51a3442fd286ea9c8c680ea5808ea2e8b3825ad686bbf2aa4cdfc0cfcb997acf4299b6b
+  metadata.gz: 12e384141ba413a86cf131f66f99a682135fcafa05ed632dc0a6f8da9161d21d264b9a4837fff394b90ebe55c3ac12b1369c9abcc34d3ed8e1731d68f4c77933
+  data.tar.gz: 09655674305099e9165adf04e29387582b98656b95db01c8bcba177cb5b6f56dec37c004ffc859919503bd68e7b71f87853d20caae308e47ea6e82c037a2a8e4

data/.rspec

@@ -0,0 +1,3 @@
+--color
+--require spec_helper
+--format documentation

data/Gemfile

@@ -1,4 +1,5 @@
 source 'https://rubygems.org'
 
-# Specify your gem's dependencies in externallink.gemspec
 gemspec
+
+gem 'pry'

data/README.md

@@ -1,6 +1,6 @@
 # Externallink
 
-TODO: Write a gem description
+Helper to detect external urls.
 
 ## Installation
 
@@ -20,11 +20,27 @@ Or install it yourself as:
 
 ## Usage
 
-TODO: Write usage instructions here
+This gem works out of the box for Rails applications and provides the following helpers.
+
+### `external_url?`
+
+Checks if the given URL is external or not.
+Example (when the app domain is example.com):
+
+```ruby
+external_url?("http://www.google.com") # => true
+external_url?("/foo") # => false
+external_url?("http://example.com/foo") # => false
+```
+
+### `internal_url?`
+
+The opposite behavior of `external_url?`
+
 
 ## Contributing
 
-1. Fork it ( https://github.com/[my-github-username]/externallink/fork )
+1. Fork it ( https://github.com/xarsh/externallink/fork )
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)

data/lib/externallink.rb

@@ -1,3 +1,7 @@
-require 'externallink/railtie' if defined?(Rails)
-require "externallink/version"
-require "URI"
+require 'uri'
+
+%w(version view_helpers).each do |m|
+  require_relative "externallink/#{m}"
+end
+
+require_relative 'externallink/railtie' if defined?(Rails)

data/lib/externallink/version.rb

@@ -1,3 +1,3 @@
 module Externallink
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/externallink/view_helpers.rb

@@ -1,11 +1,12 @@
 module Externallink
   module ViewHelpers
     def external_url?(url)
-      request.host != URI(url).host
+      !internal_url?(url)
     end
 
     def internal_url?(url)
-      request.host == URI(url).host
+      url_host = URI(url).host
+      url_host.nil? || request.host == url_host
     end
   end
 end

data/spec/lib/externallink/view_helpers_spec.rb

@@ -0,0 +1,41 @@
+describe Externallink::ViewHelpers do
+  subject(:helpers) { Class.new { extend Externallink::ViewHelpers } }
+
+  before(:each) do
+    allow(helpers).to receive(:request).and_return(FakeRequest.new)
+  end
+
+  describe '#internal_url?' do
+    it 'should detect:key => "value",  external URLs' do
+      expect(helpers.internal_url?('http://www.google.com')).to eq(false)
+    end
+
+    it 'should ignore protocol' do
+      expect(helpers.internal_url?('https://google.com')).to eq(false)
+    end
+
+    it 'should detect path only URLs as internal' do
+      expect(helpers.internal_url?('/foo')).to eq(true)
+    end
+
+    it 'should detect internal URLs with domain' do
+      expect(helpers.internal_url?('http://example.com')).to eq(true)
+    end
+
+    it 'should ignore path' do
+      expect(helpers.internal_url?('https://example.com/foo')).to eq(true)
+    end
+  end
+
+  describe '#external_url?' do
+    it 'should have the opposite behavior of external_url?' do
+      %w(http://wwww.google.com https://google.com).each do |url|
+        expect(helpers.external_url?(url)).to eq(true)
+      end
+
+      %w(/foo http://example.com https://example.com/foo).each do |url|
+        expect(helpers.external_url?(url)).to eq(false)
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,15 @@
+$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
+
+require 'externallink'
+require 'pry'
+
+Dir[File.expand_path('../support/**/*.rb', __FILE__)].each do |s|
+  require s
+end
+
+RSpec.configure do |config|
+  config.expect_with :rspec do |c|
+    c.include_chain_clauses_in_custom_matcher_descriptions = true
+    c.syntax = :expect
+  end
+end

data/spec/support/fake_request.rb

@@ -0,0 +1,5 @@
+class FakeRequest
+  def host
+    "example.com"
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: externallink
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Takao Naito
@@ -46,6 +46,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -55,6 +56,9 @@ files:
 - lib/externallink/railtie.rb
 - lib/externallink/version.rb
 - lib/externallink/view_helpers.rb
+- spec/lib/externallink/view_helpers_spec.rb
+- spec/spec_helper.rb
+- spec/support/fake_request.rb
 homepage: https://github.com/xarsh/externallink
 licenses:
 - MIT
@@ -79,5 +83,8 @@ rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Helper to detect external urls.
-test_files: []
+test_files:
+- spec/lib/externallink/view_helpers_spec.rb
+- spec/spec_helper.rb
+- spec/support/fake_request.rb
 has_rdoc: