external_services 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 92c1be5018af4ae557172d9356067a060ed1a5815f776ee0b88c8267cbde8c25
-  data.tar.gz: 80c51c26e32976717e96c114260a165914fada0b4a4106aaf1835fe20798988d
+  metadata.gz: ee131a3f609b2159c2b1b585699b53b44b52dc85ff9f5ce110b1292a723fba14
+  data.tar.gz: 7c87a38851dcfc2e0d99e8a42375a70328e8b2c9e47734c23607d3150b2e1dec
 SHA512:
-  metadata.gz: 1f908bc5a978f9db391ec8dc89dc9fd3164a945204c91f1f83db0876381190646df3e3b9b582d8631c1bd63f2bea958df76cb1e61cf813c9a9b32260d37cfa1a
-  data.tar.gz: 707d673a53707fad53ea4e683a22f4d2e674f2a442518b281c20f8fd4a5f28f481502e2778f8a402c0c02246c4fbea837f4f2ebc1cfab3897f80464c975eb1e3
+  metadata.gz: f2871bce5fa4c7843eede64f0698b4134bb43025b9358b6ed813cedbd837c87cc9cbb12840409512028b4c79b175f3c163de523eece3307b62944e5d2f0ee572
+  data.tar.gz: f2918bb0ad232e953ccbd49fd16c613ec2b8903696193d97759c64cdc1d2424a76fec34b721362db4c19cc89643c8f637e4429ad6f212b5b83db38be2467c317

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    external_services (0.4.0)
+    external_services (0.4.1)
       faraday (>= 0.9)
       faraday_middleware (>= 0.10)
       rails (>= 4.2.5, < 6.0)
@@ -91,7 +91,7 @@ GEM
     json (2.1.0)
     launchy (2.4.3)
       addressable (~> 2.3)
-    loofah (2.2.2)
+    loofah (2.2.3)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
     mail (2.7.1)
@@ -101,15 +101,15 @@ GEM
     method_source (0.9.0)
     mimemagic (0.3.2)
     mini_mime (1.0.1)
-    mini_portile2 (2.3.0)
+    mini_portile2 (2.4.0)
     minitest (5.11.3)
     multi_json (1.13.1)
     multipart-post (2.0.0)
     net-http-persistent (2.9.4)
     net-http-pipeline (1.0.1)
     nio4r (2.3.1)
-    nokogiri (1.8.5)
-      mini_portile2 (~> 2.3.0)
+    nokogiri (1.9.1)
+      mini_portile2 (~> 2.4.0)
     overcommit (0.46.0)
       childprocess (~> 0.6, >= 0.6.3)
       iniparse (~> 1.4)
@@ -125,7 +125,7 @@ GEM
     pusher-client (0.6.2)
       json
       websocket (~> 1.0)
-    rack (2.0.5)
+    rack (2.0.6)
     rack-test (1.1.0)
       rack (>= 1.0, < 3)
     rails (5.2.1)
@@ -225,4 +225,4 @@ DEPENDENCIES
   travis (~> 1.8, >= 1.8.2)
 
 BUNDLED WITH
-   1.16.1
+   1.16.2

data/app/models/concerns/external_services/action.rb

@@ -5,7 +5,7 @@ module ExternalServices
     QUEUE_PREFIX = 'external_services'
 
     included do
-      scope :processed, -> { where.not(processed_at: nil) }
+      scope :processed,   -> { where.not(processed_at: nil) }
       scope :unprocessed, -> { where(processed_at: nil) }
 
       after_commit :kick_active_job

data/app/models/external_services/api_action.rb

@@ -2,6 +2,8 @@ module ExternalServices
   class ApiAction < ::ActiveRecord::Base
     include ExternalServices::Action
 
+    MAX_ACTION_AGE = ENV.fetch('EXTERNAL_SERVICES_MAX_ACTION_AGE') { '90' }.to_i.days
+
     attr_accessor :async
 
     self.table_name = :external_services_api_actions
@@ -14,7 +16,6 @@ module ExternalServices
     serialize :data,    JSON
     serialize :options, JSON
 
-    scope :unprocessed, -> { where(processed_at: nil) }
     scope :to_create, ->(obj) { where(initiator: obj, method: :post) }
 
     before_validation :assign_queue
@@ -22,6 +23,10 @@ module ExternalServices
 
     before_create :calculate_signature
 
+    def self.delete_old_processed
+      processed.where(arel_table[:created_at].lt(MAX_ACTION_AGE.ago)).delete_all
+    end
+
     def initiator_class
       # Need to use initiator object for STI in polymorphic.. But still will be bugs with deleted STI object and
       # non-STI inheritance

data/lib/external_services/api.rb

@@ -13,6 +13,12 @@ module ExternalServices
       def message
         @response.inspect
       end
+
+      alias :to_s :message
+
+      def inspect
+        "#{self.class}: #{to_s}"
+      end
     end
 
     def api_url

data/lib/external_services/version.rb

@@ -1,3 +1,3 @@
 module ExternalServices
-  VERSION = '0.4.0'.freeze
+  VERSION = '0.4.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: external_services
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Sergey Gnuskov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-19 00:00:00.000000000 Z
+date: 2018-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -120,7 +120,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: Gem helps syncronizing objects to different external services like Gitlab,