external_services 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: acc11b47be37233834ecc0b4375083624fa4ac05af6161a4bf8e398257651597
-  data.tar.gz: becf953aa944cec03b35cb6d6a6f5f99f3f89f6c06a29da8afce0b1cd88329a5
+  metadata.gz: 3bb6cfd9b9015c02de0f4a4cbde0c8e998370079bbcea2c76dbaeb006c3c19d6
+  data.tar.gz: c6a2719336d34b5a5731bcba73529e40547c725a1aaa236dde2b226aa14d4938
 SHA512:
-  metadata.gz: 438dccdde0f0f0b45f031317c4abc9da31c31e5409cc42b8a803dde5b8ad90ac3a8a0ac150ab9ed227651ebadfe5ac7fc8d6e250c26ab03c1a53960074bd1abe
-  data.tar.gz: d7331871933b73473b6288cbf24ab4a5adf29139a55f5631f06c590043dd413362bb242c5c7219e98bf34ce65c4737d5eaf95266eac255bda4d143db81ffcce8
+  metadata.gz: 0efa87a106b4bba92f953a4ce5e8416885892cc7e16f035bb688e4e736470548fdb71ffa567a51034e5ea885cac387fac70af6a35396537d8c151940ae70a4bf
+  data.tar.gz: d118e1daf478352dde4a919f98c3fe3869ac70223ef888451946a330729ec3066a40928f9d3bdbc3ca935466b9ad0968ed9d71a8f8f8c2f84464e5edd0369934

data/.rubocop.yml

@@ -2,6 +2,7 @@ AllCops:
   TargetRubyVersion: 2.2
   Exclude:
   - 'lib/generators/templates/**/*'
+  - 'spec/dummy/**/*'
 
 Metrics/LineLength:
   Max: 140

data/Gemfile

@@ -3,13 +3,13 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in external_services.gemspec
 gemspec
 
-gem 'sqlite3'
 gem 'bundler', '~> 1.12'
 gem 'rake', '~> 10.0'
+gem 'sqlite3'
 gem 'travis', '~> 1.8', '>= 1.8.2'
 
-gem 'rubocop', '~> 0.42', require: false
 gem 'overcommit'
+gem 'rubocop', '~> 0.48', require: false
 
 gem 'pry-rails'
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    external_services (0.2.3)
+    external_services (0.2.4)
       faraday (>= 0.9)
       faraday_middleware (>= 0.10)
       rails (>= 4.2.5, < 6.0)
@@ -9,54 +9,55 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actioncable (5.0.0)
-      actionpack (= 5.0.0)
-      nio4r (~> 1.2)
+    actioncable (5.1.5)
+      actionpack (= 5.1.5)
+      nio4r (~> 2.0)
       websocket-driver (~> 0.6.1)
-    actionmailer (5.0.0)
-      actionpack (= 5.0.0)
-      actionview (= 5.0.0)
-      activejob (= 5.0.0)
+    actionmailer (5.1.5)
+      actionpack (= 5.1.5)
+      actionview (= 5.1.5)
+      activejob (= 5.1.5)
       mail (~> 2.5, >= 2.5.4)
       rails-dom-testing (~> 2.0)
-    actionpack (5.0.0)
-      actionview (= 5.0.0)
-      activesupport (= 5.0.0)
+    actionpack (5.1.5)
+      actionview (= 5.1.5)
+      activesupport (= 5.1.5)
       rack (~> 2.0)
-      rack-test (~> 0.6.3)
+      rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.0.0)
-      activesupport (= 5.0.0)
+    actionview (5.1.5)
+      activesupport (= 5.1.5)
       builder (~> 3.1)
-      erubis (~> 2.7.0)
+      erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    activejob (5.0.0)
-      activesupport (= 5.0.0)
+      rails-html-sanitizer (~> 1.0, >= 1.0.3)
+    activejob (5.1.5)
+      activesupport (= 5.1.5)
       globalid (>= 0.3.6)
-    activemodel (5.0.0)
-      activesupport (= 5.0.0)
-    activerecord (5.0.0)
-      activemodel (= 5.0.0)
-      activesupport (= 5.0.0)
-      arel (~> 7.0)
-    activesupport (5.0.0)
+    activemodel (5.1.5)
+      activesupport (= 5.1.5)
+    activerecord (5.1.5)
+      activemodel (= 5.1.5)
+      activesupport (= 5.1.5)
+      arel (~> 8.0)
+    activesupport (5.1.5)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (~> 0.7)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
     addressable (2.4.0)
-    arel (7.1.4)
-    ast (2.3.0)
+    arel (8.0.0)
+    ast (2.4.0)
     backports (3.6.8)
-    builder (3.2.2)
+    builder (3.2.3)
     childprocess (0.8.0)
       ffi (~> 1.0, >= 1.0.11)
     coderay (1.1.1)
-    concurrent-ruby (1.0.2)
+    concurrent-ruby (1.0.5)
+    crass (1.0.3)
     diff-lcs (1.2.5)
-    erubis (2.7.0)
+    erubi (1.7.0)
     ethon (0.9.0)
       ffi (>= 1.3.0)
     factory_girl (4.7.0)
@@ -79,33 +80,34 @@ GEM
     globalid (0.4.1)
       activesupport (>= 4.2.0)
     highline (1.7.8)
-    i18n (0.7.0)
+    i18n (0.9.5)
+      concurrent-ruby (~> 1.0)
     iniparse (1.4.4)
     json (2.0.2)
     launchy (2.4.3)
       addressable (~> 2.3)
-    loofah (2.0.3)
+    loofah (2.2.0)
+      crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
     mail (2.7.0)
       mini_mime (>= 0.1.1)
     method_source (0.8.2)
     mini_mime (1.0.0)
-    mini_portile2 (2.1.0)
-    minitest (5.9.0)
+    mini_portile2 (2.3.0)
+    minitest (5.11.3)
     multi_json (1.12.1)
     multipart-post (2.0.0)
     net-http-persistent (2.9.4)
     net-http-pipeline (1.0.1)
-    nio4r (1.2.1)
-    nokogiri (1.6.8)
-      mini_portile2 (~> 2.1.0)
-      pkg-config (~> 1.1.7)
+    nio4r (2.2.0)
+    nokogiri (1.8.2)
+      mini_portile2 (~> 2.3.0)
     overcommit (0.41.0)
       childprocess (~> 0.6, >= 0.6.3)
       iniparse (~> 1.4)
-    parser (2.3.1.2)
-      ast (~> 2.2)
-    pkg-config (1.1.7)
+    parallel (1.12.1)
+    parser (2.5.0.2)
+      ast (~> 2.4.0)
     powerpack (0.1.1)
     pry (0.10.4)
       coderay (~> 1.1.0)
@@ -116,33 +118,33 @@ GEM
     pusher-client (0.6.2)
       json
       websocket (~> 1.0)
-    rack (2.0.1)
-    rack-test (0.6.3)
-      rack (>= 1.0)
-    rails (5.0.0)
-      actioncable (= 5.0.0)
-      actionmailer (= 5.0.0)
-      actionpack (= 5.0.0)
-      actionview (= 5.0.0)
-      activejob (= 5.0.0)
-      activemodel (= 5.0.0)
-      activerecord (= 5.0.0)
-      activesupport (= 5.0.0)
-      bundler (>= 1.3.0, < 2.0)
-      railties (= 5.0.0)
+    rack (2.0.4)
+    rack-test (0.8.2)
+      rack (>= 1.0, < 3)
+    rails (5.1.5)
+      actioncable (= 5.1.5)
+      actionmailer (= 5.1.5)
+      actionpack (= 5.1.5)
+      actionview (= 5.1.5)
+      activejob (= 5.1.5)
+      activemodel (= 5.1.5)
+      activerecord (= 5.1.5)
+      activesupport (= 5.1.5)
+      bundler (>= 1.3.0)
+      railties (= 5.1.5)
       sprockets-rails (>= 2.0.0)
-    rails-dom-testing (2.0.1)
-      activesupport (>= 4.2.0, < 6.0)
-      nokogiri (~> 1.6.0)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
     rails-html-sanitizer (1.0.3)
       loofah (~> 2.0)
-    railties (5.0.0)
-      actionpack (= 5.0.0)
-      activesupport (= 5.0.0)
+    railties (5.1.5)
+      actionpack (= 5.1.5)
+      activesupport (= 5.1.5)
       method_source
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
-    rainbow (2.1.0)
+    rainbow (3.0.0)
     rake (10.5.0)
     rspec-core (3.5.2)
       rspec-support (~> 3.5.0)
@@ -161,13 +163,14 @@ GEM
       rspec-mocks (~> 3.5.0)
       rspec-support (~> 3.5.0)
     rspec-support (3.5.0)
-    rubocop (0.42.0)
-      parser (>= 2.3.1.1, < 3.0)
+    rubocop (0.52.1)
+      parallel (~> 1.10)
+      parser (>= 2.4.0.2, < 3.0)
       powerpack (~> 0.1)
-      rainbow (>= 1.99.1, < 3.0)
+      rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.8.1)
+    ruby-progressbar (1.9.0)
     slop (3.6.0)
     sprockets (3.7.1)
       concurrent-ruby (~> 1.0)
@@ -177,8 +180,8 @@ GEM
       activesupport (>= 4.0)
       sprockets (>= 3.0.0)
     sqlite3 (1.3.11)
-    thor (0.19.1)
-    thread_safe (0.3.5)
+    thor (0.20.0)
+    thread_safe (0.3.6)
     travis (1.8.2)
       backports
       faraday (~> 0.9)
@@ -190,9 +193,9 @@ GEM
       typhoeus (~> 0.6, >= 0.6.8)
     typhoeus (0.8.0)
       ethon (>= 0.8.0)
-    tzinfo (1.2.2)
+    tzinfo (1.2.5)
       thread_safe (~> 0.1)
-    unicode-display_width (1.1.0)
+    unicode-display_width (1.3.0)
     websocket (1.2.3)
     websocket-driver (0.6.5)
       websocket-extensions (>= 0.1.0)
@@ -209,7 +212,7 @@ DEPENDENCIES
   pry-rails
   rake (~> 10.0)
   rspec-rails
-  rubocop (~> 0.42)
+  rubocop (~> 0.48)
   sqlite3
   travis (~> 1.8, >= 1.8.2)
 

data/app/models/external_services/api_action.rb

@@ -66,8 +66,7 @@ module ExternalServices
       self.data = nil if method.to_sym == :delete # DELETE has no body
     end
 
-    def calculate_signature
-    end
+    def calculate_signature; end
 
     def path_format_correctness
       errors.add(:path, :invalid) if path =~ %r{//}

data/external_services.gemspec

@@ -1,4 +1,4 @@
-# coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'external_services/version'

data/lib/external_services/active_record.rb

@@ -88,7 +88,7 @@ module ExternalServices
           end
         end
 
-        # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/PerceivedComplexity
         def define_external_service_callbacks(name, options = {})
           service_assoc = :"#{name}_service"
           only_api_actions = (options[:only_api_actions] == true)
@@ -183,7 +183,6 @@ module ExternalServices
         def define_external_service_helper_methods(name, _options = {})
           ## subject class methods
           helpers_class_module = Module.new do
-
             define_method :"with_#{name}_api_for" do |synced: [], for_syncing: [], &b|
               (synced + for_syncing).map(&:class).uniq.each do |k|
                 return true if k.send("#{name}_api_disabled")

data/lib/external_services/version.rb

@@ -1,3 +1,3 @@
 module ExternalServices
-  VERSION = '0.2.3'.freeze
+  VERSION = '0.2.4'.freeze
 end

data/lib/rspec/helpers.rb

@@ -20,7 +20,7 @@ module ExternalServices
 
         def describe_external_service_api(object:, api_name:, **kwargs, &blk)
           action_class = kwargs[:action_class] || "ExternalServices::ApiActions::#{api_name.to_s.camelize}".constantize
-          methods = [:create, :update, :destroy]
+          methods = %i[create update destroy]
           methods -= [kwargs[:except]].flatten if kwargs[:except]
           methods &= [kwargs[:only]].flatten if kwargs[:only]
 
@@ -68,9 +68,7 @@ module ExternalServices
                 @api_object.send("#{@id_key}=", SecureRandom.hex)
                 @api_object.save
 
-                if @api_object.respond_to?(:descendants)
-                  @api_object.reload.descendants.each(&:delete)
-                end
+                @api_object.reload.descendants.each(&:delete) if @api_object.respond_to?(:descendants)
                 @api_object.destroy
                 expect_api_action_on_destroy(@api_object)
               end
@@ -117,7 +115,7 @@ module ExternalServices
         data = params.delete(:data) || {}
 
         actions = @action_class.where(params).select do |a|
-          data.select { |k, v| a.data[k.to_s] != v }.empty?
+          data.reject { |k, v| a.data[k.to_s] == v }.empty?
         end
 
         if count

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: external_services
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Sergey Gnuskov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-11-13 00:00:00.000000000 Z
+date: 2018-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -118,7 +118,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.2
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Gem helps syncronizing objects to different external services like Gitlab,