external_services 0.1.4 → 0.1.5

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZTMzNjZiMzVmOWQ1ZTkyODNlM2VmYjIxZTEyNzMzMTI3Y2Q1ODJkNg==
+    YWNlM2UzYTQxZGE4ZmNiMDVmMTA3ZTc3ZjI3OTc1MjE5MWViYmNiYg==
   data.tar.gz: !binary |-
-    ODY1OGRhMDUxM2Q1M2U0ZjNmMGQ4YzJlZDEyODY5ZGM0MDY0M2Y4NA==
+    Mjg2YmE2MmIzZDcwYTdmYTY3OGY5NWE1NmZkY2QyM2RkMmFkOWE5OA==
 SHA512:
   metadata.gz: !binary |-
-    ZjE5NDU2YTBkMjNhMGFiZjkwZDY1M2E3ZDc1ZDFlMzk2OTc4MjQ5YzA5ZGRi
-    Njc0M2JmN2RlOTM3ZTc2NjA2NjVmMmQ1OTZkMDQyN2I2ODM0NjFjZjZlZjU3
-    M2Y3ZmFiNTMxYjUzMjc3ZDQ4YjhhNjhhOTNmNDViNzk4OGM2NTE=
+    NTMzOGQzZTdmMmZjZDg0ODY1NzM3MmVlNTliM2Y4ZDk1ZGI5ZDI1ZGM0NDlh
+    MGM1NGQ3MmRjYTgwN2RhMmYxM2QwNDVlZDdjZTdiZjhlNTFjNzhhOGQ0ZjNl
+    NGIxMTdjZmEzYjdhZTA0NTg3MzhkOGZlODMwZmVmZTI3MjI1ZDM=
   data.tar.gz: !binary |-
-    NmVkZDYwMDY3NDRhYjYyOGE2MDU2NDA4YzYxOTRlMDRjMzRkYmQ5YTI1ODEw
-    ZDY4N2YyNTI4YWVlN2JhYTNkNzM2YzlmOGM4OWEyNzlmMzhlNGJiMTUwZDJi
-    ZmNjODM0YzU4OGI4ZjQ0YjlmYTgzZDUxODRkYzQ3ZjYwNWQxZDk=
+    ZmNmNDE2MTIzMzQ2ZjYzNWUyMTVmODdkMzU0ZGE0OWUyZDFlOTI4MWM3YzE1
+    ZjhjNDQwY2ZmNmQ2YzQ4MzMyYzVmZGQzNTY3NmE5YzcwOWFiYzI4MmY3OThi
+    MjA4YmQyZTMyYTM1YWM1Nzc4NjM5ZGQ3Mjk5YzUyYTllZjJmOTc=

data/Rakefile

@@ -14,7 +14,7 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-APP_RAKEFILE = File.expand_path("../spec/dummy/Rakefile", __FILE__)
+APP_RAKEFILE = File.expand_path('../spec/dummy/Rakefile', __FILE__)
 
 load 'rails/tasks/engine.rake'
 

data/config/locales/en.yml

@@ -0,0 +1,5 @@
+en:
+  activerecord:
+    errors:
+      messages:
+        external_services_not_synced: "Not all external services are synced"

data/lib/external_services/active_record.rb

@@ -88,7 +88,7 @@ module ExternalServices
           end
         end
 
-        # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+        # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
         def define_external_service_callbacks(name, options = {})
           service_assoc = :"#{name}_service"
           only_api_actions = (options[:only_api_actions] == true)
@@ -101,6 +101,9 @@ module ExternalServices
                 before_save do
                   public_send(:"build_#{service_assoc}") if public_send(service_assoc).blank?
                 end
+
+                before_update  :halt_on_external_services_unsynced
+                before_destroy :halt_on_external_services_unsynced
               end
 
               after_save    :"#{name}_on_create", if: :id_changed?
@@ -130,8 +133,19 @@ module ExternalServices
               public_send(service_assoc).on_subject_revive(self) unless only_api_actions
             end
             protected :"#{name}_on_revive"
+
+            protected def halt_on_external_services_unsynced
+              unless external_services_synced?
+                errors.add :base, :external_services_not_synced
+                if ::ActiveRecord::VERSION::MAJOR < 5
+                  return false
+                else
+                  throw :abort
+                end
+              end
+            end
           end
-          # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
+          # rubocop:enable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 
           include callbacks_module
         end

data/lib/external_services/api.rb

@@ -60,7 +60,7 @@ module ExternalServices
       !connection
     end
 
-    def fake_response_body(method, path, params = {})
+    def fake_response_body(method, _path, _params = {})
       (method == :post ? { 'id' => SecureRandom.hex } : {})
     end
 

data/lib/external_services/version.rb

@@ -1,3 +1,3 @@
 module ExternalServices
-  VERSION = '0.1.4'.freeze
+  VERSION = '0.1.5'.freeze
 end

data/lib/generators/service_generator.rb

@@ -7,12 +7,11 @@ module ExternalServices
     class ServiceGenerator < ::Rails::Generators::NamedBase
       source_root File.expand_path('../templates/services', __FILE__)
 
-
       class_option(
         :only_api_actions,
         type: :boolean,
         default: false,
-        desc: "Do not generate service model class"
+        desc: 'Do not generate service model class'
       )
 
       desc 'Generates specified model and API classes.'

data/lib/rspec/configuration.rb

@@ -5,14 +5,14 @@ module ExternalServices
 
       def add_external_service(name)
         Disabler.add_external_service name
-        
+
         mod = Module.new do
           define_method :"describe_#{name}_api" do |object:, **kwargs, &blk|
             describe_external_service_api(object: object, api_name: name, **kwargs, &blk)
           end
         end
 
-        self.extend mod
+        extend mod
       end
     end
   end

data/lib/rspec/helpers.rb

@@ -65,6 +65,9 @@ module ExternalServices
 
             if :destroy.in? methods
               it 'creates action on delete' do
+                @api_object.send("#{@id_key}=", SecureRandom.hex)
+                @api_object.save
+
                 if @api_object.respond_to?(:descendants)
                   @api_object.reload.descendants.each(&:delete)
                 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: external_services
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Sergey Gnuskov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-08-03 00:00:00.000000000 Z
+date: 2016-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -78,6 +78,7 @@ files:
 - app/models/external_services/api_action.rb
 - app/models/external_services/service.rb
 - bin/rails
+- config/locales/en.yml
 - external_services.gemspec
 - lib/external_services.rb
 - lib/external_services/active_record.rb