experimental 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4c3ca7d05e6f83ec23e057defc0da8e4d8b94b6f
-  data.tar.gz: 19dd91453b0154b0d8cbc4b7c03e02860ba796e4
+  metadata.gz: 7663b9ae9da92b4a90b126980a4980dacb976431
+  data.tar.gz: 626412b747d825a405d5b0dacc93c30b0d24ac86
 SHA512:
-  metadata.gz: 8f460e8ef869e751e103a936cf99c921293e700dd15387391ce4b84ed9207ecf49c472df59a02e29d38b471afa77ce708ff07d20722165585665e6a4d3dd6b79
-  data.tar.gz: 24eeb5bec5c23fcbb3354804368d21fbad288b278942c82b191ead834b2e61b59bf5116443d8e03d5416a86021c2a38dcad013a6a7b2ab45b8fcc81c71b8833a
+  metadata.gz: 26702a568881b39baadf91a542f4ae76babc6ad41555c356b56953d588b61ae33627165a444c5a3ed1ae0c4686b4189d2b15139230d2a1f9542f30d98d86fcda
+  data.tar.gz: 71f434476e6ec9da639f358b924159c1995c46bd65835a2a8bfa57bdac8178aa275e8f418259c6d9423e869f69b1a70782102a8bcdcdd62b786d4139e383c89d

data/README.markdown

@@ -1,4 +1,4 @@
-# Experimental [![Build Status](https://travis-ci.org/howaboutwe/experimental.png?branch=master)](https://travis-ci.org/howaboutwe/experimental)
+# Experimental [![Build Status](https://travis-ci.org/howaboutwe/experimental.png?branch=master)](https://travis-ci.org/howaboutwe/experimental) [![Code Climate](https://codeclimate.com/github/howaboutwe/experimental.png)](https://codeclimate.com/github/howaboutwe/experimental)
 
 Experimental is an Split testing framework for Rails.  
 It was written with a few goals in mind:

data/lib/experimental/experiment.rb

@@ -18,8 +18,12 @@ module Experimental
       where(:removed_at => nil)
     end
 
+    def self.unstarted
+      where(start_date: nil)
+    end
+
     def self.in_progress
-      where('removed_at is null and end_date is null').
+      where('start_date is not null and end_date is null and removed_at is null').
         order('start_date desc').
         order(:name)
     end

data/lib/experimental/loader.rb

@@ -12,32 +12,55 @@ module Experimental
       logger.info "Synchronizing experiments..."
 
       Experimental::Experiment.transaction do
-        active = Experimental.experiment_data.map do |name, attributes|
-          experiment = Experimental::Experiment.where(name: name).first_or_initialize
-
-          unstarted = attributes.delete('unstarted')
-          defaults = {'num_buckets' => nil, 'notes' => nil, 'population' => nil}
-          experiment.assign_attributes(defaults.merge(attributes))
-          if unstarted
-            experiment.start_date = nil
-          else
-            experiment.start_date ||= Time.current
-          end
-
-          logger.info "  * #{experiment.id ? 'updating' : 'creating'} #{name}"
-          experiment.tap(&:save!)
-        end
+        all_experiments = Experimental::Experiment.in_code
+        active_experiments = create_or_update_active_experiments
 
-        scope = Experimental::Experiment.in_code
-        scope = scope.where('id NOT IN (?)', active.map(&:id)) unless active.empty?
-        scope.find_each do |experiment|
-          next if experiment.admin?
-          logger.info "  * removing #{experiment.name}"
-          experiment.remove
+        if active_experiments.present?
+          active_ids = active_experiments.map(&:id)
+          remove(all_experiments.where('id NOT IN (?)', active_ids))
+        else
+          remove(all_experiments)
         end
       end
 
       logger.info "Done."
     end
+
+    private
+
+    def create_or_update_active_experiments
+      Experimental.experiment_data.map do |name, attributes|
+        experiment = Experimental::Experiment.where(name: name).
+          first_or_initialize
+
+        reset_attributes(experiment, attributes)
+
+        logger.info "  * #{experiment.id ? 'updating' : 'creating'} #{name}"
+
+        experiment.tap(&:save!)
+      end
+    end
+
+    def reset_attributes(experiment, attributes)
+      set_new_start_date(experiment, attributes)
+      defaults = {'num_buckets' => nil, 'notes' => nil, 'population' => nil}
+      experiment.assign_attributes(defaults.merge(attributes))
+    end
+
+    def remove(experiments)
+      experiments.find_each do |experiment|
+        next if experiment.admin?
+        logger.info "  * removing #{experiment.name}"
+        experiment.remove
+      end
+    end
+
+    def set_new_start_date(experiment, attributes)
+      if (unstarted = attributes.delete('unstarted'))
+        experiment.start_date = nil
+      else
+        experiment.start_date ||= Time.current
+      end
+    end
   end
 end

data/lib/experimental/version.rb

@@ -1,5 +1,5 @@
 module Experimental
-  VERSION = [0, 5, 0]
+  VERSION = [0, 6, 0]
 
   class << VERSION
     include Comparable

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: experimental
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - HowAboutWe.com
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-18 00:00:00.000000000 Z
+date: 2015-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -100,7 +100,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Adds support for database-backed AB tests in Rails apps