exercism-config 0.131.0 → 0.132.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 022a04eecafa535e9bdc8c6b9318ec6d6cfbffc4a52414a3865ef2f60e924497
-  data.tar.gz: cf41e3c8c92f94299eb4b8fd421883548c323a059127901a2b5ef6aacc8e72f2
+  metadata.gz: a9e8983e2c22effab8a09ab797692425b22617a659a2120dea4ca17d0c4c539e
+  data.tar.gz: 8311ced800943c7606457584c44a5b2d007425aff04bdf7de77d840944a5f0d6
 SHA512:
-  metadata.gz: aa6b5336b973c833c469b574f211c1b662b9ab45bc4cdd0318a61fae74c8c4008580660817f5272828d851df10dec6d63abc785817220676d2f17755952e8664
-  data.tar.gz: c98758723a9a86d477a7110248c4f8d20bd8a0a5d891f64a75dfe9648d1d99962232eac13efb8cda21a689d725b2d903907feb0fe01ab257c8449fb9e928ca9f
+  metadata.gz: 061d7ac2ae9620178592a652618ff06d6bb1f5fd02cfd0ebce062a521f72c970d39c91ee9ba3631ac5a78293920015e69f6160584a6225b458ecefa2a457aab9
+  data.tar.gz: fbea37c2ef414c36f3dee867851868c30501f2afcb3a392c182e9147505b90015cb288f99fe0e255ffbd9dc3cf793ef0c38e721442e915e15a4730c34f214b74

data/exercism_config.gemspec

@@ -43,6 +43,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'aws-sdk-ecr'
   spec.add_development_dependency 'aws-sdk-s3'
   spec.add_development_dependency 'aws-sdk-sesv2'
+  spec.add_development_dependency 'connection_pool'
   spec.add_development_dependency 'discourse_api'
   spec.add_development_dependency 'opensearch-ruby', '2.1.0'
   spec.add_development_dependency 'redis', '~> 5.1'

data/lib/exercism/redis_pool.rb

@@ -0,0 +1,54 @@
+module Exercism
+  # A registry of pooled Redis clients, keyed by name.
+  #
+  # Clients used to be built per call, which turned out to be expensive rather
+  # than merely wasteful. Redis::Cluster is eager: RedisClient::Cluster#initialize
+  # builds its router inline, and the router does topology discovery and opens
+  # node connections there and then. Because nothing held a reference to the
+  # client afterwards, every command paid a connect plus a full slot-map fetch
+  # and then threw the connection away - putting a handshake on the critical
+  # path of every tooling job state transition, and (because the orchestrator
+  # does the same on each idle poll) accounting for ~96% of our ElastiCache
+  # ECPU bill.
+  #
+  # A single shared client would fix the churn, but Redis serialises every
+  # command through an internal Monitor, so sharing one across the
+  # orchestrator's and Sidekiq's threads would trade connection cost for
+  # contention. Hence a pool.
+  module RedisPool
+    DEFAULT_SIZE = 5
+    DEFAULT_TIMEOUT = 5
+
+    @mutex = Mutex.new
+    @pools = {}
+    @pid = nil
+
+    # Returns the pool for +key+, building it from the block on first use.
+    # The returned object quacks like a Redis client: ConnectionPool::Wrapper
+    # checks a connection out for the duration of each method call.
+    def self.for(key, &)
+      require 'connection_pool'
+
+      @mutex.synchronize do
+        reset_after_fork!
+
+        @pools[key] ||= ConnectionPool::Wrapper.new(size:, timeout: DEFAULT_TIMEOUT, &)
+      end
+    end
+
+    def self.size
+      Integer(ENV.fetch('EXERCISM_REDIS_POOL_SIZE', DEFAULT_SIZE))
+    end
+
+    # A pool must never be shared across a fork - parent and child would write
+    # down each other's sockets - so pools are scoped to the pid and rebuilt
+    # from scratch in the child.
+    def self.reset_after_fork!
+      return if @pid == Process.pid
+
+      @pools = {}
+      @pid = Process.pid
+    end
+    private_class_method :reset_after_fork!
+  end
+end

data/lib/exercism.rb

@@ -13,9 +13,10 @@ module Exercism
     @secrets ||= ExercismConfig::RetrieveSecrets.()
   end
 
-  def self.redis_tooling_client = redis_client(config.tooling_redis_url)
-  def self.redis_git_cache_client = redis_client(config.git_cache_redis_url)
-  def self.redis_cache_client = redis_client(config.cache_redis_url)
+  # Pooled rather than built per call - see Exercism::RedisPool for why.
+  def self.redis_tooling_client = RedisPool.for(:tooling) { redis_client(config.tooling_redis_url) }
+  def self.redis_git_cache_client = RedisPool.for(:git_cache) { redis_client(config.git_cache_redis_url) }
+  def self.redis_cache_client = RedisPool.for(:cache) { redis_client(config.cache_redis_url) }
 
   def self.redis_client(url)
     require 'redis'

data/lib/exercism_config/version.rb

@@ -1,3 +1,3 @@
 module ExercismConfig
-  VERSION = '0.131.0'.freeze
+  VERSION = '0.132.0'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: exercism-config
 version: !ruby/object:Gem::Version
-  version: 0.131.0
+  version: 0.132.0
 platform: ruby
 authors:
 - Jeremy Walker
@@ -191,6 +191,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: connection_pool
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: discourse_api
   requirement: !ruby/object:Gem::Requirement
@@ -293,6 +307,7 @@ files:
 - lib/exercism-config.rb
 - lib/exercism.rb
 - lib/exercism/config.rb
+- lib/exercism/redis_pool.rb
 - lib/exercism/secrets.rb
 - lib/exercism/tooling_job.rb
 - lib/exercism_config/determine_environment.rb