exel 1.5.1 → 1.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d6f13f47962fc1df5ff720757b50fa151d1662f64fd3ce57a4cb3d7feeb8d6fd
-  data.tar.gz: 5d3ff9f75bf80727e7d98f83166267259472ed57a18aaaa860d6210098d6ebeb
+  metadata.gz: 546280a360b5092ca3cca1b0e0ae670560c60fb87e0c143b04405f9a5a3de9f9
+  data.tar.gz: 1b4b4f78ae5797c82f12abdd61057f915d1f06f53e775b4b1f502b06e1bea463
 SHA512:
-  metadata.gz: 22fe9e83f165cd1d5840e18c469d6adaf086ac12eb6c8c134c6224505da20a9ccd2313470560b684ee23ea22dfc828ee1082c2d020418fc6ac7a12fa8bf63767
-  data.tar.gz: 274d1750e588dfb03635cf0a614b11852e590567f6938c30a299b096c5bf01d4270f10f52db927fb35d96da86530274ee0fe188b0cbb779077318c908ec09a0e
+  metadata.gz: 0117f598e372c74606421159b405fdd4aa4fa1be3d2d658741ed4163b8c223cc3f75ce68ab0e67adbd495cd53a72b47b8411cf74135b067f2c430f00a3ff70da
+  data.tar.gz: 7a40ed7071070e4799681b750595c78b07326d72859f3824b9e411d94a782147fc94101b0c9466795270b41126a0ad0bbdb3a137185db7ae0ef825a90f3f5f5d

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    exel (1.5.1)
+    exel (1.5.2)
 
 GEM
   remote: https://rubygems.org/

data/lib/exel/providers/local_file_provider.rb

@@ -6,16 +6,17 @@ module EXEL
     # just works with local files.
     class LocalFileProvider
       def upload(file)
-        "file://#{file.path}"
+        RemoteValue.new(URI("file://#{File.absolute_path(file)}"))
       end
 
-      def download(uri)
-        raise 'URI must begin with "file://"' unless uri.start_with? 'file://'
-        File.open(uri.split('file://').last)
+      def download(remote_value)
+        scheme = remote_value.uri.scheme
+        raise "Unsupported URI scheme '#{scheme}'" unless scheme == 'file'
+        File.open(remote_value.uri.path)
       end
 
-      def self.remote?(uri)
-        uri.to_s =~ %r{file://}
+      def self.remote?(value)
+        value.is_a?(RemoteValue)
       end
     end
   end

data/lib/exel/remote_value.rb

@@ -0,0 +1,11 @@
+class RemoteValue
+  attr_reader :uri
+
+  def initialize(uri)
+    @uri = uri
+  end
+
+  def ==(other)
+    other.class == self.class && other.uri == @uri
+  end
+end

data/lib/exel/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EXEL
-  VERSION = '1.5.1'
+  VERSION = '1.5.2'
 end

data/spec/exel/providers/local_file_provider_spec.rb

@@ -1,28 +1,28 @@
 # frozen_string_literal: true
 
 describe EXEL::Providers::LocalFileProvider do
-  let(:file) { instance_double(File, path: '/path/to/file') }
+  let(:file) { File.open(File.expand_path('../../../fixtures/sample.csv', __FILE__)) }
 
-  describe '#upload' do
-    it 'returns a file:// URI for the file' do
-      expect(subject.upload(file)).to eq('file:///path/to/file')
-    end
-  end
+  it 'can upload/download a file' do
+    remote_value = subject.upload(file)
+    expect(remote_value.uri.path).to eq(file.path)
 
-  describe '#download' do
-    it 'returns the file indicated by the URI' do
-      expect(File).to receive(:open).with('/path/to/file').and_return(file)
-      expect(subject.download('file:///path/to/file')).to eq(file)
-    end
+    restored_file = subject.download(remote_value)
+    expect(restored_file.path).to eq(file.path)
+  end
 
-    it 'doesn`t accept URIs for schemes other than file://' do
-      expect { subject.download('s3://') }.to raise_error 'URI must begin with "file://"'
-    end
+  it 'doesn`t accept URIs for schemes other than file://' do
+    expect { subject.download(RemoteValue.new(URI('s3://bucket/file'))) }.to raise_error "Unsupported URI scheme 's3'"
   end
 
   describe '.remote?' do
-    it 'returns true for file:// URIs' do
-      expect(EXEL::Providers::LocalFileProvider.remote?('file:///path/to/file')).to be_truthy
+    it 'returns true for remote values' do
+      expect(EXEL::Providers::LocalFileProvider.remote?(RemoteValue.new(URI('file:///path/to/file')))).to be_truthy
+    end
+
+    it 'returns false for file:// URIs' do
+      expect(EXEL::Providers::LocalFileProvider.remote?('file:///path/to/file')).to be_falsey
+      expect(EXEL::Providers::LocalFileProvider.remote?(URI('file:///path/to/file'))).to be_falsey
     end
 
     it 'returns false for anything else' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: exel
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 1.5.2
 platform: ruby
 authors:
 - yroo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-23 00:00:00.000000000 Z
+date: 2020-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -193,6 +193,7 @@ files:
 - lib/exel/processors/split_processor.rb
 - lib/exel/providers/local_file_provider.rb
 - lib/exel/providers/threaded_async_provider.rb
+- lib/exel/remote_value.rb
 - lib/exel/sequence_node.rb
 - lib/exel/value.rb
 - lib/exel/version.rb