exel-s3 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8936d6a5957afc15092d755de27ebfdc8f8b5538
-  data.tar.gz: 73473d824eeb3851f0bc58700805abe63bb682d3
+  metadata.gz: a4a51332e89651de73f2713f7cdb409c91290199
+  data.tar.gz: 60e49619e30c0cf1997aff639cf7fa3c81f45011
 SHA512:
-  metadata.gz: 8e8fda44139bedd03056d12abbf883d96e9ca29812754983554699cf397dbd6b629fd51c18d255c30303dc3caa6198b09a28e4f0d9ca4007d10f63877c2c186a
-  data.tar.gz: 4e14a6f528fe780dc68be98ccaae651ad0ebf56e6da467784973d12a98e90b148fb0364d3f6da403f750ac86dbf3e7e38bef2fa8147f47142a7f9746094b4744
+  metadata.gz: fc119e9472e9e3d51f154acd0ad85c4c378fc999aae10fcf356f81856747e65c53c36365605eae46dea82678c66c0b85ecced8b560baa1ceebab6f8516305f5d
+  data.tar.gz: 2ad70a38198db0c9225ec6ebeca69437f13de25625bda08847bf4d3b921f281f1b938ed522b0ca73f2e2907ce64705a916ff09d3aaec4e1f121475d8f04efa23

data/.rubocop.yml

@@ -1,17 +1,18 @@
 require:
-  - rubocop-rspec
   - rubocop/rspec/focused
 
 inherit_from: .rubocop_todo.yml
 
 AllCops:
+  TargetRubyVersion: 2.3
   DisplayStyleGuide: true
+  DisplayCopNames: true
 
 Metrics/LineLength:
   Max: 120
 
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
 Style/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
-
-RSpec/DescribedClass:
-  Enabled: false

data/Gemfile

@@ -2,5 +2,3 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in exel-s3.gemspec
 gemspec
-
-gem 'exel', git: 'https://github.com/47colborne/exel'

data/README.md

@@ -1,5 +1,6 @@
 # EXEL::S3
 
+[![Gem Version](https://badge.fury.io/rb/exel-s3.svg)](https://badge.fury.io/rb/exel-s3)
 [![Build Status](https://snap-ci.com/47colborne/exel-s3/branch/master/build_image)](https://snap-ci.com/47colborne/exel-s3/branch/master)
 
 This gem implements a "remote provider" for [EXEL](https://github.com/47colborne/exel) using Amazon S3. The remote provider is used when an async command is executed and a context shift occurs. Its job is to move the context to a remote storage location when the async call is initiated, and retrieve it before the async block is executed.

data/exel-s3.gemspec

@@ -30,6 +30,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'terminal-notifier', '~> 1'
   spec.add_development_dependency 'terminal-notifier-guard', '~> 1'
   spec.add_development_dependency 'rubocop', '~> 0'
-  spec.add_development_dependency 'rubocop-rspec', '~> 1'
   spec.add_development_dependency 'rubocop-rspec-focused', '~> 0'
 end

data/lib/exel/s3/s3_provider.rb

@@ -19,6 +19,8 @@ module EXEL
         obj.get(response_target: file)
         file.set_encoding(Encoding::UTF_8)
         file
+      rescue Aws::S3::Errors::NoSuchKey => e
+        raise EXEL::Error::JobTermination, "Aws::S3::Errors::NoSuchKey: #{e.message}"
       end
 
       def get_object(filename)

data/lib/exel/s3/version.rb

@@ -1,5 +1,5 @@
 module EXEL
   module S3
-    VERSION = '1.0.0'
+    VERSION = '1.0.1'.freeze
   end
 end

data/spec/exel/s3/s3_provider_spec.rb

@@ -1,14 +1,14 @@
 module EXEL
   module S3
     describe S3Provider do
-      describe '#get_object' do
-        before do
-          EXEL.configure do |config|
-            config.aws = OpenStruct.new
-            config.s3_bucket = 'bucket'
-          end
+      before :all do
+        EXEL.configure do |config|
+          config.aws = OpenStruct.new
+          config.s3_bucket = 'bucket'
         end
+      end
 
+      describe '#get_object' do
         it 'has the correct bucket and file names' do
           file_name = 'abc.txt'
           s3_obj = subject.get_object(file_name)
@@ -33,17 +33,28 @@ module EXEL
       end
 
       describe '#download' do
-        it 'downloads the file from s3' do
-          file = double(:file)
-          s3_object = double(:s3_object)
+        let(:file) { double(:file) }
+        let(:s3_object) { double(:s3_object) }
+
+        before do
+          allow(subject).to receive(:get_object).with('abc.txt').and_return(s3_object)
+          allow(Tempfile).to receive(:new).with('abc.txt', encoding: Encoding::ASCII_8BIT).and_return(file)
+        end
 
-          expect(subject).to receive(:get_object).with('abc.txt').and_return(s3_object)
-          expect(Tempfile).to receive(:new).with('abc.txt', encoding: Encoding::ASCII_8BIT).and_return(file)
-          expect(s3_object).to receive(:get).with(hash_including(response_target: file)).and_return(file)
-          expect(file).to receive(:set_encoding).with(Encoding::UTF_8)
+        it 'downloads the file from s3' do
+          allow(s3_object).to receive(:get).with(hash_including(response_target: file)).and_return(file)
+          allow(file).to receive(:set_encoding).with(Encoding::UTF_8)
 
           expect(subject.download('s3://abc.txt')).to eq(file)
         end
+
+        context 'when s3 object does not exist' do
+          it 'raises an EXEL::Error:JobTermination error' do
+            allow(s3_object).to receive(:get).and_raise(Aws::S3::Errors::NoSuchKey.new(nil, 'key'))
+
+            expect { subject.download('s3://abc.txt') }.to raise_error EXEL::Error::JobTermination
+          end
+        end
       end
 
       describe '.remote?' do

data/spec/spec_helper.rb

@@ -3,3 +3,10 @@ require 'exel'
 Dir[File.expand_path('../../lib/**/*.rb', __FILE__)].each { |f| require f }
 
 EXEL.logger = nil
+
+RSpec.configure do |config|
+  config.filter_run focus: true
+  config.run_all_when_everything_filtered = true
+
+  config.order = 'random'
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: exel-s3
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - yroo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-15 00:00:00.000000000 Z
+date: 2016-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: exel
@@ -164,20 +164,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec-focused
   requirement: !ruby/object:Gem::Requirement