execute_with_rescue_with_airbrake 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a075f476d5e0d9f96a18858757b1f0f967162c8e
-  data.tar.gz: 57fe7504b06259d529e6a56cc4910ac91728ad25
+  metadata.gz: b5d1379bd518fffaf16cac770009ce25a685495d
+  data.tar.gz: d92e9467ea3bd298841841669d1cd00aeb947c52
 SHA512:
-  metadata.gz: da8223cb3c1484790c8d9a883faf00f705d572aef2f74c81886ff18e7914d0c0efeb912b2f42a40bda49684be01ea517c08fc7748a480bcf101c308a8648c5d2
-  data.tar.gz: 204f405743ecb2ae9e20d55b3482429383e0d0d443c1281a802325a96016a8c24f430f20bc3392ceb261b52e9ea63538dc0b24d6a0dba647e965c1fc6d8ee848
+  metadata.gz: e6d1ee7602c638f994973d5bbf475452390725e682223e5f8f4b9d09c5923d85c14d58d08b145c270929a0ccbd22dc6ff30b1a6f3a34d250d0b88c84655814b2
+  data.tar.gz: f4dad93c3d92a645088879894012544773b8b3c1660aeb762be35afeb8427cae5f2a42c18c6ee3f0517a1d9b5fb213baba0382af897d48a932f1ecf3300985f3

data/.travis.yml

@@ -6,6 +6,7 @@ rvm:
   - 2.0.0
   - 2.1.0
   - 2.1.1
+  - 2.1.2
 gemfile:
   - gemfiles/rails_3_2.gemfile
   - gemfiles/rails_4_0.gemfile

data/Appraisals

@@ -1,11 +1,11 @@
 appraise "rails-3-2" do
-  gem "activesupport", "3.2.17"
+  gem "activesupport", "3.2.18"
 end
 
 appraise "rails-4-0" do
-  gem "activesupport", "4.0.4"
+  gem "activesupport", "4.0.5"
 end
 
 appraise "rails-4-1" do
-  gem "activesupport", "4.1.0.rc1"
+  gem "activesupport", "4.1.1"
 end

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 ### Changelog
 
 
+- **0.0.2**
+  - Allow `airbrake` `4.*` to be used (It only removes JS notifier)
+
 - **0.0.1**
   - Initial Release

data/README.md

@@ -1,11 +1,8 @@
 # ExecuteWithRescueWithAirbrake
 
-TODO: Write a gem description
-
 The Airbrake adapter plus mixin to be used with `execute_with_rescue`.
 
 ## Support
-===========
 Tested against:
 - Active Support of version `3.2`, `4.0` and `4.1` (pre-3.2 got wrong dependency & I don't want to support)
 - MRI `1.9.3`, `2.0.0`, `2.1.0`, `2.1.1`
@@ -32,8 +29,6 @@ Or install it yourself as:
 
 ## Usage
 
-TODO: Write usage instructions here
-
 Note: You must configurate `airbrake` first or you won't be able to send anything (I have to do the same in `spec_helper`)
 
 ### `include ExecuteWithRescue::Mixins::WithAirbrake`
@@ -71,6 +66,34 @@ class SomeServiceClass
 end
 ```
 
+If you have a custom error that generates error message from the argument, (and you don't want to duplicate how it generates the message)  
+You can do as the following:
+```ruby
+class SomeServiceClass
+  class CustomErrorWithMessage < StandardError
+    def self.new(thing)
+      msg = "#{thing.class} has error"
+      super(msg)
+    end
+  end
+
+  def perform
+    execute_with_rescue do
+      do_something
+    end
+  end
+
+  def do_something
+    # If you cannot provide the argument for the exception at this point then I can't help you
+    # You should really use `begin...rescue...end` for such customization
+    set_default_airbrake_notice_error_class(CustomErrorWithMessage)
+    set_default_airbrake_notice_error_message(CustomErrorWithMessage.new(:foo).message)
+
+    raise StandardError
+  end
+end
+```
+
 ### `#notify_by_airbrake_or_raise`
 **Private** method to be called automatically by `rescue_from StandardError` from the mixin.  
 Call this if you have some custom handling for some error classes  

data/Rakefile

@@ -9,7 +9,7 @@ RSpec::Core::RakeTask.new(:spec)
 
 if !ENV["APPRAISAL_INITIALIZED"] && !ENV["TRAVIS"]
   task :default do
-    sh "rake appraisal:install && rake appraisal spec"
+    sh "appraisal install && rake appraisal spec"
   end
 else
   task :default => :spec

data/execute_with_rescue_with_airbrake.gemspec

@@ -18,12 +18,13 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "execute_with_rescue", "~> 0.0", ">= 0.0.1"
-  spec.add_dependency "airbrake", "~> 3.1.0"
+  spec.add_dependency "airbrake", ">= 3.1", "<= 5"
 
   spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "appraisal", ">= 0.5.2"
-  spec.add_development_dependency "rspec", "~> 2.14.0"
+  spec.add_development_dependency "appraisal", "~> 1.0"
+  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "rspec-its", "~> 1.0"
   spec.add_development_dependency "coveralls", ">= 0.7"
   spec.add_development_dependency "gem-release", ">= 0.7"
 

data/gemfiles/rails_3_2.gemfile

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "activesupport", "3.2.17"
+gem "activesupport", "3.2.18"
 
-gemspec :path=>"../"
+gemspec :path => "../"

data/gemfiles/rails_4_0.gemfile

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "activesupport", "4.0.4"
+gem "activesupport", "4.0.5"
 
-gemspec :path=>"../"
+gemspec :path => "../"

data/gemfiles/rails_4_1.gemfile

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "activesupport", "4.1.0.rc1"
+gem "activesupport", "4.1.1"
 
-gemspec :path=>"../"
+gemspec :path => "../"

data/lib/execute_with_rescue_with_airbrake/version.rb

@@ -1,3 +1,3 @@
 module ExecuteWithRescueWithAirbrake
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/execute_with_rescue/mixins/with_airbrake_spec.rb

@@ -13,9 +13,9 @@ describe ExecuteWithRescue::Mixins::WithAirbrake do
     let!(:adapter_instance) { adapter_class.new }
     before do
       # Avoid Error
-      test_class_instance
-      .stub(:_execute_with_rescue_current_airbrake_adapter)
-      .and_return(adapter_instance)
+      allow(test_class_instance)
+      .to receive(:_execute_with_rescue_current_airbrake_adapter)
+          .and_return(adapter_instance)
     end
   end
 
@@ -50,7 +50,9 @@ describe ExecuteWithRescue::Mixins::WithAirbrake do
   describe 'delegation' do
     include_context 'when airbrake adapter assumed exists'
 
-    before { adapter_instance.stub(method_name) }
+    before do
+      allow(adapter_instance).to receive(method_name)
+    end
 
     let(:send_message) { test_class_instance.send(method_name) }
 
@@ -82,7 +84,7 @@ describe ExecuteWithRescue::Mixins::WithAirbrake do
   describe 'execution' do
     include_context 'when airbrake adapter assumed exists'
 
-    before { Airbrake.configuration.stub(public?: true) }
+    before { allow(Airbrake.configuration).to receive(:public?) { true } }
 
     describe 'when there is no error raised' do
       specify do
@@ -122,6 +124,21 @@ describe ExecuteWithRescue::Mixins::WithAirbrake do
           call_service
         end
       end
+
+      describe 'setting custom airbrake options with an error that requires argument on initialize' do
+        let(:test_class) { TestServiceWithAirbrakeWithCustomErrorAndMessage }
+
+        specify do
+          expect(Airbrake)
+          .to(receive(:notify_or_ignore)
+              .with(kind_of(StandardError), {
+            error_class: test_class::CustomErrorWithMessage,
+            error_message: "#{:foo.class} has error",
+          }))
+
+          call_service
+        end
+      end
     end
   end
 end

data/spec/execute_with_rescue_with_airbrake/adapters/airbrake_adapter_spec.rb

@@ -14,7 +14,7 @@ describe ExecuteWithRescueWithAirbrake::Adapters::AirbrakeAdapter do
   #before {  }
 
   context 'when exception should not be notified according to Airbrake' do
-    before { Airbrake.configuration.stub(public?: false) }
+    before { allow(Airbrake.configuration).to receive(:public?) { false } }
 
     it 're-raise the rescue error' do
       expect { notify_or_raise }.to raise_error(exception_rescued.class,
@@ -22,7 +22,7 @@ describe ExecuteWithRescueWithAirbrake::Adapters::AirbrakeAdapter do
     end
   end
   context 'when exception should be notified according to Airbrake' do
-    before { Airbrake.configuration.stub(public?: true) }
+    before { allow(Airbrake.configuration).to receive(:public?) { true } }
 
     it 'does not re-raise the rescued error' do
       expect { notify_or_raise }.to_not raise_error
@@ -30,12 +30,14 @@ describe ExecuteWithRescueWithAirbrake::Adapters::AirbrakeAdapter do
   end
 
   context 'assuming Airbrake says it error should be notified' do
-    before { Airbrake.configuration.stub(public?: true) }
+    before { allow(Airbrake.configuration).to receive(:public?) { true } }
 
     it 'calls Airbrake.notify_or_ignore' do
-      Airbrake.should_receive(:notify_or_ignore)
+      expect(Airbrake).to receive(:notify_or_ignore)
 
       notify_or_raise
+
+      # expect(Airbrake).to have_received(:notify_or_ignore)
     end
 
 
@@ -49,7 +51,7 @@ describe ExecuteWithRescueWithAirbrake::Adapters::AirbrakeAdapter do
 
       before do
         # Return the options only
-        Airbrake.stub(:notify_or_ignore) {|*args| args.last }
+        allow(Airbrake).to receive(:notify_or_ignore) {|*args| args.last }
       end
       let(:options_hash) { notify_or_raise }
       subject { options_hash }
@@ -81,7 +83,7 @@ describe ExecuteWithRescueWithAirbrake::Adapters::AirbrakeAdapter do
 
       before do
         # Return the options only
-        Airbrake.stub(:notify_or_ignore) {|*args| args.last }
+        allow(Airbrake).to receive(:notify_or_ignore) {|*args| args.last }
       end
       let(:options_hash) { notify_or_raise }
       subject { options_hash }
@@ -114,7 +116,7 @@ describe ExecuteWithRescueWithAirbrake::Adapters::AirbrakeAdapter do
 
       before do
         # Return the options only
-        Airbrake.stub(:notify_or_ignore) {|*args| args.last }
+        allow(Airbrake).to receive(:notify_or_ignore) {|*args| args.last }
       end
       let(:options_hash) { notify_or_raise }
       let(:parameters_hash) { options_hash[option_key] }

data/spec/fixtures/test_service_classes.rb

@@ -33,6 +33,23 @@ class TestServiceWithAirbrakeWithErrorAndAirbrakeOption <
     super
   end
 end
+class TestServiceWithAirbrakeWithCustomErrorAndMessage <
+    TestServiceWithAirbrakeWithErrorAndAirbrakeOption
+
+  class CustomErrorWithMessage < StandardError
+    def self.new(thing)
+      msg = "#{thing.class} has error"
+      super(msg)
+    end
+  end
+
+  def do_something
+    set_default_airbrake_notice_error_class(CustomErrorWithMessage)
+    set_default_airbrake_notice_error_message(CustomErrorWithMessage.new(:foo).message)
+
+    raise StandardError
+  end
+end
 
 class TestServiceWithAirbrakeWithExecuteWithRescueCall <
     TestServiceWithAirbrake

data/spec/spec_helper.rb

@@ -8,6 +8,7 @@ require 'airbrake'
 
 require 'fixtures/test_service_classes'
 require 'rspec'
+require 'rspec/its'
 
 require 'logger'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: execute_with_rescue_with_airbrake
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - PikachuEXE
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-27 00:00:00.000000000 Z
+date: 2014-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: execute_with_rescue
@@ -34,16 +34,22 @@ dependencies:
   name: airbrake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '3.1'
+    - - <=
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '3.1'
+    - - <=
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '5'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -76,30 +82,44 @@ dependencies:
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.5.2
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.5.2
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -146,11 +166,8 @@ files:
 - Rakefile
 - execute_with_rescue_with_airbrake.gemspec
 - gemfiles/rails_3_2.gemfile
-- gemfiles/rails_3_2.gemfile.lock
 - gemfiles/rails_4_0.gemfile
-- gemfiles/rails_4_0.gemfile.lock
 - gemfiles/rails_4_1.gemfile
-- gemfiles/rails_4_1.gemfile.lock
 - lib/execute_with_rescue/errors/no_airbrake_adapter.rb
 - lib/execute_with_rescue/mixins/with_airbrake.rb
 - lib/execute_with_rescue_with_airbrake.rb