execjs-pcruntime 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 532780a82468c7b672203a979f4280bb01dfb36f0778a942b8784b492aa4cd77
-  data.tar.gz: 814475d105147c9c32cfb0cfe58cb857851d093556c85f3456c704edc68ea336
+  metadata.gz: ba11ad7f3ad06a577368aff2e27006d95f16fe0c9f3c1ae371d8c413797b418e
+  data.tar.gz: 654d4ddc8bfd649ff17fa59d74fa1512db3d0150a9dd759b3d2dfebf7644c767
 SHA512:
-  metadata.gz: 4ac9b87765d852db45a24705b3426403485efa782a79693f67dd85b2d6dfd4cc6fdafb63a1b75aa70fb480fa9620343ea85a7d1b2c1e1d61f7a15bfb2dab035d
-  data.tar.gz: 9fb961d5061ad1454ad1b54e64129f08329b9725e69c5c31713551f26ac322e6edaf3c70dfc650ad95dcdb2f268d4685d5f76dff47e446761c70ae4b27efdecc
+  metadata.gz: 109ce5c2898e87f21fe75c06cc818b7ecc45cd316466ef82bb5fd3fd4c305f00434d284a038d1947626ea13d19a8e3f76037da7b6604f1680c546ee0d4a1c1f4
+  data.tar.gz: '020513096f47aae6fd42c2e73a9b80ba378ad7ff01f1e7acdce2042f6ad37396fa40b0755dae17e7bb5f87e9c4bde881df825648e61c4603e406d8f0ec2e00b5'

data/.github/workflows/test.yml

@@ -0,0 +1,27 @@
+name: Ruby CI
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        ruby-version: ['3.2', '3.1', '3.0']
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Ruby ${{ matrix.ruby-version }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: bundle exec rake

data/.gitignore

@@ -1,4 +1,5 @@
 /*
+!/.github
 !/bin
 !/lib
 !/test

data/Gemfile

@@ -7,8 +7,6 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 # Specify your gem's dependencies in execjs-pcruntime.gemspec
 gemspec
 
-gem 'execjs', '~> 2.0'
-
 group :development do
   gem 'rubocop', require: false
   gem 'rubocop-minitest', require: false
@@ -18,5 +16,5 @@ end
 
 group :test do
   gem 'minitest', '~> 5.0'
-  gem 'rake', '~> 10.0'
+  gem 'rake', '~> 12.0'
 end

data/README.md

@@ -4,6 +4,11 @@ Accelerated ExecJS Runtime by launching Node.js Processes per Context, not per e
 
 inspired by [execjs-fastnode](https://github.com/jhawthorn/execjs-fastnode)
 
+## Requirements
+
+- Ruby >= 3.0.0
+- execjs ~> 2.0
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -13,8 +18,8 @@ gem 'execjs-pcruntime'
 ```
 
 And then execute:
-```
-$ bundle
+```shell
+bundle
 ```
 
 ## Usage
@@ -28,6 +33,14 @@ After checking out the repo, run `bin/setup` to install dependencies. Then, run
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
+### Test
+
+To run a unit test, run the following command.
+
+```shell
+bundle exec rake
+```
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/execjs-pcruntime. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.

data/execjs-pcruntime.gemspec

@@ -8,11 +8,13 @@ Gem::Specification.new do |spec|
   spec.name          = 'execjs-pcruntime'
   spec.version       = Execjs::PCRuntime::VERSION
   spec.authors       = ['White-Green']
-  spec.required_ruby_version = '>3.0.0'
+  spec.required_ruby_version = '>=3.0.0'
   spec.summary       = 'Fast ExecJS Runtime using Process as a Context.'
   spec.homepage      = 'https://rubygems.org/gems/execjs-pcruntime'
   spec.license       = 'MIT'
 
+  spec.add_dependency 'execjs', '~> 2.0'
+
   # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
   # to allow pushing to a single host or delete this section to allow pushing to any host.
   if spec.respond_to?(:metadata)

data/lib/execjs/pcruntime/context_process_runtime.rb

@@ -8,15 +8,15 @@ require 'net/http'
 
 module ExecJS
   module PCRuntime
-    # override ExecJS::Runtime
+    # implementation of ExecJS::Runtime
     class ContextProcessRuntime < Runtime
-      # override ExecJS::Runtime::Context
+      # implementation of ExecJS::Runtime::Context
       class Context < Runtime::Context
         # @param [String] runtime Instance of ContextProcessRuntime
         # @param [String] source JavaScript source code that Runtime load at startup
         # @param [any] options
         def initialize(runtime, source = '', options = {})
-          super(runtime, source, options)
+          super
 
           # @type [JSRuntimeHandle]
           @runtime = runtime.create_runtime_handle
@@ -25,7 +25,7 @@ module ExecJS
           @runtime.evaluate(source.encode('UTF-8'))
         end
 
-        # override ExecJS::Runtime::Context#eval
+        # implementation of ExecJS::Runtime::Context#eval
         # @param [String] source
         # @param [any] _options
         def eval(source, _options = {})
@@ -34,14 +34,14 @@ module ExecJS
           @runtime.evaluate("(#{source.encode('UTF-8')})")
         end
 
-        # override ExecJS::Runtime::Context#exec
+        # implementation of ExecJS::Runtime::Context#exec
         # @param [String] source
         # @param [any] _options
         def exec(source, _options = {})
           @runtime.evaluate("(()=>{#{source.encode('UTF-8')}})()")
         end
 
-        # override ExecJS::Runtime:Context#call
+        # implementation of ExecJS::Runtime:Context#call
         # @param [String] identifier
         # @param [Array<_ToJson>] args
         def call(identifier, *args)
@@ -54,12 +54,12 @@ module ExecJS
       class JSRuntimeHandle
         # @param [Array<String>] binary Launch command for the node(or similar JavaScript Runtime) binary,
         #     such as ['node'], ['deno', 'run'].
-        # @param [String] initial_source Path of .js Runtime loads at startup.
-        def initialize(binary, initial_source)
+        # @param [String] initial_source_path Path of .js Runtime loads at startup.
+        def initialize(binary, initial_source_path)
           Dir::Tmpname.create 'execjs_pcruntime' do |path|
             # Dir::Tmpname.create rescues Errno::EEXIST and retry block
             # So, raise it if failed to create Process.
-            @runtime_pid = create_process(path, *binary, initial_source) || raise(Errno::EEXIST)
+            @runtime_pid = create_process(path, *binary, initial_source_path) || raise(Errno::EEXIST)
             @socket_path = path
           end
           ObjectSpace.define_finalizer(self, self.class.finalizer(@runtime_pid))
@@ -176,6 +176,7 @@ module ExecJS
             result = response.body
             ::JSON.parse(response.body, create_additions: false) if /\S/.match?(result)
           else
+            # expects ErrorMessage\0StackTrace =~ response.body
             message, stack = response.body.split "\0"
             error_class = /SyntaxError:/.match?(message) ? RuntimeError : ProgramError
             error = error_class.new(message)
@@ -200,9 +201,8 @@ module ExecJS
         @deprecated = deprecated
       end
 
-      # override ExecJS::Runtime#available?
+      # implementation of ExecJS::Runtime#available?
       def available?
-        require 'json'
         binary ? true : false
       end
 
@@ -231,7 +231,7 @@ module ExecJS
       #     e.g. ["/the/absolute/path/to/deno", "run"]
       def which(commands)
         commands.each do |command|
-          command, *args = split_command_string command
+          command, *args = Shellwords.split command
           command = search_executable_path command
           return [command] + args unless command.nil?
         end
@@ -240,29 +240,17 @@ module ExecJS
       # Search for absolute path of the executable file from the command.
       # @param [String] command
       # @return [String, nil] the absolute path of the command, or nil if not found
-      # It seems that further method splitting might actually make it harder to read, so suppressing
-      # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity
       def search_executable_path(command)
-        @extensions ||= ExecJS.windows? ? ENV['PATHEXT'].split(File::PATH_SEPARATOR) + [''] : ['']
-        @path ||= ENV['PATH'].split(File::PATH_SEPARATOR) + ['']
-        @path.each do |base_path|
-          @extensions.each do |extension|
+        extensions = ExecJS.windows? ? ENV['PATHEXT'].split(File::PATH_SEPARATOR) + [''] : ['']
+        path = ENV['PATH'].split(File::PATH_SEPARATOR) + ['']
+        path.each do |base_path|
+          extensions.each do |extension|
             executable_path = base_path == '' ? command + extension : File.join(base_path, command + extension)
-            return executable_path if File.executable?(executable_path) && File.exist?(executable_path)
+            return executable_path if File.executable?(executable_path)
           end
         end
         nil
       end
-      # rubocop:enable Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity
-
-      # Split command string
-      #   split_command_string "deno run" # ["deno", "run"]
-      # @param [String] command command string
-      # @return [Array<String>] array split from the command string
-      def split_command_string(command)
-        regex = /([^\s"']+)|"([^"]+)"|'([^']+)'(?:\s+|\s*\Z)/
-        command.scan(regex).flatten.compact
-      end
     end
   end
 end

data/lib/execjs/pcruntime/runner.js

@@ -21,6 +21,8 @@ const server = http.createServer(function (req, res) {
                 } catch (e) {
                     res.statusCode = 500;
                     res.setHeader('Content-Type', 'text/plain');
+                    // to split by \0 on Ruby side
+                    // see context_process_runtime.rb:179
                     res.end(e.toString() + "\0" + (e.stack || ""));
                 }
             });

data/lib/execjs/pcruntime/runtimes.rb

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
 
-require 'execjs/pcruntime/version'
-require 'execjs/pcruntime/context_process_runtime'
 require 'execjs/runtimes'
+require 'execjs/pcruntime/context_process_runtime'
 
 module ExecJS
   # extends ExecJS::Runtimes

data/lib/execjs/pcruntime/version.rb

@@ -2,6 +2,6 @@
 
 module Execjs
   module PCRuntime
-    VERSION = '0.1.1'
+    VERSION = '0.1.2'
   end
 end

data/lib/execjs/pcruntime.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
+require 'execjs'
 require 'execjs/pcruntime/version'
 require 'execjs/pcruntime/runtimes'
-require 'execjs'

metadata

@@ -1,21 +1,36 @@
 --- !ruby/object:Gem::Specification
 name: execjs-pcruntime
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - White-Green
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-07-07 00:00:00.000000000 Z
-dependencies: []
+date: 2023-07-12 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: execjs
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 description:
 email:
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".rubocop.yml"
 - CODE_OF_CONDUCT.md
@@ -44,7 +59,7 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
       version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
@@ -53,7 +68,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.2.33
 signing_key:
 specification_version: 4
 summary: Fast ExecJS Runtime using Process as a Context.