exchange 0.3.0 → 0.4.1

data/Gemfile

@@ -1,7 +1,7 @@
 source "http://rubygems.org"
 # Add dependencies required to use your gem here.
 # Example:
-gem "nokogiri",   ">= 1.4.0"
+gem "nokogiri",   "<= 1.5.0"
 gem "json",       ">= 1.6.5"
 gem "memcached",  ">= 1.3.0"
 gem "redis",      ">= 2.2.0"
@@ -11,7 +11,7 @@ gem "redis",      ">= 2.2.0"
 group :development do
   gem "shoulda", ">= 0"
   gem "yard", "~> 0.7.4"
-  gem "bundler", "~> 1.0.0"
+  gem "bundler", "> 1.0.0"
   gem "jeweler", "~> 1.8.3"
   gem "rspec"
 end

data/Gemfile.lock

@@ -8,33 +8,37 @@ GEM
       git (>= 1.2.5)
       rake
       rdoc
-    json (1.6.5)
-    memcached (1.3.6)
+    json (1.6.6)
+    memcached (1.4.1)
     nokogiri (1.5.0)
     rake (0.9.2.2)
     rdoc (3.12)
       json (~> 1.4)
     redis (2.2.2)
-    rspec (2.8.0)
-      rspec-core (~> 2.8.0)
-      rspec-expectations (~> 2.8.0)
-      rspec-mocks (~> 2.8.0)
-    rspec-core (2.8.0)
-    rspec-expectations (2.8.0)
-      diff-lcs (~> 1.1.2)
-    rspec-mocks (2.8.0)
-    shoulda (2.11.3)
+    rspec (2.9.0)
+      rspec-core (~> 2.9.0)
+      rspec-expectations (~> 2.9.0)
+      rspec-mocks (~> 2.9.0)
+    rspec-core (2.9.0)
+    rspec-expectations (2.9.1)
+      diff-lcs (~> 1.1.3)
+    rspec-mocks (2.9.0)
+    shoulda (3.0.1)
+      shoulda-context (~> 1.0.0)
+      shoulda-matchers (~> 1.0.0)
+    shoulda-context (1.0.0)
+    shoulda-matchers (1.0.0)
     yard (0.7.5)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (~> 1.0.0)
+  bundler (> 1.0.0)
   jeweler (~> 1.8.3)
   json (>= 1.6.5)
   memcached (>= 1.3.0)
-  nokogiri (>= 1.4.0)
+  nokogiri (<= 1.5.0)
   redis (>= 2.2.0)
   rspec
   shoulda

data/README.rdoc

@@ -14,14 +14,34 @@ which gets you an exchange at the rates of yesterday.
 
 Imagine the exchange rates getting cached, and you hitting the internet only daily to get new rates (hourly if you're eager to have the absolutely newest ones)
 
-=== Use two great APIs or your own
+=== ISO 4217 Currency formatting
+On of the issues with currencies is: You never know the format they should be in. With Exchange, you can just use the currencies
+to_s method, which takes care of the right format for you. A version with symbols is under construction. You can either have a
+a string with the currency code in front, or just the amount in the right format
+
+  Exchange::Currency.new(49.567, :usd).to_s           #=> "USD 49.57"
+  Exchange::Currency.new(45, :jpy).to_s               #=> "JPY 45"
+  Exchange::Currency.new(34.34, :omr).to_s            #=> "OMR 34.340"
+  Exchange::ISO4217.stringif(34.34, :omr).to_s(:iso)  #=> "34.340"
+
+=== Use three great APIs or your own great API
+
+Three open APIs are already included: 
+
+- Currency Bot (http://currencybot.github.com/)
+- Xaviermedia (http://www.xavierforum.com/viewtopic.php?f=5&t=10979&sid=671a685edbfa5dbec219fbc6793d5057)
+- European Central Bank (http://www.ecb.int/stats/exchange/eurofxref/html/index.en.html)
 
-Two open APIs are already included: Currency Bot (http://currencybot.github.com/) and Xaviermedia (http://www.xavierforum.com/viewtopic.php?f=5&t=10979&sid=671a685edbfa5dbec219fbc6793d5057)
 but if you have another API you like to use, it becomes as easy as writing one Class and two methods to use it with the Exchange gem. Just visit the documentation here: http://rubydoc.info/github/beatrichartz/exchange/Exchange/ExternalAPI to see an example of a custom API Extension
 
-=== Use great caches or your own
+=== Use great caches or your own great cache
+
+Also, the gem allows you to use one of three available caching solutions: 
+
+- Memcached via the Memcached gem
+- Redis via the redis gem
+- Rails cache (This gem does however not depend on rails)
 
-Also, the gem allows you to use one of three available caching solutions: Memcached via the Memcached gem, Redis via the redis gem or the Rails cache.
 But, same here, if you don't like any of these or want to use your own caching solution, it is as easy as writing one Class and two methods to use it with Exchange. Just visit the documentation here: http://rubydoc.info/github/beatrichartz/exchange/Exchange/Cache for an example of a cache extension
 
 == Installation

data/VERSION

@@ -1 +1 @@
-0.3.0
+0.4.1

data/changelog.rdoc

@@ -0,0 +1,11 @@
+= Changes to Exchange
+
+== 0.3.0
+- All Currencies & Rates get handled in BigDecimal now, preventing floating point errors
+- Major Performance inprovements on the DSL methods
+- New ECB API configuration possibility
+- Refactoring of the cache classes, new File cache class for large file storage
+- ISO 4217 String conversion is now available for all currencies, making it easier to display currencies in their right format
+
+== Up to 0.2.6
+- first version, bugfixes (see documentation)

data/exchange.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "exchange"
-  s.version = "0.3.0"
+  s.version = "0.4.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Beat Richartz"]
-  s.date = "2012-02-05"
+  s.date = "2012-04-15"
   s.description = "The Exchange Gem gives you easy access to currency functions directly on your Numbers. Imagine a conversion as easy as \n    1.eur.to_usd\n  or even better \n    1.eur.to_usd(:at => Time.now - 84600)\n  which gets you an exchange at the rates of yesterday."
   s.email = "exchange_gem@gmail.com"
   s.extra_rdoc_files = [
@@ -26,6 +26,7 @@ Gem::Specification.new do |s|
     "README.rdoc",
     "Rakefile",
     "VERSION",
+    "changelog.rdoc",
     "exchange.gemspec",
     "iso4217.yml",
     "lib/core_extensions/conversability.rb",
@@ -74,41 +75,41 @@ Gem::Specification.new do |s|
   s.homepage = "http://github.com/beatrichartz/exchange"
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.11"
+  s.rubygems_version = "1.8.22"
   s.summary = "Simple Exchange Rate operations for your ruby app"
 
   if s.respond_to? :specification_version then
     s.specification_version = 3
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<nokogiri>, [">= 1.4.0"])
+      s.add_runtime_dependency(%q<nokogiri>, ["<= 1.5.0"])
       s.add_runtime_dependency(%q<json>, [">= 1.6.5"])
       s.add_runtime_dependency(%q<memcached>, [">= 1.3.0"])
       s.add_runtime_dependency(%q<redis>, [">= 2.2.0"])
       s.add_development_dependency(%q<shoulda>, [">= 0"])
       s.add_development_dependency(%q<yard>, ["~> 0.7.4"])
-      s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_development_dependency(%q<bundler>, ["> 1.0.0"])
       s.add_development_dependency(%q<jeweler>, ["~> 1.8.3"])
       s.add_development_dependency(%q<rspec>, [">= 0"])
     else
-      s.add_dependency(%q<nokogiri>, [">= 1.4.0"])
+      s.add_dependency(%q<nokogiri>, ["<= 1.5.0"])
       s.add_dependency(%q<json>, [">= 1.6.5"])
       s.add_dependency(%q<memcached>, [">= 1.3.0"])
       s.add_dependency(%q<redis>, [">= 2.2.0"])
       s.add_dependency(%q<shoulda>, [">= 0"])
       s.add_dependency(%q<yard>, ["~> 0.7.4"])
-      s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_dependency(%q<bundler>, ["> 1.0.0"])
       s.add_dependency(%q<jeweler>, ["~> 1.8.3"])
       s.add_dependency(%q<rspec>, [">= 0"])
     end
   else
-    s.add_dependency(%q<nokogiri>, [">= 1.4.0"])
+    s.add_dependency(%q<nokogiri>, ["<= 1.5.0"])
     s.add_dependency(%q<json>, [">= 1.6.5"])
     s.add_dependency(%q<memcached>, [">= 1.3.0"])
     s.add_dependency(%q<redis>, [">= 2.2.0"])
     s.add_dependency(%q<shoulda>, [">= 0"])
     s.add_dependency(%q<yard>, ["~> 0.7.4"])
-    s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+    s.add_dependency(%q<bundler>, ["> 1.0.0"])
     s.add_dependency(%q<jeweler>, ["~> 1.8.3"])
     s.add_dependency(%q<rspec>, [">= 0"])
   end

data/lib/exchange.rb

@@ -1,3 +1,5 @@
+EXCHANGE_GEM_ROOT_PATH = File.dirname(__FILE__).sub(/\/lib/, '') if __FILE__.is_a?(String) 
+
 require 'bigdecimal'
 require 'open-uri'
 require 'bundler'

data/lib/exchange/cache/memcached.rb

@@ -35,7 +35,7 @@ module Exchange
         def cached api, opts={}, &block
           raise CachingWithoutBlockError.new('Caching needs a block') unless block_given?
           begin
-            result = JSON.load client.get(key(api, opts))
+            result = opts[:plain] ? client.get(key(api, opts)) : JSON.load(client.get(key(api, opts)))
           rescue ::Memcached::NotFound
             result = block.call
             if result && !result.to_s.empty?

data/lib/exchange/cache/redis.rb

@@ -36,7 +36,7 @@ module Exchange
           raise CachingWithoutBlockError.new('Caching needs a block') unless block_given?
           
           if result = client.get(key(api, opts))
-            result = JSON.load result
+            result = opts[:plain] ? result : JSON.load(result)
           else
             result = block.call
             if result && !result.to_s.empty?

data/lib/exchange/currency.rb

@@ -12,7 +12,7 @@ module Exchange
     include Comparable
     
     # @attr_reader
-    # @return [Float] number The number the currency object has been instantiated from
+    # @return [BigDecimal] number The number the currency object has been instantiated from
     attr_reader :value
     
     # @attr_reader

data/lib/exchange/external_api/base.rb

@@ -77,7 +77,7 @@ module Exchange
       #   Exchange::ExternalAPI::Base.new.rate(:usd, :eur, :at => Time.gm(3,23,2009))
       #     #=> 1.232231231
       def rate(from, to, opts={})
-        rate = Configuration.cache_class.cached(Exchange::Configuration.api, opts.merge(:key_for => [from, to])) do
+        rate = Configuration.cache_class.cached(Exchange::Configuration.api, opts.merge(:key_for => [from, to], :plain => true)) do
           update(opts)
           rate_from   = self.rates[to.to_s.upcase]
           rate_to     = self.rates[from.to_s.upcase]

data/lib/exchange/external_api/ecb.rb

@@ -33,6 +33,7 @@ module Exchange
         Configuration.cache_class.cached(self.class, :at => time) do
           Call.new(api_url, :format => :xml, :at => time, :cache => :file, :cache_period => time >= Time.now - 90 * 86400 ? :daily : :monthly) do |result|
             t = time
+            debugger
             while (r = result.css("Cube[time=\"#{t.strftime("%Y-%m-%d")}\"]")).empty? && !times.empty?
               t = times.shift
             end

data/lib/exchange/iso_4217.rb

@@ -14,7 +14,7 @@ module Exchange
       # @return [Hash] The iso427 Definitions with the currency code as keys
       
       def definitions
-        @@definitions ||= YAML.load_file('iso4217.yml')
+        @@definitions ||= YAML.load_file(File.join(EXCHANGE_GEM_ROOT_PATH, 'iso4217.yml'))
       end
       
       # Use this to instantiate a currency amount. For one, it is important that we use BigDecimal here so nothing gets lost because

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: exchange
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,22 +9,27 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-05 00:00:00.000000000 Z
+date: 2012-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &70273282251440 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - <=
       - !ruby/object:Gem::Version
-        version: 1.4.0
+        version: 1.5.0
   type: :runtime
   prerelease: false
-  version_requirements: *70273282251440
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - <=
+      - !ruby/object:Gem::Version
+        version: 1.5.0
 - !ruby/object:Gem::Dependency
   name: json
-  requirement: &70273282249640 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +37,15 @@ dependencies:
         version: 1.6.5
   type: :runtime
   prerelease: false
-  version_requirements: *70273282249640
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.6.5
 - !ruby/object:Gem::Dependency
   name: memcached
-  requirement: &70273282247940 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +53,15 @@ dependencies:
         version: 1.3.0
   type: :runtime
   prerelease: false
-  version_requirements: *70273282247940
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.3.0
 - !ruby/object:Gem::Dependency
   name: redis
-  requirement: &70273282245440 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +69,15 @@ dependencies:
         version: 2.2.0
   type: :runtime
   prerelease: false
-  version_requirements: *70273282245440
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 2.2.0
 - !ruby/object:Gem::Dependency
   name: shoulda
-  requirement: &70273290525780 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +85,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70273290525780
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &70273290521700 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,21 +101,31 @@ dependencies:
         version: 0.7.4
   type: :development
   prerelease: false
-  version_requirements: *70273290521700
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.7.4
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70273290517540 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>'
       - !ruby/object:Gem::Version
         version: 1.0.0
   type: :development
   prerelease: false
-  version_requirements: *70273290517540
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>'
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &70273290514360 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -98,10 +133,15 @@ dependencies:
         version: 1.8.3
   type: :development
   prerelease: false
-  version_requirements: *70273290514360
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.8.3
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70273290505300 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -109,7 +149,12 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70273290505300
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: ! "The Exchange Gem gives you easy access to currency functions directly
   on your Numbers. Imagine a conversion as easy as \n    1.eur.to_usd\n  or even better
   \n    1.eur.to_usd(:at => Time.now - 84600)\n  which gets you an exchange at the
@@ -130,6 +175,7 @@ files:
 - README.rdoc
 - Rakefile
 - VERSION
+- changelog.rdoc
 - exchange.gemspec
 - iso4217.yml
 - lib/core_extensions/conversability.rb
@@ -189,7 +235,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 4209452111928452176
+      hash: -901477728370743168
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -198,7 +244,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.11
+rubygems_version: 1.8.22
 signing_key: 
 specification_version: 3
 summary: Simple Exchange Rate operations for your ruby app