exceptions 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e22bde9b588254869a161c750b9e5f9407857d69
-  data.tar.gz: 39ce679d0cc456ca8cdc676e8885abf806f95b7a
+  metadata.gz: f919423137f3aa99b716901546a5cb9fb0e50d8c
+  data.tar.gz: 2d5176e0c638e4b92cd7fb1fc6966edfa840df82
 SHA512:
-  metadata.gz: 8a66bc3bd68635ed142354ced7e2289790ea357b047fa90f37df7672008f4920e41d85be492b017108c8ff848188d70c9713c140d479210b8fb4a0c3f01180a6
-  data.tar.gz: b8e437c1c02bff288ef0c5c1991a4a11ef15612e106fe42911952b65108b8de1a3c93a61a07442941b82548fa94eddfa942ca37dc8b721c66507839818ec294f
+  metadata.gz: 6e7eaa404821953f1c3d59b3c6fdea2a4273e824a726ef1e5fd2d27e101ad686348aa464c0002ca26405a1e47f8e657624712e45a66faa750a8461597eadf90e
+  data.tar.gz: 2921f752da6ae19f505519c8115e0d35b170e5fc639159864f6150d64d4b431a14e40175f97a370829f7102c92571a2c94c24e32d34172251c0272427e4df9b9

data/lib/exceptions/backends/honeybadger.rb

@@ -5,8 +5,14 @@ module Exceptions
     # Public: The Honeybadger backend is a Backend implementation that sends the 
     # exception to Honeybadger.
     class Honeybadger < Backend
+      attr_reader :honeybadger
+
+      def initialize(honeybadger = ::Honeybadger)
+        @honeybadger = honeybadger
+      end
+
       def notify(exception, options = {})
-        if id = ::Honeybadger.notify_or_ignore(exception, options)
+        if id = honeybadger.notify_or_ignore(exception, options)
           Result.new id
         else
           BadResult.new
@@ -14,15 +20,15 @@ module Exceptions
       end
 
       def context(ctx)
-        ::Honeybadger.context ctx
+        honeybadger.context ctx
       end
 
       def clear_context
-        ::Honeybadger.clear!
+        honeybadger.clear!
       end
 
       def rack_exception(exception, env)
-        notify(exception, rack_env: env) unless ::Honeybadger.
+        notify(exception, rack_env: env) unless honeybadger.
           configuration.
           ignore_user_agent.
           flatten.

data/lib/exceptions/backends/logger.rb

@@ -11,6 +11,7 @@ module Exceptions
 
       def notify(exception, options = {})
         logger.info exception
+        Result.new
       end
     end
   end

data/lib/exceptions/backends/multi.rb

@@ -10,9 +10,18 @@ module Exceptions
       end
 
       def notify(exception, options = {})
-        backends.each do |backend|
+        results = backends.map do |backend|
           backend.notify exception, options
         end
+
+        MultiResult.new results.map(&:id), results.map(&:url)
+      end
+
+      class MultiResult < ::Exceptions::Result
+        def initialize(ids, urls)
+          @id  = ids.join(',')
+          @url = urls.join(',')
+        end
       end
     end
   end

data/lib/exceptions/backends/null.rb

@@ -2,7 +2,9 @@ module Exceptions
   module Backends
     # Public: Null is an implementation of the Backend interface that does nothing.
     class Null < Backend
-      def notify(exception, options = {}); end
+      def notify(exception, options = {})
+        Result.new
+      end
     end
   end
 end

data/lib/exceptions/result.rb

@@ -9,14 +9,14 @@ module Exceptions
   # This class is mostly a reference implementation but anything that conforms to the
   # above interface is acceptable to return.
   class Result
-    attr_reader :id
+    attr_reader :id, :url
 
     def initialize(id = nil)
       @id = id
     end
 
     def url
-      ""
+      @url ||= ""
     end
 
     def ok?

data/lib/exceptions/version.rb

@@ -1,3 +1,3 @@
 module Exceptions
-  VERSION = '0.0.6'
+  VERSION = '0.0.7'
 end

data/spec/exceptions/backends/honeybadger_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe Exceptions::Backends::Honeybadger do
+  let(:honeybadger) { double(::Honeybadger) }
+
+  let(:backend) do
+    described_class.new honeybadger
+  end
+
+  describe '#notify' do
+    subject(:result) { backend.notify(boom) }
+
+    context 'when successful' do
+      before do
+        expect(honeybadger).to receive(:notify_or_ignore).and_return('1234')
+      end
+
+      it 'returns the result' do
+        expect(result.id).to eq '1234'
+      end
+    end
+
+    context 'when errored' do
+      before do
+        expect(honeybadger).to receive(:notify_or_ignore).and_return(nil)
+      end
+
+      it 'returns the result' do
+        expect(result.id).to eq nil
+      end
+    end
+  end
+end

data/spec/exceptions/backends/multi_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe Exceptions::Backends::Multi do
+  let(:backend) do
+    described_class.new \
+      double(Exceptions::Backend, notify: double(Exceptions::Result, id: 1, url: 'http://www.foo.bar')),
+      double(Exceptions::Backend, notify: double(Exceptions::Result, id: 2, url: 'http://www.bar.foo'))
+  end
+
+  describe '#notify' do
+    describe 'result' do
+      subject(:result) { backend.notify(boom) }
+
+      specify { expect(result.id).to eq '1,2' }
+      specify { expect(result.url).to eq 'http://www.foo.bar,http://www.bar.foo' }
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: exceptions
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Eric J. Holmes
@@ -94,7 +94,9 @@ files:
 - lib/exceptions/version.rb
 - lib/rack/exceptions.rb
 - spec/exceptions/backends/honeybadger/integration_spec.rb
+- spec/exceptions/backends/honeybadger_spec.rb
 - spec/exceptions/backends/logger/integration_spec.rb
+- spec/exceptions/backends/multi_spec.rb
 - spec/rack/exceptions_spec.rb
 - spec/spec_helper.rb
 - spec/support/honeybadger.rb
@@ -124,7 +126,9 @@ specification_version: 4
 summary: Exceptions is a Ruby gem for exception tracking.
 test_files:
 - spec/exceptions/backends/honeybadger/integration_spec.rb
+- spec/exceptions/backends/honeybadger_spec.rb
 - spec/exceptions/backends/logger/integration_spec.rb
+- spec/exceptions/backends/multi_spec.rb
 - spec/rack/exceptions_spec.rb
 - spec/spec_helper.rb
 - spec/support/honeybadger.rb