exceptional 2.0.6 → 2.0.7

data/exceptional.gemspec

@@ -1,7 +1,7 @@
 # -*- encoding: utf-8 -*-
 Gem::Specification.new do |s|
   s.name = %q{exceptional}
-  s.version = "2.0.6"
+  s.version = "2.0.7"
   s.authors = ["Contrast"]
   s.summary = %q{ getexceptional.com is a hosted service for tracking errors in your Ruby/Rails/Rack apps }
   s.description = %q{Exceptional is the Ruby gem for communicating with http://getexceptional.com (hosted error tracking service). Use it to find out about errors that happen in your live app. It captures lots of helpful information to help you fix the errors.}

data/lib/exceptional.rb

@@ -14,7 +14,7 @@ require 'exceptional/integration/rack'
 module Exceptional
 
   PROTOCOL_VERSION = 5
-  VERSION = '2.0.6'
+  VERSION = '2.0.7'
   CLIENT_NAME = 'getexceptional-gem'
 
   def self.logger

data/lib/exceptional/controller_exception_data.rb

@@ -23,7 +23,7 @@ module Exceptional
           'request_method' => @request.request_method.to_s,
           'remote_ip' => @request.remote_ip,
           'headers' => extract_http_headers(@request.env),
-          'session' => Exceptional::ControllerExceptionData.sanitize_session(@request)
+          'session' => self.class.sanitize_session(@request)
         }
       }
     end
@@ -56,7 +56,7 @@ module Exceptional
       session_hash['data'] = session.respond_to?(:to_hash) ? session.to_hash : session.instance_variable_get("@data") || {}
       session_hash['session_id'] ||= session_hash['data'][:session_id]
       session_hash['data'].delete(:session_id)
-      ControllerExceptionData.sanitize_hash(session_hash)
+      sanitize_hash(session_hash)
     rescue
       {}
     end

data/lib/exceptional/exception_data.rb

@@ -19,7 +19,7 @@ module Exceptional
       })
       hash.merge!(extra_stuff)
       hash.merge!(context_stuff)
-      hash
+      self.class.sanitize_hash(hash)
     end
 
     def extra_stuff

data/spec/exceptional/exception_data_spec.rb

@@ -79,8 +79,8 @@ describe Exceptional::ControllerExceptionData, 'with request/controller/params'
     @request.stub!(:request_method).and_return(:get)
     @request.stub!(:remote_ip).and_return('1.2.3.4')
     @request.stub!(:env).and_return({'SOME_VAR' => 'abc', 'HTTP_CONTENT_TYPE' => 'text/html'})
-    error = Exceptional::FunkyError.new('some message')
-    data = Exceptional::ControllerExceptionData.new(error, @controller, @request)
+    @error = Exceptional::FunkyError.new('some message')
+    data = Exceptional::ControllerExceptionData.new(@error, @controller, @request)
     @hash = data.to_hash
   end
 
@@ -106,6 +106,13 @@ describe Exceptional::ControllerExceptionData, 'with request/controller/params'
     Exceptional::ControllerExceptionData.sanitize_hash(input).should == {'crazy' => crazy.to_s, :simple => '123', :some_hash => {'1' => '2'}, :array => ['1', '2']}
   end
 
+  it "ArgumentError bug with file object" do
+    file = File.new(File.expand_path('../../fixtures/favicon.png',__FILE__))
+    @request.stub!(:parameters).and_return({'something' => file })
+    data = Exceptional::ControllerExceptionData.new(@error, @controller, @request)
+    data.to_hash['request']['parameters']['something'].should == file.to_s
+  end
+
   it "to_strings regex because JSON.parse(/aa/.to_json) doesn't work" do
     input = {'crazy' => /abc.*/}
     Exceptional::ExceptionData.sanitize_hash(input).should == {'crazy' => /abc.*/.to_s}
@@ -141,25 +148,23 @@ describe Exceptional::ControllerExceptionData, 'with request/controller/params'
   end
 
   it "creates a uniqueness_hash from backtrace" do
-    myException = Exception.new
-    myException.stub!(:backtrace).and_return(['123'])
-    data = Exceptional::ControllerExceptionData.new(myException)
+    exception = Exception.new
+    exception.stub!(:backtrace).and_return(['123'])
+    data = Exceptional::ControllerExceptionData.new(exception)
     data.uniqueness_hash.should == Digest::MD5.hexdigest('123')
   end
   
   it "creates a nil uniqueness_hash if nil backtrace" do
-    myException = Exception.new
-    myException.stub!(:backtrace).and_return(nil)
-    data = Exceptional::ControllerExceptionData.new(myException)    
+    exception = Exception.new
+    exception.stub!(:backtrace).and_return(nil)
+    data = Exceptional::ControllerExceptionData.new(exception)
     data.uniqueness_hash.should == nil
   end
   
   it "creates a uniqueness_hash from backtrace" do
-    myException = Exception.new
-    myException.stub!(:backtrace).and_return([])
-    data = Exceptional::ControllerExceptionData.new(myException)
+    exception = Exception.new
+    exception.stub!(:backtrace).and_return([])
+    data = Exceptional::ControllerExceptionData.new(exception)
     data.uniqueness_hash.should == nil
   end
-  
-  
 end

data/spec/rails_integration_spec.rb

@@ -3,7 +3,7 @@ require File.join(File.dirname(__FILE__), '..', 'lib', 'exceptional', 'integrati
 
 describe Exceptional, 'version number' do
   it "be available proramatically" do
-    Exceptional::VERSION.should == '2.0.6'
+    Exceptional::VERSION.should == '2.0.7'
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: exceptional
 version: !ruby/object:Gem::Version 
-  version: 2.0.6
+  version: 2.0.7
 platform: ruby
 authors: 
 - Contrast
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-01-26 00:00:00 +00:00
+date: 2010-01-27 00:00:00 +00:00
 default_executable: 
 dependencies: []
 
@@ -45,6 +45,7 @@ files:
 - spec/exceptional_rescue_spec.rb
 - spec/fixtures/exceptional.yml
 - spec/fixtures/exceptional_old.yml
+- spec/fixtures/favicon.png
 - spec/ginger_scenarios.rb
 - spec/rack_integration_spec.rb
 - spec/rails_integration_spec.rb