exception_notification 4.4.1 → 4.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 93d19f5540efa1d0c1426ec9ab64f1f16e8c6557b4e5bad5890b99bf62686607
-  data.tar.gz: de614f07ace037bc1b8fb9d998b97bfcb54f122b7a7560bf2f20693fd382a6ee
+  metadata.gz: ae2c9d720954788440b1deedc356091324eb5c393801790d6f861c4fe157bdb4
+  data.tar.gz: 31e91bdeeda86d168e887fa235e31b9810feb37c91317d564eee46c425376011
 SHA512:
-  metadata.gz: 839fb346abb6142cbf5185d947c982fbf1d2516a7289769392926e674ee78550565861b03b3970d75e6c9d5838155316f3a893b44a4d76f9ee4d5dc1f7da0b6f
-  data.tar.gz: e6def42195dc5f106e959b1e4601cd6593e799b9e5232b9e0ea08f4b3cfa87e48a3c44300af3d0e0b2de43b1c17cf40ed344557742f28961463865d60423ebdc
+  metadata.gz: cbd31aedd92e7fc5064cad2efde830070aa41f2289f3e08f57c63d001046cad20187dd6948c4fd96e6489d3d513ee1d6b32069206cbc3562a82bb17f4b92e314
+  data.tar.gz: fda70cf9f41a3a57bb83e47bfebbd1c181de0400faa72807474e76b6f2ec69f07ce37ea1ee1a5429e9dfb1b65006a6255765c0bd0677ff53cbf42cd274b5c254

data/CHANGELOG.rdoc

@@ -1,3 +1,13 @@
+== 4.4.3
+
+* big fixes
+  * Remove using configured default from address from custom mailer_parent class
+
+== 4.4.2 (yanked)
+
+* bug fixes
+  * Fix `sender_address` being overwritten
+
 == 4.4.1
 
 * enhancements

data/exception_notification.gemspec

@@ -6,7 +6,7 @@ Gem::Specification.new do |s|
   s.name = 'exception_notification'
   s.version = ExceptionNotification::VERSION
   s.authors = ['Jamis Buck', 'Josh Peek']
-  s.date = '2020-06-23'
+  s.date = '2020-06-29'
   s.summary = 'Exception notification for Rails apps'
   s.homepage = 'https://smartinez87.github.io/exception_notification/'
   s.email = 'smartinez87@gmail.com'

data/lib/exception_notification/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ExceptionNotification
-  VERSION = '4.4.1'
+  VERSION = '4.4.3'
 end

data/lib/exception_notifier/email_notifier.rb

@@ -127,7 +127,7 @@ module ExceptionNotifier
             headers = {
               delivery_method: @options[:delivery_method],
               to: exception_recipients,
-              from: self.class.default[:from] || @options[:sender_address],
+              from: @options[:sender_address],
               subject: subject,
               template_name: name
             }.merge(@options[:email_headers])

data/test/exception_notifier/email_notifier_test.rb

@@ -353,25 +353,3 @@ class EmailNotifierWithEnvTest < ActiveSupport::TestCase
     assert_equal '[ERROR]  (ZeroDivisionError) "divided by 0"', mail.subject
   end
 end
-
-class EmailNotifierWithCustomParentClassTest < ActiveSupport::TestCase
-  class ApplicationMailer < ActionMailer::Base
-    default from: 'infrastructure@example.com'
-  end
-
-  setup do
-    @exception = ZeroDivisionError.new('divided by 0')
-    @exception.set_backtrace(["#{__FILE__}:#{__LINE__}"])
-  end
-
-  test 'uses default from configured parent class' do
-    email_notifier = ExceptionNotifier::EmailNotifier.new(
-      mailer_parent: 'EmailNotifierWithCustomParentClassTest::ApplicationMailer',
-      exception_recipients: %w[dummyexceptions@example.com]
-    )
-    mail = email_notifier.call(@exception)
-
-    assert email_notifier.__send__(:mailer) < ApplicationMailer
-    assert_equal ['infrastructure@example.com'], mail.from
-  end
-end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: exception_notification
 version: !ruby/object:Gem::Version
-  version: 4.4.1
+  version: 4.4.3
 platform: ruby
 authors:
 - Jamis Buck
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-23 00:00:00.000000000 Z
+date: 2020-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionmailer