exception_notification 4.1.3 → 4.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3696eecc7d4afcf68b5458d570f811a595b2e912
-  data.tar.gz: 1a5d379db9e9e9dff3d4e15c1b9e3f435daa41f3
+  metadata.gz: 7d847c323ad183933f5a1d63e29f06e9e8d6aaa9
+  data.tar.gz: 06b5d75b2ca566178384e2d8c60982b73aa1b567
 SHA512:
-  metadata.gz: bde0dd2960675f710e0073d38f2f4e75bc7b783de92ea337337b83e67ce39a7650911a182743c2cd2200082b74fb113c0619e453e3817e2fa52b0796b841f3dd
-  data.tar.gz: 6caf354673c7e63c800fa9417d5bf9df72220257a891895326bbae110aaa4879770d87fb30113e555014b691094f9f4e47a7968bc619f3d6e18a60a3b09a3eae
+  metadata.gz: 2d0744472e25aab1f35eaf6c66ab6ddd771885560fec22d3b60d6799ddff773689e1faf75af486b48280f59528fc119a54661474e0c56a86ed855799b213ba33
+  data.tar.gz: 2e51a10be77772151a0f866f81f105bf8b76d2d92bbd98537b36377db752592abd7704387380118bf3b40cb36c825b232f8bb26a41d7f27e5de9bb43928fbf60

data/CHANGELOG.rdoc

@@ -1,4 +1,10 @@
-== undefined
+== 4.1.4
+
+* bug fixes
+  * HTML-escape exception messages sent to hipchat
+  * Send the correct options in send_notice
+
+== 4.1.3
 
 * enhancements
   * Add a way to have a backtrace callback on notifiers (by @pcboy)

data/exception_notification.gemspec

@@ -1,8 +1,7 @@
 Gem::Specification.new do |s|
   s.name = 'exception_notification'
-  s.version = '4.1.3'
+  s.version = '4.1.4'
   s.authors = ["Jamis Buck", "Josh Peek"]
-  s.date = %q{2015-12-22}
   s.summary = "Exception notification for Rails apps"
   s.homepage = "http://smartinez87.github.com/exception_notification"
   s.email = "smartinez87@gmail.com"

data/lib/exception_notifier/base_notifier.rb

@@ -14,11 +14,11 @@ module ExceptionNotifier
     end
 
     def _pre_callback(exception, options, message, message_opts)
-      @base_options[:pre_callback].call(base_options, self, exception.backtrace, message, message_opts) if @base_options[:pre_callback].respond_to?(:call)
+      @base_options[:pre_callback].call(options, self, exception.backtrace, message, message_opts) if @base_options[:pre_callback].respond_to?(:call)
     end
 
     def _post_callback(exception, options, message, message_opts)
-      @base_options[:post_callback].call(base_options, self, exception.backtrace, message, message_opts) if @base_options[:post_callback].respond_to?(:call)
+      @base_options[:post_callback].call(options, self, exception.backtrace, message, message_opts) if @base_options[:post_callback].respond_to?(:call)
     end
 
   end

data/lib/exception_notifier/hipchat_notifier.rb

@@ -16,7 +16,7 @@ module ExceptionNotifier
         @from             = options.delete(:from) || 'Exception'
         @room             = HipChat::Client.new(api_token, opts)[room_name]
         @message_template = options.delete(:message_template) || ->(exception) {
-          msg = "A new exception occurred: '#{exception.message}'"
+          msg = "A new exception occurred: '#{Rack::Utils.escape_html(exception.message)}'"
           msg += " on '#{exception.backtrace.first}'" if exception.backtrace
           msg
         }

data/test/exception_notifier/hipchat_notifier_test.rb

@@ -104,6 +104,22 @@ class HipchatNotifierTest < ActiveSupport::TestCase
     hipchat.call(fake_exception)
   end
 
+  test "should send hipchat notification with HTML-escaped meessage if using default message_template" do
+    options = {
+      :api_token => 'good_token',
+      :room_name => 'room_name',
+      :color     => 'yellow',
+    }
+
+    exception = fake_exception_with_html_characters
+    body = "A new exception occurred: '#{Rack::Utils.escape_html(exception.message)}' on '#{exception.backtrace.first}'"
+
+    HipChat::Room.any_instance.expects(:send).with('Exception', body, { :color => 'yellow' })
+
+    hipchat = ExceptionNotifier::HipchatNotifier.new(options)
+    hipchat.call(exception)
+  end
+
   test "should use APIv1 if api_version is not specified" do
     options = {
       :api_token => 'good_token',
@@ -143,6 +159,14 @@ class HipchatNotifierTest < ActiveSupport::TestCase
     end
   end
 
+  def fake_exception_with_html_characters
+    exception = begin
+      raise StandardError.new('an error with <html> characters')
+    rescue Exception => e
+      e
+    end
+  end
+
   def fake_body_without_backtrace
     "A new exception occurred: '#{fake_exception_without_backtrace.message}'"
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: exception_notification
 version: !ruby/object:Gem::Version
-  version: 4.1.3
+  version: 4.1.4
 platform: ruby
 authors:
 - Jamis Buck
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-22 00:00:00.000000000 Z
+date: 2016-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionmailer