exception_notification-ikachan 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 174d70e10eacc6df6566279d6eed3f8f7cb7aae5
-  data.tar.gz: 83a1c7f985f431272dadf45ce13196d490a6e1b0
+  metadata.gz: d6b7bf509704cee5b7374e4a87570dfb12956ccc
+  data.tar.gz: 60b3b2cd16bf6e7c9b3f0ea42e8598fcc69c44ad
 SHA512:
-  metadata.gz: f58b929cca9b113f786485fb9b87eb95174a27dedb0ad045014d16b6c0b6ecd2bbdb25abb661d58fa1b018444afc4537ecb7b6d794a9aa62861917ad8f8ab6b6
-  data.tar.gz: 7104a68e2760be7033df27d9b85ad5a710e59ea78982ef9fa9e037ca25f8bd441ff7b4346da47af81d79d3497d031c21a6db002113e43ee6d71876eeabcc4260
+  metadata.gz: 7c103dbb780ae535b67112d45986c85098fb9293185682567bff81c927d77980ff9fc12939d655efb2865abc297c96565239d1780de2b92cb28b3f1349b514eb
+  data.tar.gz: 95bf030d7fcb49993681ec0984e0544ff26483ff2e2e6e98c323ea07424b4445befdbb78d43c90d797a323578541f71736aa0d53104b0201d129804f324af287

data/lib/exception_notification/ikachan/version.rb

@@ -1,5 +1,5 @@
 module ExceptionNotification
   class Ikachan
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

data/lib/exception_notifier/ikachan_notifier.rb

@@ -12,7 +12,9 @@ module ExceptionNotifier
       def notice_all(channels, message)
         channels.each do |channel|
           join(channel)
-          notice(channel, message)
+          message.each_line do |line|
+            notice(channel, line)
+          end
         end
       end
 
@@ -62,7 +64,7 @@ module ExceptionNotifier
         message:  exception.message,
         occurred: (exception.backtrace.first rescue nil),
       }
-      params.merge!(build_params_from_request(options[:env])) if options[:env]
+      params.merge!(build_params_from_request(options[:env]))
       @message = message_format % params
     end
 
@@ -87,7 +89,8 @@ module ExceptionNotifier
       end
     end
 
-    def build_params_from_request(env)
+    def build_params_from_request(env=nil)
+      return default_params_from_request unless env
       request = request_klass.new(env)
       dest = {}
       @request_param_names.map{|n| [n, n.sub(/^request_/, '')] }.each do |param_name, attribute|
@@ -96,6 +99,12 @@ module ExceptionNotifier
       dest
     end
 
+    def default_params_from_request
+      @request_param_names.each_with_object({}) do |name, dest|
+        dest[name.to_sym] = ''
+      end
+    end
+
     # alias
     VERSION = ExceptionNotification::Ikachan::VERSION
   end

data/spec/exception_notification/ikachan_spec.rb

@@ -59,6 +59,13 @@ describe ExceptionNotifier::IkachanNotifier do
         notifier.build_message(exception, {env: {'PATH_INFO' => '/foo/bar'}})
         expect(notifier.message).to eq("/foo/bar")
       end
+
+      it "should not raise error without env" do
+        expect {
+          notifier.build_message(exception)
+        }.not_to raise_error
+        expect(notifier.message).to eq("")
+      end
     end
 
     describe "message with more request info" do
@@ -122,20 +129,42 @@ describe ExceptionNotifier::IkachanNotifier do
       {
         base_url: 'ikachan.udzura.jp',
         channel:  '#udzura',
-        message_format: '%{class}: %{message}'
+        message_format: message_format
       }
     end
     let(:exception) { StandardError.new("Hello, exception!")}
 
-    it "should notice message to ikachan" do
-      stub_join = stub_request(:post, "http://ikachan.udzura.jp/join").
-        with(body: {"channel" => "#udzura"})
-      stub_notice = stub_request(:post, "http://ikachan.udzura.jp/notice").
-        with(body: {"channel" => "#udzura", "message" => "StandardError: Hello, exception!"})
+    describe 'single line' do
+      let(:message_format){ '%{class}: %{message}' }
+
+      it "should notice message to ikachan" do
+        stub_join = stub_request(:post, "http://ikachan.udzura.jp/join").
+          with(body: {"channel" => "#udzura"})
+        stub_notice = stub_request(:post, "http://ikachan.udzura.jp/notice").
+          with(body: {"channel" => "#udzura", "message" => "StandardError: Hello, exception!"})
 
-      notifier.call(exception, {})
-      stub_join.should have_been_requested.once
-      stub_notice.should have_been_requested.once
+        notifier.call(exception, {})
+        stub_join.should have_been_requested.once
+        stub_notice.should have_been_requested.once
+      end
+    end
+
+    describe 'multiple line' do
+      let(:message_format){ <<-EOFormat }
+%{class}
+%{message}
+extra info
+      EOFormat
+      it "should notice message to ikachan" do
+        stub_join = stub_request(:post, "http://ikachan.udzura.jp/join").
+          with(body: {"channel" => "#udzura"})
+        stub_notice = stub_request(:post, "http://ikachan.udzura.jp/notice").
+          with(body: {"channel" => "#udzura", "message" => an_instance_of(String)})
+
+        notifier.call(exception, {})
+        stub_join.should have_been_requested.once
+        stub_notice.should have_been_requested.times(3)
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: exception_notification-ikachan
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Uchio KONDO