exception_notification-idobata 1.0.2 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: df660b8a1356591bf0e7ba36631fba5b7156826f
-  data.tar.gz: 010e9b45bfb289ee787e9348537812a7e2b7bc94
+  metadata.gz: fa728904929bc8fd75fa221be571995ebf26df70
+  data.tar.gz: 6301680b8f61911bcc20f861fdd3dc0819a83a15
 SHA512:
-  metadata.gz: 78c4117317c8676cf218b7273eb58c2e12f41a3e3935d3f4aea1b2d3e58b696b0ffcd954f88e58ec5107c0e7cee29be4912d10db4edf75efb336a0a9393f6a7a
-  data.tar.gz: 817930c112d109e25c1abf2a58bb45bf8c45bba50fe5b722f0bacef44d9d3095719873931a6efc8e636848d3cc8ae20b9d512d9059f55e68600a79fe09d86714
+  metadata.gz: ec84b599dd603518eccfed4e2b4bb684478d7bd0892f6ad18be6bab59d940114574ebf19391496676e98eb42450ce518a2ddd04ebba67f466009e2470a1ddc25
+  data.tar.gz: cab5440ad2d3754ecc3ebaad6846a411a1133ecb74633244537729596b86b8bcc156652779ee573f7b5019064478414682a33f8a732e018bf937f6d8df04bb87

data/lib/exception_notification/idobata/version.rb

@@ -1,5 +1,5 @@
 module ExceptionNotification
   class Idobata
-    VERSION = '1.0.2'
+    VERSION = '1.1.0'
   end
 end

data/lib/exception_notifier/idobata_notifier.rb

@@ -7,7 +7,7 @@ module ExceptionNotifier
     attr_reader :url
 
     def initialize(options)
-      @options = extract_global_options(options, :url, :skip_library_backtrace)
+      @options = extract_global_options(options, :url, :skip_library_backtrace, :proxy)
 
       raise(ArgumentError, 'Endpoint must be specified') unless @url
     end
@@ -23,11 +23,28 @@ module ExceptionNotifier
 
       source = build_message(exception, enviroments)
 
-      Net::HTTP.post_form URI.parse(url),  source: source, format: :html
+      http_client.post_form URI.parse(url),  source: source, format: :html
     end
 
     private
 
+    def http_client
+      @proxy ? Net::HTTP.Proxy(*extract_proxy_settings(@proxy)) : Net::HTTP
+    end
+
+    def extract_proxy_settings(proxy)
+      case proxy
+      when String
+        extract_proxy_settings(URI(proxy))
+      when URI
+        [proxy.host, proxy.port]
+      when Hash
+        proxy.values_at(:host, :port)
+      else
+        proxy
+      end
+    end
+
     def extract_global_options(options, *global_option_names)
       options.dup.tap do |opts|
         global_option_names.each {|name| instance_variable_set "@#{name}", opts.delete(name) }

data/spec/exception_notifier/idobata_notifier_spec.rb

@@ -74,4 +74,46 @@ describe ExceptionNotifier::IdobataNotifier do
 </table>
     HTML
   end
+
+  describe '#http_client' do
+    let(:proxy) { raise NotImplementedError }
+    let(:notifier) do
+      ExceptionNotifier::IdobataNotifier.new(
+        :url => 'https://idobata.io/hook/endpoint',
+        :proxy => proxy,
+      )
+    end
+
+    subject(:http_client) { notifier.send(:http_client) }
+
+    context ':proxy is a url string' do
+      let(:proxy) { 'http://proxy-address:8080/' }
+
+      it { expect(http_client).to be_proxy_class }
+      it { expect(http_client.proxy_address).to eq 'proxy-address' }
+      it { expect(http_client.proxy_port).to eq 8080 }
+    end
+
+    context ':proxy is a URI object' do
+      let(:proxy) { URI('http://proxy-address:8080/') }
+
+      it { expect(http_client).to be_proxy_class }
+      it { expect(http_client.proxy_address).to eq 'proxy-address' }
+      it { expect(http_client.proxy_port).to eq 8080 }
+    end
+
+    context ':proxy is a Hash object' do
+      let(:proxy) { {host: 'proxy-address', port: 8080} }
+
+      it { expect(http_client).to be_proxy_class }
+      it { expect(http_client.proxy_address).to eq 'proxy-address' }
+      it { expect(http_client.proxy_port).to eq 8080 }
+    end
+
+    context ':proxy is nil' do
+      let(:proxy) { nil }
+
+      it { expect(http_client).to_not be_proxy_class }
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: exception_notification-idobata
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Hiroshi Yoshida
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-23 00:00:00.000000000 Z
+date: 2016-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: exception_notification