exception_notification-idobata 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ade18db9b418ae3b8003b3b97ad2a38292251fdf
-  data.tar.gz: 5efb9417aef0b6126fac3dee7dbead6fa2e4948f
+  metadata.gz: 352f43ae3d2cd73331781cc480d0c529aedb88d5
+  data.tar.gz: d8a55027f2bbebf7e97632162dd81c9b77e02282
 SHA512:
-  metadata.gz: 86f70e6b9446b1b82839920b5a3b6306ba4c552e3830dc549f321680b7a3010d602c6d77a885b437ff02b8a18b01f528fd8e550e4a7c65d17f994d3f448e128f
-  data.tar.gz: 1624ff334d5c43396a2af11db0670425c04132aa55a62929468b19d278e12d8b5bc08c19e1fbe999e3686a3627bac1623710a98903ade2e56f381dedfc437549
+  metadata.gz: 3a3fd4b7dfe424065aca217e148c355ef2fce1f5eb9395719f004f0709bda319864d00ec19b78a2534f154f4f1c20179f4d9167a4404a0b86e4e7b05aef00b6f
+  data.tar.gz: 20f27fe15d9b36884fccebb061e28612f178556057e97074dc113d905bbcc62508aca052bc5425ca78854af733fcce438b26462c4165b4062f46653c4ececdcd

data/lib/exception_notification/idobata/version.rb

@@ -1,5 +1,5 @@
 module ExceptionNotification
   class Idobata
-    VERSION = '0.0.2'
+    VERSION = '0.0.3'
   end
 end

data/lib/exception_notifier/idobata_notifier.rb

@@ -6,11 +6,9 @@ module ExceptionNotifier
     attr_reader :url
 
     def initialize(options)
-      unless @url = options.delete(:url)
-        raise ArgumentError, 'Endpoint must be specified'
-      end
+      @options = extract_global_options(options, :url, :skip_library_backtrace)
 
-      @options = options
+      raise(ArgumentError, 'Endpoint must be specified') unless @url
     end
 
     def call(exception, options={})
@@ -29,6 +27,12 @@ module ExceptionNotifier
 
     private
 
+    def extract_global_options(options, *global_option_names)
+      options.dup.tap do |opts|
+        global_option_names.each {|name| instance_variable_set "@#{name}", opts.delete(name) }
+      end
+    end
+
     def request_option(request)
       {
         'URL'         => request.original_url,
@@ -65,11 +69,11 @@ module ExceptionNotifier
     def format_backtrace(trace)
       trace.map { |line|
         if from_bundler?(line)
-          line.sub(bundle_root, '[bundle]...')
+          @skip_library_backtrace ? nil : line.sub(bundle_root, '[bundle]...')
         else
           line.sub(app_root, '[app]...')
         end
-      }
+      }.compact
     end
 
     def from_bundler?(line)
@@ -85,5 +89,6 @@ module ExceptionNotifier
     def app_root
       Dir.pwd
     end
+
   end
 end

data/spec/exception_notifier/idobata_notifier_spec.rb

@@ -14,6 +14,32 @@ describe ExceptionNotifier::IdobataNotifier do
     end
   end
 
+  context 'option :skip_library_backtrace => true' do
+    describe '#build_message' do
+      let(:notifier) do
+        ExceptionNotifier::IdobataNotifier.new(
+          :url => 'https://idobata.io/hook/endpoint',
+          :skip_library_backtrace => true,
+        )
+      end
+
+      let(:library_trace) { 'gems/exception_notification-4.0.1/lib/exception_notifier.rb' }
+
+      let(:exception) do
+        StandardError.new('hello world').tap do |e|
+          e.set_backtrace([
+            [__FILE__,  __LINE__].join(':'),
+            "#{Bundler.bundle_path + library_trace}:1"
+          ])
+        end
+      end
+
+      subject(:message) { notifier.send(:build_message, exception, {}) }
+
+      specify { expect(message).not_to include(library_trace) }
+    end
+  end
+
   describe '#build_message' do
     let(:exception) { StandardError.new('hello, world') }
     let(:backtrace) { ['spec/exception_notifier/idobata_notifier_spec.rb'] }

metadata

@@ -1,83 +1,83 @@
 --- !ruby/object:Gem::Specification
 name: exception_notification-idobata
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Hiroshi Yoshida
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-17 00:00:00.000000000 Z
+date: 2014-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: exception_notification
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.0.0.beta2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.0.0.beta2
 description: exception_notification for Idobata
@@ -87,9 +87,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -110,17 +110,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: exception_notification for Idobata