exception_notification-idobata 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 15c121178f5cd30a18a3a478fc9d3ee54096a1a5
-  data.tar.gz: f60ca4b1ea1e2a3e5661458081553a4b237cb0c7
+  metadata.gz: ade18db9b418ae3b8003b3b97ad2a38292251fdf
+  data.tar.gz: 5efb9417aef0b6126fac3dee7dbead6fa2e4948f
 SHA512:
-  metadata.gz: 4259a25670828c2258e94f30a17955ed8956c0b4517f887aab31e3080647d772854d0b142fcec48e8259a19a3b6cacaa03d2e6e93ed613b872b276626606e8e4
-  data.tar.gz: 905307fa72225ab90a799880b1bf149ad3bc61d0cf1eccc999487726b76680051c1c995dafea91a45ddf492fc052d10b736771669ba04f4409218cd12169092c
+  metadata.gz: 86f70e6b9446b1b82839920b5a3b6306ba4c552e3830dc549f321680b7a3010d602c6d77a885b437ff02b8a18b01f528fd8e550e4a7c65d17f994d3f448e128f
+  data.tar.gz: 1624ff334d5c43396a2af11db0670425c04132aa55a62929468b19d278e12d8b5bc08c19e1fbe999e3686a3627bac1623710a98903ade2e56f381dedfc437549

data/README.md

@@ -4,20 +4,26 @@
 
 Add this line to your application's Gemfile:
 
-    gem 'exception_notification-idobata', github: 'hrysd/exception_notification-idobata'
-
+```ruby
+gem 'exception_notification'
+gem 'exception_notification-idobata'
+```
 And then execute:
 
-    $ bundle
+```
+$ bundle
+```
 
 ## Usage
 
+This plugin works by putting the following lines in your `config/environments/production.rb`
+
 ```ruby
 Sample::Application.configure do
-  config.middleware.use
-    ExceptionNotification::Rack,
+  config.middleware.use ExceptionNotification::Rack,
     idobata: {
-      url: HOOK_ENDPOINT
+      url:    HOOK_ENDPOINT,
+      stage:  'Optional params as you like'
     }
 end
 ```

data/lib/exception_notification/idobata/version.rb

@@ -1,5 +1,5 @@
 module ExceptionNotification
   class Idobata
-    VERSION = '0.0.1'
+    VERSION = '0.0.2'
   end
 end

data/lib/exception_notifier/idobata_notifier.rb

@@ -6,7 +6,37 @@ module ExceptionNotifier
     attr_reader :url
 
     def initialize(options)
-      @url = options[:url]
+      unless @url = options.delete(:url)
+        raise ArgumentError, 'Endpoint must be specified'
+      end
+
+      @options = options
+    end
+
+    def call(exception, options={})
+      enviroments =
+        if options[:env]
+          request_option(ActionDispatch::Request.new(options[:env]))
+        else
+          # [TODO] - Add option specification route for non-web notification
+          {'Timestamp' => Time.zone.now}
+        end
+
+      source = build_message(exception, enviroments)
+
+      RestClient.post @url, source: source, format: 'html'
+    end
+
+    private
+
+    def request_option(request)
+      {
+        'URL'         => request.original_url,
+        'HTTP Method' => request.method,
+        'IP Address'  => request.remote_ip,
+        'Paramters'   => request.filtered_parameters,
+        'Timestamp'   => Time.zone.now
+      }
     end
 
     def build_message(exception, enviroments)
@@ -20,30 +50,12 @@ module ExceptionNotifier
 <h4>Environments:</h4>
 <table>
   <tbody>
-    #{table_rows_from(enviroments)}
+    #{table_rows_from(@options.merge(enviroments))}
   </tbody>
 </table>
       HTML
     end
 
-    def call(exception, options={})
-      env = options[:env]
-
-      request = ActionDispatch::Request.new(env)
-
-      source = build_message(exception,
-        'URL'         => request.original_url,
-        'HTTP Method' => request.method,
-        'IP Address'  => request.remote_ip,
-        'Paramters'   => request.filtered_parameters,
-        'Timestamp'   => Time.zone.now
-      )
-
-      RestClient.post @url, source: source, format: 'html'
-    end
-
-    private
-
     def table_rows_from(hash)
       hash.each_with_object('') { |(key, value), rows|
         rows << "<tr><th>#{key}</th><td>#{value}</td></tr>"

data/spec/exception_notifier/idobata_notifier_spec.rb

@@ -1,7 +1,12 @@
 require 'spec_helper'
 
 describe ExceptionNotifier::IdobataNotifier do
-  let(:notifier) { described_class.new(url: 'https://idobata.io/hook/endpoint') }
+  let(:notifier) do
+    described_class.new(
+      :url => 'https://idobata.io/hook/endpoint',
+      'Rails ENV' => 'staging'
+    )
+  end
 
   describe '#initialize' do
     it 'should set url' do
@@ -22,7 +27,7 @@ describe ExceptionNotifier::IdobataNotifier do
       }
     }
 
-    subject { notifier.build_message(exception, enviroments) }
+    subject { notifier.send(:build_message, exception, enviroments) }
 
     before do
       allow(exception).to receive(:backtrace).and_return(backtrace)
@@ -38,7 +43,7 @@ describe ExceptionNotifier::IdobataNotifier do
 <h4>Environments:</h4>
 <table>
   <tbody>
-    <tr><th>URL</th><td>http://hrysd.org</td></tr><tr><th>HTTP Method</th><td>GET</td></tr><tr><th>IP Address</th><td>127.0.0.1</td></tr><tr><th>Paramters</th><td>{"controller"=>"welcome", "action"=>"index"}</td></tr><tr><th>Timestamp</th><td>2014-03-16 16:30:35 +900</td></tr>
+    <tr><th>Rails ENV</th><td>staging</td></tr><tr><th>URL</th><td>http://hrysd.org</td></tr><tr><th>HTTP Method</th><td>GET</td></tr><tr><th>IP Address</th><td>127.0.0.1</td></tr><tr><th>Paramters</th><td>{"controller"=>"welcome", "action"=>"index"}</td></tr><tr><th>Timestamp</th><td>2014-03-16 16:30:35 +900</td></tr>
   </tbody>
 </table>
     HTML

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: exception_notification-idobata
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Hiroshi Yoshida
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-16 00:00:00.000000000 Z
+date: 2014-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: exception_notification