exception_handling 3.1.2 → 3.2.0.pre.dc.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2233f129161cf047d7859362e4801aab61ee8f5c6a91224733b92c5c0222120c
-  data.tar.gz: 16c764f0a44dac9de1774cdc5716a81e80488664f7b5e2d658dd2435f8dcfc8b
+  metadata.gz: 5a1419e36b2b184e6e49ad6b943537b1f5efaf54680aef66251093c242e93168
+  data.tar.gz: 641de9b2e454c20cb754469fce0f781136baefb14af6913ab25fce3f0263bae4
 SHA512:
-  metadata.gz: acd751fa75679ea47611198b450caa91a2d46e9b36766f070d8344a499370004da310b54df8b841220fe74a35b36498317cdf7a333d84c7c7abcc374ef95ef17
-  data.tar.gz: 25af611bb83d53bd23e038f38b5a5bf33f99b166d14e4dfd080a4824429b1d334a57560c8e739a6e6b5fdc4aa9776f6c18a0110b1452f08345ea2d3647d8104a
+  metadata.gz: d3ba9e37ec6c14e508341b604df6ffaeed7c88106ca19305f69a2990f6eefcf03a8ae41a3fb6f7245165e00cb910940ae99842f6d73d9c641d8a9f9c2293a883
+  data.tar.gz: a9402fb31a6cce4d2181d9b304376412c7acbf63ffb4e592615da2a2bfd77330c8e6ef1a9bb4c3e1428f6dd9bec32295c5f572860117912cb4f34c6f9e49df27

data/.github/workflows/pipeline.yml

@@ -1,28 +1,9 @@
----
 name: Pipeline
-on: [push]
+on:
+  push:
+  schedule:
+  - cron: '0 1 * * 1' # Every Monday at 1AM UTC
 jobs:
   tests:
-    name: Unit Tests
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        ruby: [2.7, '3.0', 3.1, 3.2, 3.3]
-        gemfile:
-        - Gemfile
-        - gemfiles/rails_6_0.gemfile
-        - gemfiles/rails_6_1.gemfile
-        - gemfiles/rails_7_0.gemfile
-        - gemfiles/rails_7_1.gemfile
-    env:
-      BUNDLE_GEMFILE: ${{ matrix.gemfile }}
-    steps:
-    - uses: actions/checkout@v2
-    - uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: ${{ matrix.ruby }}
-        bundler: 2.3.26
-        bundler-cache: true
-    - name: Unit tests
-      run: bundle exec rspec
+    uses: Invoca/ruby-test-matrix-workflow/.github/workflows/ruby-test-matrix.yml@main
+    secrets: inherit

data/.gitignore

@@ -4,3 +4,4 @@
 spec/reports/*
 gemfiles/*.lock
 pkg/
+coverage/

data/Appraisals

@@ -1,17 +1,4 @@
 # frozen_string_literal: true
 
-appraise "rails-6-0" do
-  gem 'activesupport', '~> 6.0.0'
-end
-
-appraise "rails-6-1" do
-  gem 'activesupport', '~> 6.1.0'
-end
-
-appraise "rails-7-0" do
-  gem 'activesupport', '~> 7.0.0'
-end
-
-appraise "rails-7-1" do
-  gem 'activesupport', '~> 7.1.0'
-end
+require "appraisal/matrix"
+appraisal_matrix(rails: "7.0")

data/CHANGELOG.md

@@ -4,6 +4,11 @@ Inspired by [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 **Note:** this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [3.2.0] - 2026-08-04
+### Added
+- Optional Sentry notifications from `send_external_notifications` when the `Sentry` constant is defined
+- `send_to_sentry` exception filter flag (default `false`); filters with `send_to_honeybadger: true` also send to Sentry to ease migration
+
 ## [3.1.2] - 2024-05-08
 ### Fixed
 - Fixed deprecation warnings that were coming from usage of `silence` when using this gem with Rails 7.1

data/Gemfile

@@ -5,7 +5,8 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'activesupport'
-gem 'appraisal', '~> 2.2'
+gem 'appraisal'
+gem 'appraisal-matrix'
 gem 'gem-release'
 gem 'honeybadger', '~> 4.11'
 gem 'pry'
@@ -14,4 +15,13 @@ gem 'rake'
 gem 'rspec'
 gem 'rspec_junit_formatter'
 gem 'rubocop'
+gem 'simplecov', '~> 0.22'
+gem 'simplecov-lcov', '~> 0.8'
 gem 'test-unit'
+
+
+gem "concurrent-ruby", "~> 1.3", "< 1.3.5"
+
+gem "base64", ">= 0.2.0"
+gem "bigdecimal", ">= 3.1"
+gem "mutex_m", ">= 0.2.0"

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    exception_handling (3.1.2)
+    exception_handling (3.2.0.pre.dc.0)
       activesupport (>= 5.2)
       contextual_logger (~> 1.0)
       escalate (~> 0.3)
@@ -25,25 +25,29 @@ GEM
       bundler
       rake
       thor (>= 0.14.0)
+    appraisal-matrix (0.3.0)
+      appraisal (~> 2.2)
     ast (2.4.2)
     base64 (0.2.0)
     bigdecimal (3.1.8)
     byebug (11.1.3)
     coderay (1.1.3)
-    concurrent-ruby (1.2.3)
+    concurrent-ruby (1.3.4)
     connection_pool (2.4.1)
-    contextual_logger (1.2.0)
-      activesupport
+    contextual_logger (1.5.0)
+      activesupport (>= 6.0)
       json
+    date (3.5.1)
     diff-lcs (1.5.1)
+    docile (1.4.1)
     drb (2.2.1)
     escalate (0.3.0)
     gem-release (2.2.2)
     honeybadger (4.12.2)
     i18n (1.14.5)
       concurrent-ruby (~> 1.0)
-    invoca-utils (0.5.1)
-      activesupport (>= 5.0)
+    invoca-utils (0.7.0)
+      activesupport (>= 6.0)
     json (2.7.2)
     language_server-protocol (3.17.0.3)
     method_source (1.1.0)
@@ -60,7 +64,8 @@ GEM
     pry-byebug (3.10.1)
       byebug (~> 11.0)
       pry (>= 0.13, < 0.15)
-    psych (5.1.2)
+    psych (5.4.0)
+      date
       stringio
     racc (1.7.3)
     rainbow (3.1.1)
@@ -96,7 +101,14 @@ GEM
     rubocop-ast (1.31.3)
       parser (>= 3.3.1.0)
     ruby-progressbar (1.13.0)
-    stringio (3.1.0)
+    simplecov (0.22.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.13.2)
+    simplecov-lcov (0.9.0)
+    simplecov_json_formatter (0.1.4)
+    stringio (3.2.0)
     test-unit (3.6.2)
       power_assert
     thor (1.3.1)
@@ -109,16 +121,23 @@ PLATFORMS
 
 DEPENDENCIES
   activesupport
-  appraisal (~> 2.2)
+  appraisal
+  appraisal-matrix
+  base64 (>= 0.2.0)
+  bigdecimal (>= 3.1)
+  concurrent-ruby (~> 1.3, < 1.3.5)
   exception_handling!
   gem-release
   honeybadger (~> 4.11)
+  mutex_m (>= 0.2.0)
   pry
   pry-byebug
   rake
   rspec
   rspec_junit_formatter
   rubocop
+  simplecov (~> 0.22)
+  simplecov-lcov (~> 0.8)
   test-unit
 
 BUNDLED WITH

data/README.md

@@ -39,6 +39,22 @@ ExceptionHandling.honeybadger_auto_tagger = ->(exception) { [] } # See "Automati
 ExceptionHandling.add_honeybadger_tag_from_log_context("tag-name", path: ["path", "in", "log", "context"])
 ```
 
+### External error trackers (Honeybadger / Sentry)
+
+ExceptionHandling notifies configured external services from `log_error` (and related paths):
+
+- **Honeybadger** — when the `Honeybadger` constant is defined
+- **Sentry** — when the `Sentry` constant is defined (for example after initializing the Sentry Ruby SDK in your app)
+
+Both can run at the same time. This gem does not depend on `sentry-ruby`; initialize Sentry in the host application.
+
+Matched exception filters in `exception_filters.yml` control delivery:
+
+- `send_to_honeybadger: true` — send to Honeybadger (and also to Sentry during migration)
+- `send_to_sentry: true` — send to Sentry
+- Unmatched exceptions are sent when the corresponding service is defined
+- Matched filters with both flags false skip both services
+
 ## Usage
 
 Mixin the `ExceptionHandling::Methods` module into your controllers, models or classes. The example below adds it to all the controllers in you rails application:

data/catalog-info.yaml

@@ -0,0 +1,39 @@
+# This file is partially auto-generated by the invoca-backstage-tools gem
+# The following fields should not be edited manually as they are auto-generated
+# based on the contents of the repo:
+#  - metadata.name
+#  - metadata.title
+#  - metadata.description
+#  - annotations.github.com/project-slug
+#  - invoca.com/version-repository-location
+#  - invoca.com/version-repository-name
+#  - spec.type
+#  - spec.owner
+---
+apiVersion: backstage.io/v1alpha1
+kind: Component
+metadata:
+  name: exception_handling-gem
+  title: ExceptionHandling
+  annotations:
+    buildkite.com/project-slug: Invoca/exception_handling
+    github.com/project-slug: Invoca/exception_handling
+    invoca.com/version-repository-location: rubygems
+    invoca.com/version-repository-name: exception_handling
+    endoflife.date/products: ruby@3.3
+  tags:
+  - ruby
+  - open-source
+  - gem
+  - public
+  - rails-dependent
+  description: Exception handling logger
+spec:
+  type: library
+  lifecycle: production
+  owner: octothorpe
+  system: platform-observability
+  dependsOn:
+  - component:escalate-gem
+  - component:invoca-utils-gem
+  - component:contextual_logger-gem

data/gemfiles/rails_7_0.gemfile

@@ -2,8 +2,9 @@
 
 source "https://rubygems.org"
 
-gem "activesupport", "~> 7.0.0"
-gem "appraisal", "~> 2.2"
+gem "activesupport"
+gem "appraisal"
+gem "appraisal-matrix"
 gem "gem-release"
 gem "honeybadger", "~> 4.11"
 gem "pry"
@@ -13,5 +14,12 @@ gem "rspec"
 gem "rspec_junit_formatter"
 gem "rubocop"
 gem "test-unit"
+gem "concurrent-ruby", "~> 1.3", "< 1.3.5"
+gem "base64", ">= 0.2.0"
+gem "bigdecimal", ">= 3.1"
+gem "mutex_m", ">= 0.2.0"
+gem "rails", "~> 7.0.0"
+gem "simplecov", "~> 0.22"
+gem "simplecov-lcov", "~> 0.8"
 
 gemspec path: "../"

data/gemfiles/rails_7_1.gemfile

@@ -2,8 +2,9 @@
 
 source "https://rubygems.org"
 
-gem "activesupport", "~> 7.1.0"
-gem "appraisal", "~> 2.2"
+gem "activesupport"
+gem "appraisal"
+gem "appraisal-matrix"
 gem "gem-release"
 gem "honeybadger", "~> 4.11"
 gem "pry"
@@ -13,5 +14,12 @@ gem "rspec"
 gem "rspec_junit_formatter"
 gem "rubocop"
 gem "test-unit"
+gem "concurrent-ruby", "~> 1.3", "< 1.3.5"
+gem "base64", ">= 0.2.0"
+gem "bigdecimal", ">= 3.1"
+gem "mutex_m", ">= 0.2.0"
+gem "rails", "~> 7.1.0"
+gem "simplecov", "~> 0.22"
+gem "simplecov-lcov", "~> 0.8"
 
 gemspec path: "../"

data/gemfiles/rails_7_2.gemfile

@@ -0,0 +1,25 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activesupport"
+gem "appraisal"
+gem "appraisal-matrix"
+gem "gem-release"
+gem "honeybadger", "~> 4.11"
+gem "pry"
+gem "pry-byebug"
+gem "rake"
+gem "rspec"
+gem "rspec_junit_formatter"
+gem "rubocop"
+gem "test-unit"
+gem "concurrent-ruby", "~> 1.3", "< 1.3.5"
+gem "base64", ">= 0.2.0"
+gem "bigdecimal", ">= 3.1"
+gem "mutex_m", ">= 0.2.0"
+gem "rails", "~> 7.2.0"
+gem "simplecov", "~> 0.22"
+gem "simplecov-lcov", "~> 0.8"
+
+gemspec path: "../"

data/gemfiles/rails_8_0.gemfile

@@ -0,0 +1,25 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activesupport"
+gem "appraisal"
+gem "appraisal-matrix"
+gem "gem-release"
+gem "honeybadger", "~> 4.11"
+gem "pry"
+gem "pry-byebug"
+gem "rake"
+gem "rspec"
+gem "rspec_junit_formatter"
+gem "rubocop"
+gem "test-unit"
+gem "concurrent-ruby", "~> 1.3", "< 1.3.5"
+gem "base64", ">= 0.2.0"
+gem "bigdecimal", ">= 3.1"
+gem "mutex_m", ">= 0.2.0"
+gem "rails", "~> 8.0.0"
+gem "simplecov", "~> 0.22"
+gem "simplecov-lcov", "~> 0.8"
+
+gemspec path: "../"

data/lib/exception_handling/exception_description.rb

@@ -6,12 +6,13 @@ module ExceptionHandling
 
     CONFIGURATION_SECTIONS = {
       send_to_honeybadger: false,  # should be sent to honeybadger?
+      send_to_sentry: false,       # should be sent to sentry?
       send_metric: true,   # should the metric be sent.
       metric_name: nil,    # Will be derived from section name if not passed
       notes: nil     # Will be included in exception email if set, used to keep notes and relevant links
     }.freeze
 
-    attr_reader :filter_name, :send_to_honeybadger, :send_metric, :metric_name, :notes
+    attr_reader :filter_name, :send_to_honeybadger, :send_to_sentry, :send_metric, :metric_name, :notes
 
     def initialize(filter_name, configuration)
       @filter_name = filter_name
@@ -21,6 +22,7 @@ module ExceptionHandling
 
       @configuration = CONFIGURATION_SECTIONS.merge(configuration)
       @send_to_honeybadger = @configuration[:send_to_honeybadger]
+      @send_to_sentry = @configuration[:send_to_sentry]
       @send_metric = @configuration[:send_metric]
       @metric_name = (@configuration[:metric_name] || @filter_name).to_s.gsub(" ", "_")
       @notes       = @configuration[:notes]

data/lib/exception_handling/exception_info.rb

@@ -78,6 +78,14 @@ module ExceptionHandling
       ExceptionHandling.honeybadger_defined? && (!exception_description || exception_description.send_to_honeybadger)
     end
 
+    def send_to_sentry?
+      ExceptionHandling.sentry_defined? && (
+        !exception_description ||
+          exception_description.send_to_sentry ||
+          exception_description.send_to_honeybadger
+      )
+    end
+
     def honeybadger_context_data
       @honeybadger_context_data ||= enhanced_data_to_honeybadger_context
     end

data/lib/exception_handling/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ExceptionHandling
-  VERSION = '3.1.2'
+  VERSION = '3.2.0.pre.dc.0'
 end

data/lib/exception_handling.rb

@@ -211,6 +211,9 @@ module ExceptionHandling # never included
       if honeybadger_defined?
         results[:honeybadger_status] = send_exception_to_honeybadger_unless_filtered(exception_info)
       end
+      if sentry_defined?
+        results[:sentry_status] = send_exception_to_sentry_unless_filtered(exception_info)
+      end
       results
     end
 
@@ -249,6 +252,31 @@ module ExceptionHandling # never included
       :failure
     end
 
+    # Returns :success or :failure or :skipped
+    def send_exception_to_sentry_unless_filtered(exception_info)
+      if exception_info.send_to_sentry?
+        send_exception_to_sentry(exception_info)
+      else
+        log_info("Filtered exception using '#{exception_info.exception_description.filter_name}'; not sending notification to Sentry")
+        :skipped
+      end
+    end
+
+    #
+    # Log exception to Sentry.
+    #
+    # Returns :success or :failure
+    #
+    def send_exception_to_sentry(exception_info)
+      exception = exception_info.exception
+      response = Sentry.capture_exception(exception)
+      response ? :success : :failure
+    rescue Exception => ex
+      warn("ExceptionHandling.send_exception_to_sentry rescued exception while logging #{exception_info.exception_context}:\n#{exception.class}: #{exception.message}:\n#{ex.class}: #{ex.message}\n#{ex.backtrace.join("\n")}")
+      write_exception_to_log(ex, "ExceptionHandling.send_exception_to_sentry rescued exception while logging #{exception_info.exception_context}:\n#{exception.class}: #{exception.message}", exception_info.timestamp)
+      :failure
+    end
+
     #
     # Check if Honeybadger defined.
     #
@@ -256,6 +284,13 @@ module ExceptionHandling # never included
       Object.const_defined?("Honeybadger")
     end
 
+    #
+    # Check if Sentry defined.
+    #
+    def sentry_defined?
+      Object.const_defined?("Sentry")
+    end
+
     #
     # Expects passed in hash to only include keys which be directly set on the Honeybadger config
     #

data/spec/simplecov_helper.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+unless ENV["NO_COVERAGE"] == "true"
+  require "simplecov"
+
+  SimpleCov.start do
+    add_filter "/spec/"
+    track_files "lib/**/*.rb"
+
+    if ENV["GITHUB_ACTIONS"]
+      require "simplecov-lcov"
+
+      SimpleCov::Formatter::LcovFormatter.config do |config|
+        config.report_with_single_file = true
+        config.single_report_path = "coverage/lcov.info"
+      end
+
+      formatter SimpleCov::Formatter::LcovFormatter
+    else
+      formatter SimpleCov::Formatter::HTMLFormatter
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative "simplecov_helper"
+
 require 'rspec'
 require 'rspec/mocks'
 require 'rspec_junit_formatter'

data/spec/unit/exception_handling/exception_description_spec.rb

@@ -35,6 +35,12 @@ module ExceptionHandling
         expect(!ExceptionDescription.new(:filter1, error: "my error message").send_to_honeybadger).to be_truthy
       end
 
+      it "allow send_to_sentry to be specified and have it disabled by default" do
+        expect(ExceptionDescription.new(:filter1, error: "my error message", send_to_sentry: false).send_to_sentry).to eq(false)
+        expect(ExceptionDescription.new(:filter1, error: "my error message", send_to_sentry: true).send_to_sentry).to eq(true)
+        expect(ExceptionDescription.new(:filter1, error: "my error message").send_to_sentry).to eq(false)
+      end
+
       it "allow send_metric to be configured" do
         expect(!ExceptionDescription.new(:filter1, error: "my error message", send_metric: false).send_metric).to be_truthy
         expect(ExceptionDescription.new(:filter1, error: "my error message").send_metric).to be_truthy

data/spec/unit/exception_handling/exception_info_spec.rb

@@ -452,6 +452,48 @@ module ExceptionHandling
       end
     end
 
+    context "send_to_sentry?" do
+      it "be enabled when Sentry is defined and exception is not in the filter list" do
+        allow(ExceptionHandling).to receive(:sentry_defined?).and_return(true)
+        exception_info = ExceptionInfo.new(StandardError.new("something went wrong"), nil, Time.now)
+        expect(exception_info.exception_description).to be_nil
+        expect(exception_info.send_to_sentry?).to eq(true)
+      end
+
+      it "be enabled when Sentry is defined and filter has send_to_sentry true" do
+        allow(ExceptionHandling).to receive(:sentry_defined?).and_return(true)
+        exception = StandardError.new("No route matches")
+        exception_info = ExceptionInfo.new(exception, nil, Time.now)
+        allow(exception_info.exception_description).to receive(:send_to_sentry).and_return(true)
+        allow(exception_info.exception_description).to receive(:send_to_honeybadger).and_return(false)
+        expect(exception_info.send_to_sentry?).to eq(true)
+      end
+
+      it "be enabled when Sentry is defined and filter has send_to_honeybadger true only" do
+        allow(ExceptionHandling).to receive(:sentry_defined?).and_return(true)
+        exception = StandardError.new("No route matches")
+        exception_info = ExceptionInfo.new(exception, nil, Time.now)
+        allow(exception_info.exception_description).to receive(:send_to_sentry).and_return(false)
+        allow(exception_info.exception_description).to receive(:send_to_honeybadger).and_return(true)
+        expect(exception_info.send_to_sentry?).to eq(true)
+      end
+
+      it "be disabled when Sentry is defined and both filter flags are false" do
+        allow(ExceptionHandling).to receive(:sentry_defined?).and_return(true)
+        exception = StandardError.new("No route matches")
+        exception_info = ExceptionInfo.new(exception, nil, Time.now)
+        allow(exception_info.exception_description).to receive(:send_to_sentry).and_return(false)
+        allow(exception_info.exception_description).to receive(:send_to_honeybadger).and_return(false)
+        expect(exception_info.send_to_sentry?).to eq(false)
+      end
+
+      it "be disabled when Sentry is not defined" do
+        allow(ExceptionHandling).to receive(:sentry_defined?).and_return(false)
+        exception_info = ExceptionInfo.new(StandardError.new("something went wrong"), nil, Time.now)
+        expect(exception_info.send_to_sentry?).to eq(false)
+      end
+    end
+
     context "honeybadger_context_data" do
       before do
         allow(ExceptionHandling.logger).to receive(:current_context_for_thread).and_return({ cuid: 'ABCD' })

data/spec/unit/exception_handling_spec.rb

@@ -690,6 +690,139 @@ describe ExceptionHandling do
         end
       end
 
+      context "Sentry integration" do
+        context "with Sentry not defined" do
+          before do
+            allow(ExceptionHandling).to receive(:sentry_defined?).and_return(false)
+          end
+
+          it "not invoke send_exception_to_sentry when log_error is executed" do
+            expect(ExceptionHandling).to_not receive(:send_exception_to_sentry)
+            ExceptionHandling.log_error(exception_1)
+          end
+
+          it "not invoke send_exception_to_sentry when ensure_safe is executed" do
+            expect(ExceptionHandling).to_not receive(:send_exception_to_sentry)
+            ExceptionHandling.ensure_safe { raise exception_1 }
+          end
+        end
+
+        context "with Sentry defined" do
+          let(:sentry_module) do
+            Module.new do
+              def self.capture_exception(_exception); end
+            end
+          end
+
+          before do
+            stub_const("Sentry", sentry_module)
+            allow(Sentry).to receive(:capture_exception).and_return(Object.new)
+          end
+
+          it "not send_exception_to_sentry when log_warning is executed" do
+            expect(ExceptionHandling).to_not receive(:send_exception_to_sentry)
+            ExceptionHandling.log_warning("This should not go to sentry")
+          end
+
+          it "not send_exception_to_sentry when log_error is called with a Warning" do
+            expect(ExceptionHandling).to_not receive(:send_exception_to_sentry)
+            ExceptionHandling.log_error(ExceptionHandling::Warning.new("This should not go to sentry"))
+          end
+
+          it "invoke send_exception_to_sentry when log_error is executed" do
+            expect(ExceptionHandling).to receive(:send_exception_to_sentry).with(any_args).and_call_original
+            ExceptionHandling.log_error(exception_1)
+          end
+
+          it "invoke send_exception_to_sentry when log_error_rack is executed" do
+            expect(ExceptionHandling).to receive(:send_exception_to_sentry).with(any_args).and_call_original
+            ExceptionHandling.log_error_rack(exception_1, {}, nil)
+          end
+
+          it "invoke send_exception_to_sentry when ensure_safe is executed" do
+            expect(ExceptionHandling).to receive(:send_exception_to_sentry).with(any_args).and_call_original
+            ExceptionHandling.ensure_safe { raise exception_1 }
+          end
+
+          it "call Sentry.capture_exception with the exception" do
+            expect(Sentry).to receive(:capture_exception).with(exception_1)
+            ExceptionHandling.log_error(exception_1)
+          end
+
+          it "also notify Honeybadger when both are defined" do
+            expect(Honeybadger).to receive(:notify).with(any_args).and_return("hb-id")
+            expect(Sentry).to receive(:capture_exception).with(exception_1).and_return(Object.new)
+            ExceptionHandling.log_error(exception_1)
+          end
+
+          it "not send to Sentry when filter has both flags false" do
+            filter_list = {
+              NoSentry: {
+                error: "suppress Sentry notification",
+                send_to_honeybadger: false,
+                send_to_sentry: false
+              }
+            }
+            allow(File).to receive(:mtime) { incrementing_mtime }
+            expect(YAML).to receive(:load_file).with(any_args) { ActiveSupport::HashWithIndifferentAccess.new(filter_list) }.at_least(1)
+
+            expect(ExceptionHandling).to receive(:send_exception_to_sentry_unless_filtered).with(any_args).exactly(1).and_call_original
+            expect(Sentry).to_not receive(:capture_exception)
+            ExceptionHandling.log_error(StandardError.new("suppress Sentry notification"))
+          end
+
+          it "send to Sentry when filter has send_to_honeybadger true only" do
+            filter_list = {
+              HoneybadgerOnly: {
+                error: "honeybadger only filter",
+                send_to_honeybadger: true,
+                send_to_sentry: false
+              }
+            }
+            allow(File).to receive(:mtime) { incrementing_mtime }
+            expect(YAML).to receive(:load_file).with(any_args) { ActiveSupport::HashWithIndifferentAccess.new(filter_list) }.at_least(1)
+
+            expect(Sentry).to receive(:capture_exception).with(instance_of(StandardError))
+            ExceptionHandling.log_error(StandardError.new("honeybadger only filter"))
+          end
+
+          it "send to Sentry when filter has send_to_sentry true only" do
+            filter_list = {
+              SentryOnly: {
+                error: "sentry only filter",
+                send_to_honeybadger: false,
+                send_to_sentry: true
+              }
+            }
+            allow(File).to receive(:mtime) { incrementing_mtime }
+            expect(YAML).to receive(:load_file).with(any_args) { ActiveSupport::HashWithIndifferentAccess.new(filter_list) }.at_least(1)
+
+            expect(Sentry).to receive(:capture_exception).with(instance_of(StandardError))
+            ExceptionHandling.log_error(StandardError.new("sentry only filter"))
+          end
+
+          it "still complete log_error and notify Honeybadger if Sentry.capture_exception raises" do
+            expect(Honeybadger).to receive(:notify).with(any_args).and_return("hb-id")
+            expect(Sentry).to receive(:capture_exception).and_raise(StandardError, "Sentry Notification Failure")
+            expect { ExceptionHandling.log_error(exception_1) }.not_to raise_error
+          end
+
+          it "return :failure when Sentry.capture_exception returns nil" do
+            expect(Sentry).to receive(:capture_exception).and_return(nil)
+            expect(ExceptionHandling.send_exception_to_sentry(
+                     ExceptionHandling::ExceptionInfo.new(exception_1, "", Time.now)
+                   )).to eq(:failure)
+          end
+
+          it "return :success when Sentry.capture_exception returns an event" do
+            expect(Sentry).to receive(:capture_exception).and_return(Object.new)
+            expect(ExceptionHandling.send_exception_to_sentry(
+                     ExceptionHandling::ExceptionInfo.new(exception_1, "", Time.now)
+                   )).to eq(:success)
+          end
+        end
+      end
+
       class EventResponse
         def to_s
           "message from to_s!"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: exception_handling
 version: !ruby/object:Gem::Version
-  version: 3.1.2
+  version: 3.2.0.pre.dc.0
 platform: ruby
 authors:
 - Invoca
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-05-08 00:00:00.000000000 Z
+date: 2026-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -103,12 +103,13 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- catalog-info.yaml
 - config/exception_filters.yml
 - exception_handling.gemspec
-- gemfiles/rails_6_0.gemfile
-- gemfiles/rails_6_1.gemfile
 - gemfiles/rails_7_0.gemfile
 - gemfiles/rails_7_1.gemfile
+- gemfiles/rails_7_2.gemfile
+- gemfiles/rails_8_0.gemfile
 - lib/exception_handling.rb
 - lib/exception_handling/escalate_callback.rb
 - lib/exception_handling/exception_catalog.rb
@@ -121,6 +122,7 @@ files:
 - spec/helpers/controller_helpers.rb
 - spec/helpers/exception_helpers.rb
 - spec/rake_test_warning_false.rb
+- spec/simplecov_helper.rb
 - spec/spec_helper.rb
 - spec/unit/exception_handling/escalate_callback_spec.rb
 - spec/unit/exception_handling/exception_catalog_spec.rb
@@ -149,7 +151,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.21
+rubygems_version: 3.5.10
 signing_key:
 specification_version: 4
 summary: Invoca's exception handling logger layer, based on exception_notifier.
@@ -157,6 +159,7 @@ test_files:
 - spec/helpers/controller_helpers.rb
 - spec/helpers/exception_helpers.rb
 - spec/rake_test_warning_false.rb
+- spec/simplecov_helper.rb
 - spec/spec_helper.rb
 - spec/unit/exception_handling/escalate_callback_spec.rb
 - spec/unit/exception_handling/exception_catalog_spec.rb

data/gemfiles/rails_6_0.gemfile

@@ -1,17 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activesupport", "~> 6.0.0"
-gem "appraisal", "~> 2.2"
-gem "gem-release"
-gem "honeybadger", "~> 4.11"
-gem "pry"
-gem "pry-byebug"
-gem "rake"
-gem "rspec"
-gem "rspec_junit_formatter"
-gem "rubocop"
-gem "test-unit"
-
-gemspec path: "../"

data/gemfiles/rails_6_1.gemfile

@@ -1,17 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activesupport", "~> 6.1.0"
-gem "appraisal", "~> 2.2"
-gem "gem-release"
-gem "honeybadger", "~> 4.11"
-gem "pry"
-gem "pry-byebug"
-gem "rake"
-gem "rspec"
-gem "rspec_junit_formatter"
-gem "rubocop"
-gem "test-unit"
-
-gemspec path: "../"