exception_handling 2.11.1 → 2.11.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 14067795e410d640a90c3fe1b9b0100eb23ccaf27b61f48a243fb0e485fac5aa
-  data.tar.gz: 48e75e5776a54debb7620a0b3d743611b3e40be68b7e0b6f6e785c751e20f03c
+  metadata.gz: 316ced9b4f0224f3754c6214f4007f4fdd1e21a8aaeebfc145792eb418a8b577
+  data.tar.gz: 9d75e6bb79c29ec712832154dfbb64cd1ab786708b5e4591dbb84966c427c9f8
 SHA512:
-  metadata.gz: fd0e94f719f695339c74a157b79a6f941b1826707cddafb725b550c203949fd0c7a801860cf0e8a7412735bc8f36517df99592b0d0f85b86f790fdc95f9fe952
-  data.tar.gz: b2eb7943d905f5c137370ac47dd7bd69656e082a88af7d8d5618c0ff7acefda4503b2eca6138fc4ae74b57f3fe18623cd250e2edb0a6c9c1a5e46be6e3529080
+  metadata.gz: 0e61d34cf62836872573f456cb72438de47332c60a642f7d30635375288f388718c9bd04b717e780236d56aa0ed78e27d4429d2db3df616c982188ff8cec8b90
+  data.tar.gz: 9b004abd4b56e48706784aeaaae6cdeef4ee654f5ea241fa2823cbc307ec717cebc8c19ce455d7fc9d710d119a7c5a6ed5810d953d78cd62a74c1dfdc1d8b5ef

data/CHANGELOG.md

@@ -4,6 +4,10 @@ Inspired by [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 Note: this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.11.2] - 2022-04-04
+### Fixed
+- Fixed Ruby 3+ bug where arguments where not being passed using ** operator when writing to the logger
+
 ## [2.11.1] - 2022-04-04
 ### Fixed
 - Fixed bug in ruby 3+ where `contextual_logger` was missing ruby 3+ support
@@ -83,6 +87,7 @@ Note: this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0
 ### Changed
 - No longer depends on hobo_support. Uses invoca-utils 0.3 instead.
 
+[2.11.2]: https://github.com/Invoca/exception_handling/compare/v2.11.1...v2.11.2
 [2.11.1]: https://github.com/Invoca/exception_handling/compare/v2.11.0...v2.11.1
 [2.11.0]: https://github.com/Invoca/exception_handling/compare/v2.10.0...v2.11.0
 [2.10.0]: https://github.com/Invoca/exception_handling/compare/v2.9.0...v2.10.0

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    exception_handling (2.11.1)
+    exception_handling (2.11.2)
       actionmailer (>= 5.2, < 7.0)
       actionpack (>= 5.2, < 7.0)
       activesupport (>= 5.2, < 7.0)
@@ -56,7 +56,7 @@ GEM
       activesupport
       json
     crass (1.0.6)
-    diff-lcs (1.4.4)
+    diff-lcs (1.5.0)
     digest (3.1.0)
     erubi (1.10.0)
     escalate (0.3.0)
@@ -121,7 +121,7 @@ GEM
     rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
-    rspec-support (3.9.3)
+    rspec-support (3.9.4)
     rspec_junit_formatter (0.4.1)
       rspec-core (>= 2, < 4, != 2.12.0)
     rubocop (0.74.0)

data/lib/exception_handling/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ExceptionHandling
-  VERSION = '2.11.1'
+  VERSION = '2.11.2'
 end

data/lib/exception_handling.rb

@@ -230,9 +230,9 @@ module ExceptionHandling # never included
         log_message = "#{exception_context}\n#{ex.class}: (#{encode_utf8(ex.message.to_s)}):\n  " + clean_backtrace(ex).join("\n  ") + "\n\n"
 
         if ex.is_a?(Warning)
-          ExceptionHandling.logger.warn("\nExceptionHandlingWarning (Warning:#{timestamp}) #{log_message}", log_context)
+          ExceptionHandling.logger.warn("\nExceptionHandlingWarning (Warning:#{timestamp}) #{log_message}", **log_context)
         else
-          ExceptionHandling.logger.fatal("\nExceptionHandlingError (Error:#{timestamp}) #{log_message}", log_context)
+          ExceptionHandling.logger.fatal("\nExceptionHandlingError (Error:#{timestamp}) #{log_message}", **log_context)
         end
       end
     end
@@ -304,11 +304,11 @@ module ExceptionHandling # never included
     end
 
     def log_info(message, **log_context)
-      ExceptionHandling.logger.info(message, log_context)
+      ExceptionHandling.logger.info(message, **log_context)
     end
 
     def log_debug(message, **log_context)
-      ExceptionHandling.logger.debug(message, log_context)
+      ExceptionHandling.logger.debug(message, **log_context)
     end
 
     def ensure_safe(exception_context = "", **log_context)

data/spec/helpers/exception_helpers.rb

@@ -15,6 +15,6 @@ module ExceptionHelpers
 
   def capture_notifications
     @sent_notifications = []
-    allow(ExceptionHandling).to receive(:send_exception_to_honeybadger).with(anything) { |exception_info| @sent_notifications << exception_info }
+    allow(ExceptionHandling).to receive(:send_exception_to_honeybadger).with(any_args) { |exception_info| @sent_notifications << exception_info }
   end
 end

data/spec/unit/exception_handling/exception_catalog_spec.rb

@@ -41,7 +41,7 @@ module ExceptionHandling
         @exception_catalog = ExceptionCatalog.new(ExceptionHandling.filter_list_filename)
 
         expect(ExceptionHandling).to receive(:log_error).never
-        expect(ExceptionHandling).to receive(:write_exception_to_log).with(anything, "ExceptionCatalog#refresh_filters: ./config/exception_filters.yml", anything)
+        expect(ExceptionHandling).to receive(:write_exception_to_log).with(anything, "ExceptionCatalog#refresh_filters: ./config/exception_filters.yml", any_args)
         expect(@exception_catalog).to receive(:load_file) { raise "noooooo" }
 
         @exception_catalog.find({})

data/spec/unit/exception_handling/methods_spec.rb

@@ -31,7 +31,7 @@ module ExceptionHandling
       it "use the current_controller when available" do
         capture_notifications
 
-        expect(ExceptionHandling.logger).to receive(:fatal).with(/blah/, anything).at_least(:once)
+        expect(ExceptionHandling.logger).to receive(:fatal).with(/blah/, any_args).at_least(:once)
         @controller.simulate_around_filter do
           ExceptionHandling.log_error(ArgumentError.new("blah"))
           expect(sent_notifications.size).to eq(1)

data/spec/unit/exception_handling_spec.rb

@@ -109,8 +109,8 @@ describe ExceptionHandling do
 
   context "with warn and honeybadger notify stubbed" do
     before do
-      allow(ExceptionHandling).to receive(:warn).with(anything)
-      allow(Honeybadger).to receive(:notify).with(anything)
+      allow(ExceptionHandling).to receive(:warn).with(any_args)
+      allow(Honeybadger).to receive(:notify).with(any_args)
     end
 
     context "with logger stashed" do
@@ -372,13 +372,13 @@ describe ExceptionHandling do
 
       context "ExceptionHandling.ensure_safe" do
         it "log an exception with call stack if an exception is raised." do
-          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, anything)
+          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, any_args)
           ExceptionHandling.ensure_safe { raise ArgumentError, "blah" }
         end
 
         if ActionView::VERSION::MAJOR >= 5
           it "log an exception with call stack if an ActionView template exception is raised." do
-            expect(ExceptionHandling.logger).to receive(:fatal).with(/\(Error:\d+\) \nActionView::Template::Error: \(blah\):\n /, anything)
+            expect(ExceptionHandling.logger).to receive(:fatal).with(/\(Error:\d+\) \nActionView::Template::Error: \(blah\):\n /, any_args)
             ExceptionHandling.ensure_safe do
               begin
                 # Rails 5 made the switch from ActionView::TemplateError taking in the original exception
@@ -391,7 +391,7 @@ describe ExceptionHandling do
           end
         else
           it "log an exception with call stack if an ActionView template exception is raised." do
-            expect(ExceptionHandling.logger).to receive(:fatal).with(/\(Error:\d+\) \nActionView::Template::Error: \(blah\):\n /, anything)
+            expect(ExceptionHandling.logger).to receive(:fatal).with(/\(Error:\d+\) \nActionView::Template::Error: \(blah\):\n /, any_args)
             ExceptionHandling.ensure_safe { raise ActionView::TemplateError.new({}, ArgumentError.new("blah")) }
           end
         end
@@ -408,13 +408,13 @@ describe ExceptionHandling do
         end
 
         it "return nil if an exception is raised during an assignment" do
-          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, anything)
+          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, any_args)
           b = ExceptionHandling.ensure_safe { raise ArgumentError, "blah" }
           expect(b).to be_nil
         end
 
         it "allow a message to be appended to the error when logged." do
-          expect(ExceptionHandling.logger).to receive(:fatal).with(/mooo\nArgumentError: \(blah\):\n.*exception_handling_spec\.rb/, anything)
+          expect(ExceptionHandling.logger).to receive(:fatal).with(/mooo\nArgumentError: \(blah\):\n.*exception_handling_spec\.rb/, any_args)
           b = ExceptionHandling.ensure_safe("mooo") { raise ArgumentError, "blah" }
           expect(b).to be_nil
         end
@@ -422,7 +422,7 @@ describe ExceptionHandling do
         it "only rescue StandardError and descendents" do
           expect { ExceptionHandling.ensure_safe("mooo") { raise Exception } }.to raise_exception(Exception)
 
-          expect(ExceptionHandling.logger).to receive(:fatal).with(/mooo\nStandardError: \(blah\):\n.*exception_handling_spec\.rb/, anything)
+          expect(ExceptionHandling.logger).to receive(:fatal).with(/mooo\nStandardError: \(blah\):\n.*exception_handling_spec\.rb/, any_args)
 
           b = ExceptionHandling.ensure_safe("mooo") { raise StandardError, "blah" }
           expect(b).to be_nil
@@ -431,7 +431,7 @@ describe ExceptionHandling do
 
       context "ExceptionHandling.ensure_completely_safe" do
         it "log an exception if an exception is raised." do
-          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, anything)
+          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, any_args)
           ExceptionHandling.ensure_completely_safe { raise ArgumentError, "blah" }
         end
 
@@ -447,19 +447,19 @@ describe ExceptionHandling do
         end
 
         it "return nil if an exception is raised during an assignment" do
-          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, anything) { nil }
+          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, any_args) { nil }
           b = ExceptionHandling.ensure_completely_safe { raise ArgumentError, "blah" }
           expect(b).to be_nil
         end
 
         it "allow a message to be appended to the error when logged." do
-          expect(ExceptionHandling.logger).to receive(:fatal).with(/mooo\nArgumentError: \(blah\):\n.*exception_handling_spec\.rb/, anything)
+          expect(ExceptionHandling.logger).to receive(:fatal).with(/mooo\nArgumentError: \(blah\):\n.*exception_handling_spec\.rb/, any_args)
           b = ExceptionHandling.ensure_completely_safe("mooo") { raise ArgumentError, "blah" }
           expect(b).to be_nil
         end
 
         it "rescue any instance or child of Exception" do
-          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, anything)
+          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, any_args)
           ExceptionHandling.ensure_completely_safe { raise Exception, "blah" }
         end
 
@@ -481,7 +481,7 @@ describe ExceptionHandling do
         end
 
         it "log the exception as usual and send the proper email" do
-          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, anything)
+          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, any_args)
           ExceptionHandling.ensure_escalation("Favorite Feature") { raise ArgumentError, "blah" }
           expect(ActionMailer::Base.deliveries.count).to eq(1)
           expect(sent_notifications.size).to eq(1), sent_notifications.inspect
@@ -516,7 +516,7 @@ describe ExceptionHandling do
 
         it "allow the caller to specify custom recipients" do
           custom_recipients = ['something@invoca.com']
-          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, anything)
+          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, any_args)
           ExceptionHandling.ensure_escalation("Favorite Feature", custom_recipients) { raise ArgumentError, "blah" }
           expect(ActionMailer::Base.deliveries.count).to eq(1)
           expect(sent_notifications.size).to eq(1), sent_notifications.inspect
@@ -532,7 +532,7 @@ describe ExceptionHandling do
       context "ExceptionHandling.ensure_alert" do
         it "log the exception as usual and fire a sensu event" do
           expect(ExceptionHandling::Sensu).to receive(:generate_event).with("Favorite Feature", "test context\nblah")
-          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, anything)
+          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(blah\):\n.*exception_handling_spec\.rb/, any_args)
           ExceptionHandling.ensure_alert('Favorite Feature', 'test context') { raise ArgumentError, "blah" }
         end
 
@@ -544,8 +544,8 @@ describe ExceptionHandling do
 
         it "log if the sensu event could not be sent" do
           expect(ExceptionHandling::Sensu).to receive(:send_event).with(anything) { raise "Failed to send" }
-          expect(ExceptionHandling.logger).to receive(:fatal).with(/first_test_exception/, anything)
-          expect(ExceptionHandling.logger).to receive(:fatal).with(/Failed to send/, anything)
+          expect(ExceptionHandling.logger).to receive(:fatal).with(/first_test_exception/, any_args)
+          expect(ExceptionHandling.logger).to receive(:fatal).with(/Failed to send/, any_args)
           ExceptionHandling.ensure_alert("Not Used", 'test context') { raise ArgumentError, "first_test_exception" }
         end
 
@@ -575,7 +575,7 @@ describe ExceptionHandling do
         it "include the timestamp when the exception is logged" do
           capture_notifications
 
-          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(Error:517033020\) context\nArgumentError: \(blah\):\n.*exception_handling_spec\.rb/, anything)
+          expect(ExceptionHandling.logger).to receive(:fatal).with(/\(Error:517033020\) context\nArgumentError: \(blah\):\n.*exception_handling_spec\.rb/, any_args)
           b = ExceptionHandling.ensure_safe("context") { raise ArgumentError, "blah" }
           expect(b).to be_nil
 
@@ -850,7 +850,7 @@ describe ExceptionHandling do
       allow(ExceptionHandling).to receive(:make_exception) { raise ArgumentError, "Bad argument" }
       expect(ExceptionHandling).to receive(:write_exception_to_log).with(satisfy { |ex| ex.to_s['Bad argument'] },
                                                      satisfy { |context| context['ExceptionHandlingError: log_error rescued exception while logging Runtime message'] },
-                                                     anything)
+                                                     any_args)
       ExceptionHandling.log_error(RuntimeError.new("A runtime error"), "Runtime message")
     end
 
@@ -858,7 +858,7 @@ describe ExceptionHandling do
       expect(ExceptionHandling).to receive(:write_exception_to_log).with(satisfy { |ex| ex.to_s['Bad argument'] },
                                                      satisfy { |context| context['Context message'] },
                                                      anything,
-                                                     anything)
+                                                     any_args)
       ExceptionHandling.log_error(ArgumentError.new("Bad argument"), "Context message") { |_data| raise 'Error!!!' }
     end
 
@@ -963,7 +963,7 @@ describe ExceptionHandling do
       it "omit environment defaults" do
         capture_notifications
 
-        allow(ExceptionHandling).to receive(:send_exception_to_honeybadger).with(anything) { |exception_info| sent_notifications << exception_info }
+        allow(ExceptionHandling).to receive(:send_exception_to_honeybadger).with(any_args) { |exception_info| sent_notifications << exception_info }
 
         ExceptionHandling.log_error("some message") do |data|
           data[:environment] = { SERVER_PORT: '80', SERVER_PROTOCOL: "HTTP/1.0" }
@@ -1052,7 +1052,7 @@ describe ExceptionHandling do
               ActionMailer::Base.deliveries.clear
 
               set_test_const('EventMachine::Protocols::SmtpClient', SmtpClientErrbackStub)
-              expect(ExceptionHandling.logger).to receive(:fatal).with(/Exception to escalate/, anything)
+              expect(ExceptionHandling.logger).to receive(:fatal).with(/Exception to escalate/, any_args)
               expect(ExceptionHandling.logger).to receive(:fatal).with(/Failed to email by SMTP: "credential mismatch"/)
 
               ExceptionHandling.ensure_escalation("ensure message") { raise 'Exception to escalate!' }
@@ -1064,7 +1064,7 @@ describe ExceptionHandling do
               expect((SmtpClientErrbackStub.send_hash & EXPECTED_SMTP_HASH.keys).map_hash { |_k, v| v.to_s }).to eq(EXPECTED_SMTP_HASH), SmtpClientErrbackStub.send_hash.inspect            end
 
             it "log fatal on EventMachine dns resolver errback" do
-              expect(ExceptionHandling.logger).to receive(:fatal).with(/Exception to escalate/, anything)
+              expect(ExceptionHandling.logger).to receive(:fatal).with(/Exception to escalate/, any_args)
               expect(ExceptionHandling.logger).to receive(:fatal).with(/Failed to resolv DNS for localhost: "softlayer sucks"/)
 
               ExceptionHandling.ensure_escalation("ensure message") { raise 'Exception to escalate!' }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: exception_handling
 version: !ruby/object:Gem::Version
-  version: 2.11.1
+  version: 2.11.2
 platform: ruby
 authors:
 - Invoca