excellent 1.7.0 → 1.7.1

data/History.txt

@@ -1,4 +1,9 @@
 =======
+= 1.7.1
+
+* fixed excellent for Ruby 2.0
+* some internal cleanup
+
 = 1.7.0
 
 * fixed issue #24

data/bin/excellent

@@ -15,12 +15,16 @@ optparse = OptionParser.new do |opt|
     puts optparse
     exit
   end
+  opt.on_tail('--version', '-v', 'Version') do
+    puts Simplabs::Excellent::VERSION
+    exit
+  end
 end
 
 optparse.parse!
 
-target   = options[:output]
-paths    = ARGV.dup
+target = options[:output]
+paths  = ARGV.dup
 
 if paths.empty?
   puts "\n  You must specify one or more directories to analyse, e.g.:\n"

data/lib/simplabs/excellent/checks/rails/instance_var_in_partial_check.rb

@@ -23,7 +23,7 @@ module Simplabs
           end
 
           def evaluate(context) #:nodoc:
-            add_warning(context, 'Instance variable {{variable}} used in partial.', { :variable => context.full_name }, RUBY_VERSION =~ /1\.9/ ? -1 : 0)
+            add_warning(context, 'Instance variable {{variable}} used in partial.', { :variable => context.full_name }, RUBY_VERSION =~ /1\.8/ ? 0 : -1)
           end
 
         end

data/lib/simplabs/excellent/checks/rails/params_hash_in_view_check.rb

@@ -24,7 +24,7 @@ module Simplabs
           end
 
           def evaluate(context) #:nodoc:
-            add_warning(context, 'Params hash used in view.', {}, RUBY_VERSION =~ /1\.9/ ? -1 : 0) if (context.full_name == 'params')
+            add_warning(context, 'Params hash used in view.', {}, RUBY_VERSION =~ /1\.8/ ? 0 : -1) if (context.full_name == 'params')
           end
 
         end

data/lib/simplabs/excellent/checks/rails/session_hash_in_view_check.rb

@@ -24,7 +24,7 @@ module Simplabs
           end
 
           def evaluate(context) #:nodoc:
-            add_warning(context, 'Session hash used in view.', {}, RUBY_VERSION =~ /1\.9/ ? -1 : 0) if (context.full_name == 'session')
+            add_warning(context, 'Session hash used in view.', {}, RUBY_VERSION =~ /1\.8/ ? 0 : -1) if (context.full_name == 'session')
           end
 
         end

data/lib/simplabs/excellent/parsing/parser.rb

@@ -19,7 +19,7 @@ module Simplabs
         private
 
           def silent_parse(content, filename)
-            @parser ||= RubyParser.for_current_ruby
+            @parser ||= RUBY_VERSION =~ /2\.0/ ? Ruby19Parser.new : RubyParser.for_current_ruby
             content = ::ERB.new(content, nil, '-').src if filename =~ /\.erb$/
             sexp = @parser.parse(content, filename)
             sexp

data/lib/simplabs/excellent.rb

@@ -9,7 +9,7 @@ module Simplabs #:nodoc:
 
   module Excellent #:nodoc:
 
-    VERSION = '1.5.1'
+    VERSION = '1.7.1'
 
   end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: excellent
 version: !ruby/object:Gem::Version 
-  hash: 11
+  hash: 9
   prerelease: 
   segments: 
   - 1
   - 7
-  - 0
-  version: 1.7.0
+  - 1
+  version: 1.7.1
 platform: ruby
 authors: 
 - Marco Otte-Witte
@@ -95,7 +95,6 @@ files:
 - lib/simplabs/excellent/checks/rails.rb
 - lib/simplabs/excellent/checks/singleton_variable_check.rb
 - lib/simplabs/excellent/checks.rb
-- lib/simplabs/excellent/command_line_runner.rb
 - lib/simplabs/excellent/extensions/sexp.rb
 - lib/simplabs/excellent/extensions/string.rb
 - lib/simplabs/excellent/formatters/base.rb

data/lib/simplabs/excellent/command_line_runner.rb

@@ -1,37 +0,0 @@
-require 'simplabs/excellent/runner'
-require 'simplabs/excellent/formatters'
-
-module Simplabs
-
-  module Excellent
-
-    class CommandLineRunner < Runner #:nodoc:
-
-      def initialize(*checks)
-        super
-        @formatter = Formatters::Text.new
-        @formatter.start
-      end
-
-      def check_paths(paths)
-        paths.each do |path|
-          if File.file?(path)
-            check_file(path)
-          elsif File.directory?(path)
-            Dir.glob(File.join(path, '**/*.rb')).each { |file| check_file(file) }
-          else
-            next
-          end
-        end
-      end
-
-      def check_file(filename)
-        super
-        @formatter.file(filename, (@checks || []).collect { |check| check.warnings }.flatten)
-      end
-
-    end
-
-  end
-
-end