excel-esv 3.1.0 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bb907e9f6b481001f01561df298d6052f3efb37f4ae3f57191b2bb807699203e
-  data.tar.gz: ea18830fa510acd5fe6d204714fbfc75114c0e167d08bd3fa969b61406893bf2
+  metadata.gz: d46877da5cc1642f15c16ed055a62a15656ff495eb5d3854a606134668f988df
+  data.tar.gz: 46c7e0920178b82d593a6a1d1dfef31d929a914ef22ed4ea23efd5a675526eba
 SHA512:
-  metadata.gz: 745103dd2cbf9eda28e2d2947f4785b6a3f95372be9c3044265029cb4ac2e01c16d943923cb6e3f677387b2dfc6b5cbaba6bfddab001c0e775c97a92e967870b
-  data.tar.gz: e22bb76f26d291021847496fd679f6f982c4ecd14f0e9978674f08607f90d848b9539d5931d0a1ae038af8c22a8254814e69198af1802f755960e2fc0394ece4
+  metadata.gz: 7dcd7941790d2a1082105f03eb7813b62a91dce96a5624fb124b0819431f7c6261e8e848a78fffd0ac03759bd3bbc8697d32fd05bba9463842fff2e07c445a27
+  data.tar.gz: a279ac0df840b36fbb719c3e210696bf6c261e80e80970d9d2accdfa0fea4b5e592542da1cbbb86dbf4d1531266c18294c1726f99c16da872b575edf41c5f399

data/.github/workflows/ci.yml

@@ -22,7 +22,7 @@ jobs:
         ruby-version: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
         
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v7
       - name: Set up Ruby ${{ matrix.ruby-version }}
         uses: ruby/setup-ruby@v1
         with:

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 3.3.0 (Aug 28, 2026)
+
+* Fix Numbers.app misrendering by formatting date cells as ISO 8601 ("2026-08-28") and time cells as ISO-like ("2026-08-28 13:45").
+
+## 3.2.0 (Nov 12, 2025)
+
+* Support `worksheet_index:` in `.parse_file`, too.
+
 ## 3.1.0 (Nov 12, 2025)
 
 * Support specifying worksheet index when there are multiple: `ESV.parse(data, worksheet_index: 0)`.

data/README.md

@@ -80,9 +80,7 @@ output = ESV.parse_file("/tmp/test.xls")
 # => [ [ "Name", "Dogs", … ], … ]
 ```
 
-This assumes a file with a single worksheet and will raise otherwise.
-
-Also supports `header_converters:`.
+This is a thin wrapper around `ESV.parse` and takes the same arguments.
 
 ### Generate in Ruby on Rails
 

data/excel-esv.gemspec

@@ -12,10 +12,11 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/barsoom/excel-esv"
   spec.license       = "MIT"
   spec.metadata      = { "rubygems_mfa_required" => "true" }
+  spec.required_ruby_version = ">= 3.1.0"
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.require_paths = [ "lib" ]
 
-  spec.add_runtime_dependency "spreadsheet"
   spec.add_runtime_dependency "logger"
+  spec.add_runtime_dependency "spreadsheet"
 end

data/lib/esv/generator.rb

@@ -1,4 +1,10 @@
 class ESV::Generator
+  # The spreadsheet gem otherwise formats date and time cells as "DD.MM.YYYY".
+  # Excel reads that case-insensitively, but Numbers.app only recognises the "MM", so it renders e.g. "DD.06.YYYY". Lowercase "dd" and "yyyy" work in both.
+  # "hh" is confirmed to render as 24-hour time in Numbers.app.
+  DATE_FORMAT = "yyyy-MM-dd"
+  DATE_TIME_FORMAT = "yyyy-MM-dd hh:mm:ss"
+
   def initialize
     @data_rows = []
   end
@@ -14,6 +20,7 @@ class ESV::Generator
     @data_rows.each_with_index do |data_row, index|
       row = sheet.row(index)
       row.push(*data_row)
+      format_dates_and_times(row, data_row)
     end
 
     content = ""
@@ -21,4 +28,23 @@ class ESV::Generator
     book.write(fake_file)
     content
   end
+
+  private
+
+  def format_dates_and_times(row, data_row)
+    data_row.each_with_index do |value, index|
+      format =
+        case value
+        # DateTime is a Date, so it has to be matched first.
+        # Rails' `ActiveSupport::TimeWithZone` is matched by `when Time` since ActiveSupport patches `Time.===`.
+        when DateTime, Time then date_time_format
+        when Date then date_format
+        end
+
+      row.set_format(index, format) if format
+    end
+  end
+
+  def date_format = @date_format ||= Spreadsheet::Format.new(number_format: DATE_FORMAT)
+  def date_time_format = @date_time_format ||= Spreadsheet::Format.new(number_format: DATE_TIME_FORMAT)
 end

data/lib/esv/rails_controller.rb

@@ -10,7 +10,7 @@ module ESV
         data,
         type: ESV::CONTENT_TYPE,
         disposition: "attachment",
-        filename: filename,
+        filename:,
       )
     end
   end

data/lib/esv/version.rb

@@ -1,3 +1,3 @@
 module ESV
-  VERSION = "3.1.0"
+  VERSION = "3.3.0"
 end

data/lib/esv.rb

@@ -87,7 +87,7 @@ module ESV
     }
   end
 
-  def self.parse_file(path, header_converters: nil)
-    parse(File.read(path), header_converters: header_converters)
+  def self.parse_file(path, header_converters: nil, worksheet_index: nil)
+    parse(File.read(path), header_converters:, worksheet_index:)
   end
 end

data/spec/esv_spec.rb

@@ -15,6 +15,44 @@ RSpec.describe ESV do
         [ 1, 2 ],
       ]
     end
+
+    it "keeps date and time cells readable as such, rather than as text" do
+      data = ESV.generate do |esv|
+        esv << [ Date.new(2026, 6, 24), DateTime.new(2026, 6, 24, 13, 30, 5) ]
+      end
+
+      expect(ESV.parse(data)).to eq([ [ Date.new(2026, 6, 24), DateTime.new(2026, 6, 24, 13, 30, 5) ] ])
+    end
+
+    it "reads a Time back as a DateTime" do
+      data = ESV.generate { |esv| esv << [ Time.utc(2026, 6, 24, 13, 30, 5) ] }
+
+      expect(ESV.parse(data)).to eq([ [ DateTime.new(2026, 6, 24, 13, 30, 5) ] ])
+    end
+  end
+
+  describe ".generate" do
+    it "formats date and time cells so that both Excel and Numbers.app render them" do
+      data = ESV.generate do |esv|
+        esv << [ Date.new(2026, 6, 24), Time.utc(2026, 6, 24, 13, 30), DateTime.new(2026, 6, 24, 13, 30), "Dogs", 1 ]
+      end
+
+      expect(number_formats_in(data)).to eq([
+        "yyyy-MM-dd",
+        "yyyy-MM-dd hh:mm:ss",
+        "yyyy-MM-dd hh:mm:ss",
+        "GENERAL",
+        "GENERAL",
+      ])
+    end
+
+    private
+
+    def number_formats_in(data)
+      row = Spreadsheet.open(StringIO.new(data)).worksheet(0).row(0)
+
+      row.each_with_index.map { |_value, index| row.format(index).number_format }
+    end
   end
 
   describe "::HEADER_CONVERTERS" do
@@ -77,10 +115,10 @@ RSpec.describe ESV do
 
         it "allows specifying a worksheet index" do
           output = ESV.parse(excel_file_with_two_worksheets, worksheet_index: 0)
-          expect(output).to eq [[ "I am worksheet 0" ]]
+          expect(output).to eq [ [ "I am worksheet 0" ] ]
 
           output = ESV.parse(excel_file_with_two_worksheets, worksheet_index: 1)
-          expect(output).to eq [[ "I am worksheet 1" ]]
+          expect(output).to eq [ [ "I am worksheet 1" ] ]
         end
       end
     end
@@ -208,7 +246,7 @@ RSpec.describe ESV do
         esv << [ 1, 2 ]
       end
 
-      output = ESV.parse_file(path)
+      output = ESV.parse_file(path, worksheet_index: 0)
 
       expect(output).to eq [
         [ "Dogs", "Cats" ],

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: excel-esv
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.3.0
 platform: ruby
 authors:
 - Henrik Nyh
@@ -10,7 +10,7 @@ cert_chain: []
 date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: spreadsheet
+  name: logger
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -24,7 +24,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: logger
+  name: spreadsheet
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -73,14 +73,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 3.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.9
 specification_version: 4
 summary: Excel parsing and generation with the ease of CSV.
 test_files: []