excel-esv 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7f43f1221f2eb2bc5484f74786339827acb6c95b
-  data.tar.gz: 6180ee4ddd35c35e5d4149c61f3138d4b207f271
+  metadata.gz: 497175de91508cfae61cef9c418d19368fe40db9
+  data.tar.gz: c9b36a3fb2bb4ed670eff42935cd0a49f169bc40
 SHA512:
-  metadata.gz: ece4fd3a10785678c758c99cbf3a24441b267e0d76bb56639cf811900440b3d0a00ec98272d17b3283496e8ca8b2bff35050f1f21916d2ff71758cf02918ac40
-  data.tar.gz: 062d7892b8ff824ffef79341f4fd07d188e62b1cdb092d87e55ce0c59cfeb083d80dcbcf483ef6e12a07138dc36535fcf6d2ccaf2cebbb06406ec5c55511b802
+  metadata.gz: 5f50059616af9ab743c24c7e9baf3b13c32d1b6203c8c300a4bced7d16e389438889f446af0c1f71f7295afd55d05c609ee46527f7307ced5cc750521044e444
+  data.tar.gz: 30e21e0646c7cf9f34850656069bdae2bc27b6db433ff665e77ef3f19947b316a7cd0a2cda74f21b1df4ab57686e8ea972920b911830817a20d711328d1ad85a

data/README.md

@@ -11,7 +11,9 @@ CSVs can be difficult to open correctly, e.g. in Excel on Mac.
 
 ### Generate
 
-```
+``` ruby
+require "esv"
+
 data = ESV.generate do |esv|
   esv << [ "Name", "Dogs", "Cats" ]
   esv << [ "Victor", 1, 4 ]
@@ -22,24 +24,28 @@ File.write("/tmp/test.xls", data)
 
 ### Parse
 
-```
-excel = File.read("/tmp/test.xls")
+``` ruby
+require "esv"
+
+data = File.read("/tmp/test.xls")
 output = ESV.parse(data)  # => [ [ "Name", "Dogs", … ], … ]
 ```
 
+This assumes a file with a single worksheet and will raise otherwise.
+
 ### Generate in Ruby on Rails
 
 In `config/initializers/mime_types.rb`:
 
-```
+``` ruby
 Mime::Type.register ESV::MIME_TYPE, "xls"
 ```
 
 As a model or whatever you prefer:
 
-```
+``` ruby
 class MyExcelDocument
-  def generate(name)
+  def self.generate(name)
     ESV.generate { |esv| esv << [ "Hello #{name}" ] }
   end
 end
@@ -47,12 +53,12 @@ end
 
 Controller:
 
-```
+``` ruby
 class MyController < ApplicationController
   include ESV::RailsController  # for send_excel
 
   def show
-    data = MyExcelDocument.new("Rails").generate
+    data = MyExcelDocument.generate("Rails")
     send_excel(data)
   end
 
@@ -70,7 +76,7 @@ end
 
 Add this line to your application's Gemfile:
 
-```ruby
+``` ruby
 gem 'excel-esv'
 ```
 

data/lib/esv/version.rb

@@ -1,3 +1,3 @@
 module ESV
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/esv.rb

@@ -13,6 +13,12 @@ module ESV
   def self.parse(data)
     fake_file = StringIO.new(data)
     book = Spreadsheet.open(fake_file)
+
+    # We could support multiple worksheets, but let's not until we actually need it.
+    # Until then, we prefer raising to silently ignoring worksheets.
+    worksheet_count = book.worksheets.length
+    raise "Expected 1 worksheet, found #{worksheet_count}." if worksheet_count > 1
+
     book.worksheet(0).to_a
   end
 end

data/spec/esv_spec.rb

@@ -15,3 +15,24 @@ describe ESV, ".generate and .parse" do
     ]
   end
 end
+
+describe ESV, ".parse" do
+  it "raises if there's more than one worksheet" do
+    expect {
+      ESV.parse(excel_file_with_two_worksheets)
+    }.to raise_error(/Expected 1 worksheet, found 2/)
+  end
+
+  private
+
+  def excel_file_with_two_worksheets
+    book = Spreadsheet::Workbook.new
+    book.create_worksheet
+    book.create_worksheet
+
+    data = ""
+    fake_file = StringIO.new(data)
+    book.write(fake_file)
+    data
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: excel-esv
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Henrik Nyh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-02 00:00:00.000000000 Z
+date: 2015-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: spreadsheet