examiner 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 47e2a6a62cf3492f80d7e9e1e6025c2efea11e49
-  data.tar.gz: 8f06bf636a2da099d282209e5e018069d13684bc
+  metadata.gz: f1799a2bafa8549f65627403149d87d4cc005a61
+  data.tar.gz: 40684b52306eb976819c05daf9bb6e73e82ceb05
 SHA512:
-  metadata.gz: ad52fa7af0abfadcd4ea88bd9f3c4f9352b72362e2925db404362d79f3416100f67c21de99360f735e73d8275a0e345fc4ac7bed1817effea34772a9d8915391
-  data.tar.gz: 8fa1fd9f36692ed873f77ab693ebcc49855649a6237ab61250b04e828fce137dff06856cc8140882e71b12ade06ce5abebb70391d2bb995524c11e0d8086e4e9
+  metadata.gz: 6c656506f027cc09729c0980a1710012f9f72a26bcfee10b5713a1da0984fbfe214582cb0cb3168b1c9b708cc3b8fea5e021e67b8d92df0d54dd465c7a7bdd04
+  data.tar.gz: 70d1c3ef7792ed8398527c4e22eb4e1a5884ed355d191006277c9393597f34c588eeb82bd5cff91a1af2bf7872ae3e823375c1bab5fade2b9862f6706fcc6087

data/README.md

@@ -3,11 +3,9 @@
 
 # Examiner
 
-Grade a student's exercise solution.
+Grade a student's exercise solution, assuming:
 
-Assumptions:
-
-- The exercise uses [minitest](https://github.com/seattlerb/minitest) to be checkied
+- The exercise uses [minitest](https://github.com/seattlerb/minitest) to be checked
 - There is a `Rakefile` in the exercise folder
 
 ## Installation
@@ -20,7 +18,9 @@ gem 'examiner'
 
 And then execute:
 
-    $ bundle
+```bash
+$ bundle
+```
 
 ## Usage
 
@@ -31,9 +31,13 @@ the following code.
 exercise_directory = "/path/to/student_exercise_with_rakefile"
 
 runner = Examiner::RakeRunner.new
-runner.run exercise_directory
-if runner.success?
+begin
+  runner.run exercise_directory
   puts "Results: #{runner.tests - runner.failures}/#{runner.tests}"
+rescue Examiner::RakefileMissingError => e
+  puts "Folder does not have any Rakefile"
+rescue Examiner::MissingDefaultRakeTaskError => e
+  puts "Could not launch tests with 'rake'"
 end
 
 # You can display stdout and stderr

data/examiner.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["seb@saunier.me"]
   spec.summary       = %q{Grade a student's exercise solution using rake and minitest}
   spec.description   = spec.summary
-  spec.homepage      = ""
+  spec.homepage      = "http://github.com/ssaunier/examiner"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files -z`.split("\x0")
@@ -18,6 +18,6 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.6"
+  spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake"
 end

data/lib/examiner/minitest_parser.rb

@@ -22,6 +22,13 @@ module Examiner
       end
     end
 
+    def default_rake?(lines)
+      lines.reverse_each.each do |line|
+        return false if /Don't know how to build task 'default'/.match line
+      end
+      true
+    end
+
     def success?
       @success
     end

data/lib/examiner/rake_runner.rb

@@ -2,6 +2,9 @@ require 'open3'
 require_relative 'minitest_parser'
 
 module Examiner
+  class RakefileMissingError < StandardError; end
+  class MissingDefaultRakeTaskError < StandardError; end
+
   class RakeRunner
     attr_reader :stdout_lines, :stderr_lines
     attr_reader :tests, :failures
@@ -13,27 +16,29 @@ module Examiner
     end
 
     def run(directory)
-      return unless rakefile?(directory)
+      raise RakefileMissingError.new(directory) unless rakefile?(directory)
 
       Open3.popen3('rake', chdir: directory) do |_, stdout, stderr, wait_thr|
-        @stdout_lines, @stderr_lines = stdout.readlines, stderr_lines
+        @stdout_lines, @stderr_lines = stdout.readlines, stderr.readlines
+        parse_stderr(directory)
         parse_stdout
       end
     end
 
-    def success?
-      @success
-    end
-
     private
 
+      def parse_stderr(directory)
+        unless MinitestParser.new.default_rake?(@stderr_lines)
+          raise MissingDefaultRakeTaskError.new(directory)
+        end
+      end
+
       def parse_stdout
         parser = MinitestParser.new
         parser.parse @stdout_lines
         if parser.success?
           @tests = parser.tests
           @failures = parser.failures
-          @success = true
         end
       end
 

data/lib/examiner/version.rb

@@ -1,3 +1,3 @@
 module Examiner
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/examiner/rake_runner_spec.rb

@@ -6,13 +6,11 @@ module Exmanier
     let(:runner) { Examiner::RakeRunner.new }
 
     it "should handle a folder without Rakefile" do
-      runner.run directory("no_rake_file")
-      runner.success?.must_equal false
+      lambda { runner.run directory("no_rake_file") }.must_raise Examiner::RakefileMissingError
     end
 
     it "should be successful for 1_test_0_failure use case" do
       runner.run directory("1_test_0_failure")
-      runner.success?.must_equal true
       runner.tests.must_equal 1
       runner.failures.must_equal 0
       runner.stdout_lines.wont_be_empty
@@ -21,7 +19,6 @@ module Exmanier
 
     it "should be successful for 2_tests_1_failure use case" do
       runner.run directory("2_tests_1_failure")
-      runner.success?.must_equal true
       runner.tests.must_equal 2
       runner.failures.must_equal 1
       runner.stdout_lines.wont_be_empty
@@ -30,7 +27,13 @@ module Exmanier
 
     it "should handle a file with syntax errors" do
       runner.run directory("syntax_error")
-      runner.success?.must_equal false
+      runner.stderr_lines.wont_be_empty
+      runner.tests.must_equal 0
+      runner.failures.must_equal 0
+    end
+
+    it "should handle a folder with an empty rakefile" do
+      lambda { runner.run directory("empty_rakefile") }.must_raise Examiner::MissingDefaultRakeTaskError
     end
 
     def directory(name)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: examiner
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Sebastien Saunier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-27 00:00:00.000000000 Z
+date: 2014-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -61,8 +61,9 @@ files:
 - spec/spec_helper.rb
 - spec/support/1_test_0_failure/Rakefile
 - spec/support/2_tests_1_failure/Rakefile
+- spec/support/empty_rakefile/Rakefile
 - spec/support/syntax_error/Rakefile
-homepage: ''
+homepage: http://github.com/ssaunier/examiner
 licenses:
 - MIT
 metadata: {}
@@ -92,4 +93,5 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/1_test_0_failure/Rakefile
 - spec/support/2_tests_1_failure/Rakefile
+- spec/support/empty_rakefile/Rakefile
 - spec/support/syntax_error/Rakefile