exacto_subscriber 0.2.1 → 0.2.2

data/Rakefile

@@ -13,8 +13,9 @@ begin
     gem.add_dependency "configatron", ">= 2.6.3"
     gem.add_dependency "nokogiri", ">= 1.3.3"
     gem.add_dependency "httparty", ">= 0.6.1"
-    gem.add_development_dependency "rspec", ">= 1.3.0"
+    gem.add_development_dependency "rspec", ">= 1.3.1"
     gem.add_development_dependency "fakeweb", "1.2.8"
+    gem.add_development_dependency "mocha", "0.9.10"
     gem.add_development_dependency "vcr", "1.0.3"
     # gem is a Gem::Specification... see http://www.rubygems.org/read/chapter/20 for additional settings
   end

data/VERSION

@@ -1 +1 @@
-0.2.1
+0.2.2

data/exacto_subscriber.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{exacto_subscriber}
-  s.version = "0.2.1"
+  s.version = "0.2.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Dan Pickett"]
-  s.date = %q{2010-09-24}
+  s.date = %q{2010-12-13}
   s.description = %q{Manage Exact Target List subscribers: more coming}
   s.email = %q{dpickett@enlightsolutions.com}
   s.extra_rdoc_files = [
@@ -32,6 +32,7 @@ Gem::Specification.new do |s|
      "lib/exacto_subscriber/ext/hacked_request.rb",
      "lib/exacto_subscriber/list_unsubscription.rb",
      "lib/exacto_subscriber/master_list_unsubscription.rb",
+     "lib/exacto_subscriber/response_error.rb",
      "lib/exacto_subscriber/subscriber.rb",
      "lib/exacto_subscriber/unsubscription.rb",
      "spec/cassettes/list_unsubscriptions/find.yml",
@@ -46,6 +47,8 @@ Gem::Specification.new do |s|
      "spec/exacto_subscriber/subcriber_spec.rb",
      "spec/exacto_subscriber/unsubscription_spec.rb",
      "spec/exacto_subscriber_spec.rb",
+     "spec/mock_responses/blank_response.xml",
+     "spec/mock_responses/exact_target_supplied_response_error.xml",
      "spec/spec.opts",
      "spec/spec_helper.rb"
   ]
@@ -71,23 +74,26 @@ Gem::Specification.new do |s|
       s.add_runtime_dependency(%q<configatron>, [">= 2.6.3"])
       s.add_runtime_dependency(%q<nokogiri>, [">= 1.3.3"])
       s.add_runtime_dependency(%q<httparty>, [">= 0.6.1"])
-      s.add_development_dependency(%q<rspec>, [">= 1.3.0"])
+      s.add_development_dependency(%q<rspec>, [">= 1.3.1"])
       s.add_development_dependency(%q<fakeweb>, ["= 1.2.8"])
+      s.add_development_dependency(%q<mocha>, ["= 0.9.10"])
       s.add_development_dependency(%q<vcr>, ["= 1.0.3"])
     else
       s.add_dependency(%q<configatron>, [">= 2.6.3"])
       s.add_dependency(%q<nokogiri>, [">= 1.3.3"])
       s.add_dependency(%q<httparty>, [">= 0.6.1"])
-      s.add_dependency(%q<rspec>, [">= 1.3.0"])
+      s.add_dependency(%q<rspec>, [">= 1.3.1"])
       s.add_dependency(%q<fakeweb>, ["= 1.2.8"])
+      s.add_dependency(%q<mocha>, ["= 0.9.10"])
       s.add_dependency(%q<vcr>, ["= 1.0.3"])
     end
   else
     s.add_dependency(%q<configatron>, [">= 2.6.3"])
     s.add_dependency(%q<nokogiri>, [">= 1.3.3"])
     s.add_dependency(%q<httparty>, [">= 0.6.1"])
-    s.add_dependency(%q<rspec>, [">= 1.3.0"])
+    s.add_dependency(%q<rspec>, [">= 1.3.1"])
     s.add_dependency(%q<fakeweb>, ["= 1.2.8"])
+    s.add_dependency(%q<mocha>, ["= 0.9.10"])
     s.add_dependency(%q<vcr>, ["= 1.0.3"])
   end
 end

data/lib/exacto_subscriber.rb

@@ -32,6 +32,7 @@ end
 require "exacto_subscriber/ext/hacked_request"
 
 require "exacto_subscriber/error"
+require "exacto_subscriber/response_error"
 require "exacto_subscriber/base"
 
 require "exacto_subscriber/subscriber"

data/lib/exacto_subscriber/base.rb

@@ -31,7 +31,11 @@ module Exacto
     end
     
     def self.parse_response(response)
-      raise_errors_for(response["exacttarget"]["system"][self.request_system_name])
+      if response["exacttarget"] && response["exacttarget"]["system"]
+        raise_errors_for(response["exacttarget"]["system"][self.request_system_name])
+      else
+        raise Exacto::ResponseError.new(response.body)
+      end
       trimmed_response = trim_response(response)
 
       trimmed_response = trimmed_response[self.response_system_name] if trimmed_response

data/lib/exacto_subscriber/response_error.rb

@@ -0,0 +1,7 @@
+module Exacto
+  class ResponseError < Exception
+    def initialize(response)
+      super("Exacto Response Error: #{response.nil? || response == "" ? "response was blank" : response}")
+    end
+  end
+end

data/spec/cassettes/master_list_unsubscriptions/find_existing.yml

@@ -18,20 +18,14 @@
       code: 200
       message: OK
     headers: 
-      x-powered-by: 
-      - ASP.NET
-      x-aspnet-version: 
-      - 2.0.50727
       connection: 
       - close
       content-type: 
       - text/xml; charset=utf-8
-      server: 
-      - Microsoft-IIS/6.0
       date: 
-      - Fri, 24 Sep 2010 21:25:33 GMT
+      - Mon, 13 Dec 2010 16:51:18 GMT
       set-cookie: 
-      - ASP.NET_SessionId=5ipxh5qn4lwj0m55u0vqzkur; path=/; HttpOnly
+      - ASP.NET_SessionId=cbwibcem2octoikdvhsnzoas; path=/; HttpOnly
       cache-control: 
       - private
       transfer-encoding: 

data/spec/cassettes/master_list_unsubscriptions/find_nonexistent.yml

@@ -18,20 +18,14 @@
       code: 200
       message: OK
     headers: 
-      x-powered-by: 
-      - ASP.NET
-      x-aspnet-version: 
-      - 2.0.50727
       connection: 
       - close
       content-type: 
       - text/xml; charset=utf-8
-      server: 
-      - Microsoft-IIS/6.0
       date: 
-      - Fri, 24 Sep 2010 21:25:38 GMT
+      - Mon, 13 Dec 2010 16:51:20 GMT
       set-cookie: 
-      - ASP.NET_SessionId=u5u1y345kopugn45n4rsmze0; path=/; HttpOnly
+      - ASP.NET_SessionId=takoq0nzexfogma4dewdbzn2; path=/; HttpOnly
       cache-control: 
       - private
       transfer-encoding: 

data/spec/exacto_subscriber/subcriber_spec.rb

@@ -77,4 +77,24 @@ describe Exacto::Subscriber do
     its(:subscriber_id) { should_not be_nil }
   end
   
+  describe "error conditions" do
+    it 'should raise an exacto error if Exact Target returns an error' do
+      fake_response(:post, "https://www.exacttarget.com/api/integrate.asp?qf=xml", 
+        read_mock_response("exact_target_supplied_response_error"))
+      lambda { subject.subscribe_to(list_id) }.should raise_error(Exacto::Error)
+    end
+    it "should raise a response error if Exact Target does not return an intended response" do
+      fake_response(:post, "https://www.exacttarget.com/api/integrate.asp?qf=xml",
+        read_mock_response("blank_response"))
+    end
+  end  
+  
+  def fake_response(method, uri, body)
+    FakeWeb.register_uri(method, uri, :body => body, :content_type => "text/xml")
+  end
+  
+  MOCK_RESPONSE_DIR = File.join(File.dirname(__FILE__), "../mock_responses")
+  def read_mock_response(base_file_name)
+    File.read(File.join(MOCK_RESPONSE_DIR, "#{base_file_name}.xml"))
+  end
 end

data/spec/mock_responses/exact_target_supplied_response_error.xml

@@ -0,0 +1,5 @@
+<?xml version='1.0'?>
+<exacttarget>
+<system>
+<subscriber><error>1</error><error_description>Subscriber not found with ListID = 324123415 Email Address = user3@example.com</error_description></subscriber></system>
+</exacttarget>

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: exacto_subscriber
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 19
   prerelease: false
   segments: 
   - 0
   - 2
-  - 1
-  version: 0.2.1
+  - 2
+  version: 0.2.2
 platform: ruby
 authors: 
 - Dan Pickett
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-09-24 00:00:00 -04:00
+date: 2010-12-13 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -74,12 +74,12 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 27
+        hash: 25
         segments: 
         - 1
         - 3
-        - 0
-        version: 1.3.0
+        - 1
+        version: 1.3.1
   type: :development
   version_requirements: *id004
 - !ruby/object:Gem::Dependency 
@@ -99,9 +99,25 @@ dependencies:
   type: :development
   version_requirements: *id005
 - !ruby/object:Gem::Dependency 
-  name: vcr
+  name: mocha
   prerelease: false
   requirement: &id006 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - "="
+      - !ruby/object:Gem::Version 
+        hash: 47
+        segments: 
+        - 0
+        - 9
+        - 10
+        version: 0.9.10
+  type: :development
+  version_requirements: *id006
+- !ruby/object:Gem::Dependency 
+  name: vcr
+  prerelease: false
+  requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
@@ -113,7 +129,7 @@ dependencies:
         - 3
         version: 1.0.3
   type: :development
-  version_requirements: *id006
+  version_requirements: *id007
 description: "Manage Exact Target List subscribers: more coming"
 email: dpickett@enlightsolutions.com
 executables: []
@@ -139,6 +155,7 @@ files:
 - lib/exacto_subscriber/ext/hacked_request.rb
 - lib/exacto_subscriber/list_unsubscription.rb
 - lib/exacto_subscriber/master_list_unsubscription.rb
+- lib/exacto_subscriber/response_error.rb
 - lib/exacto_subscriber/subscriber.rb
 - lib/exacto_subscriber/unsubscription.rb
 - spec/cassettes/list_unsubscriptions/find.yml
@@ -153,6 +170,8 @@ files:
 - spec/exacto_subscriber/subcriber_spec.rb
 - spec/exacto_subscriber/unsubscription_spec.rb
 - spec/exacto_subscriber_spec.rb
+- spec/mock_responses/blank_response.xml
+- spec/mock_responses/exact_target_supplied_response_error.xml
 - spec/spec.opts
 - spec/spec_helper.rb
 has_rdoc: true