exact_target_sdk 0.0.1 → 0.0.2

data/CHANGELOG.rdoc

@@ -1,5 +1,15 @@
 = ExactTarget SDK
 
+== Version 0.0.2
+* Adding thorough unit tests throughout
+* Using ActiveModel::Callbacks instead of home-baked before_validation
+* Adding UnknownError class to handle all unexpected exceptions
+* Fixing bug where properties that were simple strings or numbers were not rendered properly
+
+== Version 0.0.1
+* Fixing improperly tested bugs limiting basic functionality
+* Adding to README
+
 == Version 0.0.0
 * Initial release
 * Supports Create method

data/lib/exact_target_sdk/api_object.rb

@@ -9,6 +9,7 @@ module ExactTargetSDK
 class APIObject
 
   include ::ActiveModel::Validations
+  include ::ActiveModel::Validations::Callbacks
 
   class << self
 
@@ -63,22 +64,11 @@ class APIObject
       validates name.to_sym, :numericality => { :allow_nil => true, :only_integer => true }
     end
 
-    # Takes one or more method names as symbols, and executes them in order
-    # before validation occurs on this object.
-    def before_validation(*args)
-      before_validation_methods.concat(args)
-    end
-
     # Returns an array of all registered properties.
     def properties
       @properties || []
     end
 
-    # Returns the method names declared using #before_validation.
-    def before_validation_methods
-      @before_validation_methods ||= []
-    end
-
     private
 
     # Stores the given property name to be used at render time.
@@ -108,11 +98,10 @@ class APIObject
 
   # By default, runs validation and executes #render_properties!.
   #
-  # If overridden, the child class should execute the before_validation
-  # methods, check wehter or not the object is valid, and then render
-  # the object.
+  # If overridden, the child class should check wehter or not the
+  # object is valid, and then render the object. In general,
+  # the render_properties! method should be overridden instead.
   def render!(xml)
-    self.class.before_validation_methods.each { |method| self.send(method) }
     raise(InvalidAPIObject, self) if invalid?
     render_properties!(xml)
   end
@@ -124,22 +113,22 @@ class APIObject
   def render_properties!(xml)
     self.class.properties.each do |property|
       next unless instance_variable_get("@_set_#{property}")
-
       property_value = self.send(property)
+      render_property!(property, property_value, xml)
+    end
+  end
 
-      if property_value.is_a?(APIObject)
-        xml.__send__(property) do
-          property_value.render!(xml)
-        end
-      elsif property_value.is_a?(Array)
-        property_value.each do |current|
-          xml.__send__(property) do
-            current.render!(xml)
-          end
-        end
-      else
-        xml.__send__(property, property_value)
+  def render_property!(property_name, property_value, xml)
+    if property_value.is_a?(APIObject)
+      xml.__send__(property_name) do
+        property_value.render!(xml)
+      end
+    elsif property_value.is_a?(Array)
+      property_value.each do |current|
+        render_property!(property_name, current, xml)
       end
+    else
+      xml.__send__(property_name, property_value.to_s)
     end
   end
 

data/lib/exact_target_sdk/client.rb

@@ -64,6 +64,10 @@ class Client
     CreateResponse.new(response)
   end
 
+  def logger
+    config[:logger]
+  end
+
   private
 
   attr_accessor :config, :client
@@ -129,9 +133,11 @@ class Client
 
       response
     rescue ::Timeout::Error => e
-      timeout = ::ExactTargetSDK::Timeout.new("#{e.message}; open_timeout: #{config[:open_timeout]}; read_timeout: #{config[:read_timeout]}")
+      timeout = ::ExactTargetSDK::TimeoutError.new("#{e.message}; open_timeout: #{config[:open_timeout]}; read_timeout: #{config[:read_timeout]}")
       timeout.set_backtrace(e.backtrace)
       raise timeout
+    rescue Exception => e
+      raise ::ExactTargetSDK::UnknownError, e
     end
   end
 

data/lib/exact_target_sdk/create_response.rb

@@ -8,6 +8,7 @@ class CreateResponse
     @OverallStatus = response[:overall_status]
     @RequestID = response[:request_id]
     @Results = []
+
     results = if response[:results].is_a? Array
       response[:results]
     elsif response[:results].is_a? Hash

data/lib/exact_target_sdk/errors.rb

@@ -13,7 +13,16 @@ class SOAPFault < Error
 end
 
 # Indicates the open or read timeouts were reached
-class Timeout < Error
+class TimeoutError < Error
+end
+
+# Indicates any type of unexpected error
+class UnknownError < Error
+  attr_reader :wrapped_exception
+
+  def initialize(e)
+    @wrapped_exception = e
+  end
 end
 
 # Indicates validation failed on an APIObject, which is referenced

data/lib/exact_target_sdk/version.rb

@@ -1,3 +1,3 @@
 module ExactTargetSDK
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: exact_target_sdk
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 27
   prerelease: 
   segments: 
   - 0
   - 0
-  - 1
-  version: 0.0.1
+  - 2
+  version: 0.0.2
 platform: ruby
 authors: 
 - David Dawson