exact4r 0.9.2 → 0.9.3

data/CHANGELOG

@@ -1,3 +1,6 @@
+== v0.9.3
+  Reinstated Tagged Void support.
+
 == v0.9.2
   Converted tests to Test::Unit
   Added complete test suite, testing all transaction types.

data/VERSION

@@ -1 +1 @@
-0.9.2
+0.9.3

data/lib/ews/transaction/mapping.rb

@@ -1,4 +1,5 @@
 require 'builder'
+require File.dirname(__FILE__) + '/rexml-expansion-fix'
 
 module EWS # :nodoc:
   module Transaction # :nodoc:

data/lib/ews/transaction/request.rb

@@ -108,6 +108,7 @@ METHOD_EOS
         :tagged_purchase => '30',
         :tagged_pre_auth => '31',
         :tagged_pre_auth_completion => '32',
+        :tagged_void => '33',
         :tagged_refund => '34',
         :tagged_online_debit_refund => '35',
         :recurring_seed_pre_auth => '40',

data/lib/ews/transaction/rexml-expansion-fix.rb

@@ -0,0 +1,42 @@
+# Copyright (c) 2008 Michael Koziarski <michael@koziarski.com>
+# 
+# Permission to use, copy, modify, and/or distribute this software for any
+# purpose with or without fee is hereby granted, provided that the above
+# copyright notice and this permission notice appear in all copies.
+# 
+# THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+# WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+# MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+# ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+# WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+# ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+# OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+
+require 'rexml/document'
+require 'rexml/entity'
+
+module REXML
+  class Entity < Child
+    def unnormalized
+      document.record_entity_expansion!
+      v = value()
+      return nil if v.nil?
+      @unnormalized = Text::unnormalize(v, parent)
+      @unnormalized
+    end
+  end
+  class Document < Element
+    @@entity_expansion_limit = 10_000
+    def self.entity_expansion_limit= val
+      @@entity_expansion_limit = val
+    end
+    
+    def record_entity_expansion!
+      @number_of_expansions ||= 0
+      @number_of_expansions += 1
+      if @number_of_expansions > @@entity_expansion_limit
+        raise "Number of entity expansions exceeded, processing aborted."
+      end
+    end
+  end
+end

data/lib/ews/transaction/validator.rb

@@ -146,7 +146,7 @@ module EWS  # :nodoc:
         tt = self.transaction_type.to_i
         
         # mandatory: transaction_type must != (30, 31, 32, 34, 35)
-        append_error(:cc_number, "cc_number must not be set for tagged transactions") if [30,31,32,34,35].include?(tt)
+        append_error(:cc_number, "cc_number must not be set for tagged transactions") if [30,31,32,33,34,35].include?(tt)
         append_error(:cc_number, "cc_number must not be set for debit transactions") if [50,54].include?(tt)
         
         # amount, cardholder_name always mandaory
@@ -164,8 +164,8 @@ module EWS  # :nodoc:
       def validate_for_transaction_tag
         tt = self.transaction_type
 
-        # mandatory: transaction_type must == (30, 31, 32, 34, 35)
-        append_error(:transaction_tag, "transaction_tag must only be set for tagged transactions") unless ['30','31','32','34','35','CR'].include?(tt)
+        # mandatory: transaction_type must == (30, 31, 32, 33, 34, 35)
+        append_error(:transaction_tag, "transaction_tag must only be set for tagged transactions") unless %w(30 31 32 33 34 35 CR).include?(tt)
         
         # transaction_tag, auth_num & amount mandatory
         mandatory = [:transaction_tag]
@@ -183,7 +183,7 @@ module EWS  # :nodoc:
         tt = self.transaction_type.to_i
         
         # mandatory: transaction_type must != (30, 31, 32, 34, 35)
-        append_error(:track1, "track1 must not be set for tagged transactions") if [30,31,32,34,35].include?(tt)
+        append_error(:track1, "track1 must not be set for tagged transactions") if [30,31,32,33,34,35].include?(tt)
         append_error(:track1, "track1 must not be set for debit transactions") if [50,54].include?(tt)
 
         # amount mandatory for all
@@ -201,7 +201,7 @@ module EWS  # :nodoc:
         tt = self.transaction_type.to_i
 
         # mandatory: transaction_type must != (30, 31, 32, 34, 35, 50, 54)
-        append_error(:track2, "track2 must not be set for tagged transactions") if [30,31,32,34,35].include?(tt)
+        append_error(:track2, "track2 must not be set for tagged transactions") if [30,31,32,33,34,35].include?(tt)
         append_error(:track2, "track2 must not be set for debit transactions") if [50,54].include?(tt)
 
         # track2, expiry_date, cardholder_name, amount mandatory

data/lib/exact4r.rb

@@ -7,4 +7,4 @@ require 'ews/transaction/response'
 require 'ews/transaction/validator'
 require 'ews/transporter'
 
-require 'ews/transaction/fake_response'
+require 'ews/transaction/fake_response'

data/test/exhaustive/tagged_online_debit_refund_test.rb

@@ -114,8 +114,8 @@ class TaggedRefundTest < Test::Unit::TestCase
     request = EWS::Transaction::Request.new({
       :transaction_type => :tagged_online_debit_refund,
       :amount => 12.50,
-      :transaction_tag => @response.transaction_tag,
-      :authorization_num => @response.authorization_num
+      :transaction_tag => pre_response.transaction_tag,
+      :authorization_num => pre_response.authorization_num
     }.merge(CHASE_BASIC_AUTH))
     assert request.valid?, request.errors.inspect
     
@@ -136,8 +136,8 @@ class TaggedRefundTest < Test::Unit::TestCase
     request = EWS::Transaction::Request.new({
       :transaction_type => :tagged_online_debit_refund,
       :amount => 12.50,
-      :transaction_tag => @response.transaction_tag,
-      :authorization_num => @response.authorization_num
+      :transaction_tag => pre_response.transaction_tag,
+      :authorization_num => pre_response.authorization_num
     }.merge(CHASE_BASIC_AUTH))
     assert request.valid?, request.errors.inspect
     
@@ -158,8 +158,8 @@ class TaggedRefundTest < Test::Unit::TestCase
     request = EWS::Transaction::Request.new({
       :transaction_type => :tagged_refund,
       :amount => 12.50,
-      :transaction_tag => @response.transaction_tag,
-      :authorization_num => @response.authorization_num
+      :transaction_tag => pre_response.transaction_tag,
+      :authorization_num => pre_response.authorization_num
     }.merge(CHASE_BASIC_AUTH))
     assert request.valid?, request.errors.inspect
     

data/test/exhaustive/tagged_pre_auth_completion_test.rb

@@ -108,8 +108,8 @@ class TaggedPreAuthCompletionTest < Test::Unit::TestCase
     request = EWS::Transaction::Request.new({
       :transaction_type => :tagged_pre_auth_completion,
       :amount => 12.50,
-      :transaction_tag => @response.transaction_tag,
-      :authorization_num => @response.authorization_num
+      :transaction_tag => pre_response.transaction_tag,
+      :authorization_num => pre_response.authorization_num
     }.merge(EMERGIS_BASIC_AUTH))
     assert request.valid?, request.errors.inspect
     

data/test/exhaustive/tagged_pre_auth_test.rb

@@ -106,8 +106,8 @@ class TaggedPreAuthTest < Test::Unit::TestCase
     request = EWS::Transaction::Request.new({
       :transaction_type => :tagged_pre_auth,
       :amount => 12.50,
-      :transaction_tag => @response.transaction_tag,
-      :authorization_num => @response.authorization_num
+      :transaction_tag => pre_response.transaction_tag,
+      :authorization_num => pre_response.authorization_num
     }.merge(EMERGIS_BASIC_AUTH))
     assert request.valid?, request.errors.inspect
     

data/test/exhaustive/tagged_purchase_test.rb

@@ -106,8 +106,8 @@ class TaggedPurchaseTest < Test::Unit::TestCase
     request = EWS::Transaction::Request.new({
       :transaction_type => :tagged_purchase,
       :amount => 12.50,
-      :transaction_tag => @response.transaction_tag,
-      :authorization_num => @response.authorization_num
+      :transaction_tag => pre_response.transaction_tag,
+      :authorization_num => pre_response.authorization_num
     }.merge(EMERGIS_BASIC_AUTH))
     assert request.valid?, request.errors.inspect
     

data/test/exhaustive/tagged_refund_test.rb

@@ -2,8 +2,6 @@ require File.dirname(__FILE__) + "/../test_helper"
 
 class TaggedRefundTest < Test::Unit::TestCase
   
-  # NOTE: INTERAC Online Debit transactions are ONLY supported by Chase merchants
-
   def setup
     @transporter = EWS::Transporter.new(LOCATION)
 
@@ -112,8 +110,8 @@ class TaggedRefundTest < Test::Unit::TestCase
     request = EWS::Transaction::Request.new({
       :transaction_type => :tagged_refund,
       :amount => 11.25,
-      :transaction_tag => @response.transaction_tag,
-      :authorization_num => @response.authorization_num
+      :transaction_tag => pre_response.transaction_tag,
+      :authorization_num => pre_response.authorization_num
     }.merge(EMERGIS_BASIC_AUTH))
     assert request.valid?, request.errors.inspect
     
@@ -134,8 +132,8 @@ class TaggedRefundTest < Test::Unit::TestCase
     request = EWS::Transaction::Request.new({
       :transaction_type => :tagged_refund,
       :amount => 11.25,
-      :transaction_tag => @response.transaction_tag,
-      :authorization_num => @response.authorization_num
+      :transaction_tag => pre_response.transaction_tag,
+      :authorization_num => pre_response.authorization_num
     }.merge(EMERGIS_BASIC_AUTH))
     assert request.valid?, request.errors.inspect
     

data/test/exhaustive/tagged_void_test.rb

@@ -0,0 +1,160 @@
+require File.dirname(__FILE__) + "/../test_helper"
+
+class TaggedVoidTest < Test::Unit::TestCase
+  
+  def setup
+    @transporter = EWS::Transporter.new(LOCATION)
+
+    # do initial recurring seed
+    request = EWS::Transaction::Request.new(cc_number_params.merge(:transaction_type => :recurring_seed_purchase))
+    request.amount = 11.25
+    assert request.valid?, request.errors.inspect
+    
+    @response = @transporter.submit(request, :json)
+    assert @response.approved?
+  end
+  
+  def test_mandatory
+    request = EWS::Transaction::Request.new(:transaction_type => :tagged_void)
+    assert !request.valid?
+    assert_equal "gateway_id must be supplied", request.errors[:gateway_id]
+    
+    request.gateway_id = EMERGIS_BASIC_AUTH[:gateway_id]
+    assert !request.valid?
+    assert_equal "password must be supplied", request.errors[:password]
+    
+    request.password = EMERGIS_BASIC_AUTH[:password]
+    assert !request.valid?
+    assert_equal "One of the following must be supplied: cc_number, track1, track2 or transaction_tag.", request.errors[:base]
+    
+    request.transaction_tag = 1234
+    assert !request.valid?
+    assert_equal "authorization_num must be supplied", request.errors[:authorization_num]
+        
+    request.authorization_num = "TH6754"
+    assert !request.valid?
+    assert_equal "amount must be supplied", request.errors[:amount]
+    
+    request.amount = 11.25
+    assert request.valid?
+    
+    request.cc_number = "4111111111111111"
+    assert !request.valid?
+    assert_equal "do not set cc_number for tagged transactions", request.errors[:cc_number]
+  end
+  
+  def test_json
+    request = EWS::Transaction::Request.new({
+      :transaction_type => :tagged_void,
+      :amount => 11.25,
+      :transaction_tag => @response.transaction_tag,
+      :authorization_num => @response.authorization_num
+    }.merge(EMERGIS_BASIC_AUTH))
+    assert request.valid?, request.errors.inspect
+    
+    assert_details_correct request, @transporter.submit(request, :json)
+  end
+
+  def test_rest
+    request = EWS::Transaction::Request.new({
+      :transaction_type => :tagged_void,
+      :amount => 11.25,
+      :transaction_tag => @response.transaction_tag,
+      :authorization_num => @response.authorization_num
+    }.merge(EMERGIS_BASIC_AUTH))
+    assert request.valid?, request.errors.inspect
+    
+    assert_details_correct request, @transporter.submit(request, :rest)
+  end
+
+  def test_soap
+    request = EWS::Transaction::Request.new({
+      :transaction_type => :tagged_void,
+      :amount => 11.25,
+      :transaction_tag => @response.transaction_tag,
+      :authorization_num => @response.authorization_num
+    }.merge(EMERGIS_BASIC_AUTH))
+    assert request.valid?, request.errors.inspect
+    
+    assert_details_correct request, @transporter.submit(request, :soap)
+  end
+  
+  def test_requires_correct_amount
+    request = EWS::Transaction::Request.new({
+      :transaction_type => :tagged_void,
+      :amount => 3.50,
+      :transaction_tag => @response.transaction_tag,
+      :authorization_num => @response.authorization_num
+    }.merge(EMERGIS_BASIC_AUTH))
+    assert request.valid?, request.errors.inspect
+    
+    response = @transporter.submit(request, :json)
+    assert !response.approved?
+
+    request.amount = 13.50
+    response = @transporter.submit(request, :rest)
+    assert !response.approved?
+
+    request.amount = 11.25
+    assert_details_correct request, @transporter.submit(request, :soap)
+  end
+
+  def test_multiple_voids_against_one_seed
+    request = EWS::Transaction::Request.new({
+      :transaction_type => :tagged_void,
+      :amount => 11.25,
+      :transaction_tag => @response.transaction_tag,
+      :authorization_num => @response.authorization_num
+    }.merge(EMERGIS_BASIC_AUTH))
+    assert request.valid?, request.errors.inspect
+    
+    assert_details_correct request, @transporter.submit(request, :json)
+
+    # can't void an already-voided transaction
+    response = @transporter.submit(request, :json)
+    assert !response.approved?
+  end
+
+  def test_not_permitted_after_recurring_seed_pre_auth
+    # do initial recurring seed pre auth
+    pre_request = EWS::Transaction::Request.new(cc_number_params.merge(:transaction_type => :recurring_seed_pre_auth))
+    pre_request.amount = 11.25
+    assert pre_request.valid?, pre_request.errors.inspect
+    
+    pre_response = @transporter.submit(pre_request, :json)
+    assert pre_response.approved?
+    
+    # now do the tagged refund
+    request = EWS::Transaction::Request.new({
+      :transaction_type => :tagged_void,
+      :amount => 11.25,
+      :transaction_tag => pre_response.transaction_tag,
+      :authorization_num => pre_response.authorization_num
+    }.merge(EMERGIS_BASIC_AUTH))
+    assert request.valid?, request.errors.inspect
+    
+    response = @transporter.submit(request, :json)
+    assert !response.approved?
+  end
+
+  def test_permitted_after_plain_purchase
+    # do initial purchase
+    pre_request = EWS::Transaction::Request.new(cc_number_params.merge(:transaction_type => :purchase))
+    pre_request.amount = 11.25
+    assert pre_request.valid?, pre_request.errors.inspect
+    
+    pre_response = @transporter.submit(pre_request, :json)
+    assert pre_response.approved?
+    
+    # now do the tagged refund
+    request = EWS::Transaction::Request.new({
+      :transaction_type => :tagged_void,
+      :amount => 11.25,
+      :transaction_tag => pre_response.transaction_tag,
+      :authorization_num => pre_response.authorization_num
+    }.merge(EMERGIS_BASIC_AUTH))
+    assert request.valid?, request.errors.inspect
+    
+    assert_details_correct request, @transporter.submit(request, :json)
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: exact4r
 version: !ruby/object:Gem::Version 
-  version: 0.9.2
+  version: 0.9.3
 platform: ruby
 authors: 
 - E-xact Transactions Ltd.
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-09-15 00:00:00 +10:00
+date: 2009-09-30 00:00:00 +10:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -76,6 +76,7 @@ files:
 - ./lib/ews/transaction/mapping.rb
 - ./lib/ews/transaction/request.rb
 - ./lib/ews/transaction/response.rb
+- ./lib/ews/transaction/rexml-expansion-fix.rb
 - ./lib/ews/transaction/validator.rb
 - ./lib/ews/transporter.rb
 - ./lib/exact4r.rb
@@ -100,6 +101,7 @@ files:
 - ./test/exhaustive/tagged_pre_auth_test.rb
 - ./test/exhaustive/tagged_purchase_test.rb
 - ./test/exhaustive/tagged_refund_test.rb
+- ./test/exhaustive/tagged_void_test.rb
 - ./test/exhaustive/transaction_details_test.rb
 - ./test/exhaustive/void_test.rb
 - ./test/general/avs_test.rb