exact4r 0.8 → 0.9

data/CHANGELOG

@@ -1,3 +1,6 @@
+== v0.9
+  Fixed incorrect decoding of boolean attributes from SOAP response
+
 == v0.8
   Added User-Agent string to HTTP requests
 

data/VERSION

@@ -1 +1 @@
-0.8
+0.9

data/after.log

@@ -1,6 +1,6 @@
 (in /Volumes/Exact/WebService/exact4r)
 ..............[].[].[].[]..........
 
-Finished in 106.243974 seconds
+Finished in 82.478117 seconds
 
 27 examples, 0 failures

data/before.log

@@ -0,0 +1,17 @@
+(in /Volumes/Exact/WebService/exact4r)
+..............[].[].[].[]F....F....
+
+1)
+'Submitting Find Requests should support SOAP' FAILED
+expected: "00",
+     got: nil (using ==)
+./spec/request_spec.rb:138:
+
+2)
+'Transporter creating transactions should throw an exception when parsing a response to sending nonsense SOAP' FAILED
+expected Exception but nothing was raised
+./spec/transporter_spec.rb:38:
+
+Finished in 82.424866 seconds
+
+27 examples, 2 failures

data/doc/classes/EWS/Transporter.html

@@ -224,7 +224,7 @@ transport type will be used
 52:       <span class="ruby-identifier">request</span> = <span class="ruby-identifier">build_http_request</span>(<span class="ruby-identifier">transaction</span>, <span class="ruby-identifier">transport_type</span>, <span class="ruby-identifier">transport_details</span>[<span class="ruby-identifier">:suffix</span>])
 53:       <span class="ruby-identifier">request</span>.<span class="ruby-identifier">basic_auth</span>(<span class="ruby-identifier">transaction</span>.<span class="ruby-identifier">gateway_id</span>, <span class="ruby-identifier">transaction</span>.<span class="ruby-identifier">password</span>)
 54:       <span class="ruby-identifier">request</span>.<span class="ruby-identifier">add_field</span> <span class="ruby-value str">&quot;Accept&quot;</span>, <span class="ruby-identifier">transport_details</span>[<span class="ruby-identifier">:content_type</span>]
-55:       <span class="ruby-identifier">request</span>.<span class="ruby-identifier">add_field</span> <span class="ruby-value str">&quot;User-Agent&quot;</span>, <span class="ruby-value str">&quot;Ruby&quot;</span>
+55:       <span class="ruby-identifier">request</span>.<span class="ruby-identifier">add_field</span> <span class="ruby-value str">&quot;User-Agent&quot;</span>, <span class="ruby-value str">&quot;exact4r v0.7&quot;</span>
 56:       <span class="ruby-identifier">request</span>.<span class="ruby-identifier">add_field</span> <span class="ruby-value str">&quot;Content-type&quot;</span>, <span class="ruby-node">&quot;#{transport_details[:content_type]}; charset=UTF-8&quot;</span>
 57: 
 58:       <span class="ruby-identifier">response</span> = <span class="ruby-identifier">get_connection</span>.<span class="ruby-identifier">request</span>(<span class="ruby-identifier">request</span>)

data/doc/created.rid

@@ -1 +1 @@
-Tue, 10 Mar 2009 12:04:48 +1100
+Wed, 10 Jun 2009 12:23:07 +1000

data/doc/files/CHANGELOG.html

@@ -56,7 +56,7 @@
     </tr>
     <tr class="top-aligned-row">
       <td><strong>Last Update:</strong></td>
-      <td>Tue Mar 10 11:58:52 +1100 2009</td>
+      <td>Wed Jun 10 12:21:52 +1000 2009</td>
     </tr>
     </table>
   </div>
@@ -69,7 +69,11 @@
   <div id="contextContent">
 
     <div id="description">
-      <h2>v0.7</h2>
+      <h2>v0.8</h2>
+<pre>
+  Added User-Agent string to HTTP requests
+</pre>
+<h2>v0.7</h2>
 <pre>
   Updated with latest certificates for api.e-xact.com
   Fixed SOAP namespace issue

data/doc/files/VERSION.html

@@ -56,7 +56,7 @@
     </tr>
     <tr class="top-aligned-row">
       <td><strong>Last Update:</strong></td>
-      <td>Tue Mar 10 11:59:06 +1100 2009</td>
+      <td>Wed Jun 10 12:21:24 +1000 2009</td>
     </tr>
     </table>
   </div>
@@ -70,7 +70,7 @@
 
     <div id="description">
       <p>
-0.7
+0.8
 </p>
 
     </div>

data/doc/files/lib/ews/transporter_rb.html

@@ -56,7 +56,7 @@
     </tr>
     <tr class="top-aligned-row">
       <td><strong>Last Update:</strong></td>
-      <td>Fri Feb 27 15:24:14 +1100 2009</td>
+      <td>Wed Jun 10 12:04:40 +1000 2009</td>
     </tr>
     </table>
   </div>

data/lib/ews/transaction/mapping.rb

@@ -158,19 +158,20 @@ module EWS # :nodoc:
         root.elements.to_a.each do |node|
           gwlib_prop_name = XML_RESPONSE_TAGS_TO_ATTRS[node.name.to_sym]
           unless gwlib_prop_name.nil?
-            # todo: should notiy this somehow??
-            value = (ATTR_FORMATS.include?(gwlib_prop_name)) ? node.text.send("to_#{ATTR_FORMATS[gwlib_prop_name]}") : node.text
+            value = case gwlib_prop_name
+            when :transaction_approved, :transaction_error
+              (node.text == "true") ? 1 : 0
+            when :transaction_tag
+              node.text.to_i
+            else
+              node.text
+            end
+
             response.send "#{gwlib_prop_name}=", value
           end
         end
       end
     
-      # type-conversion from strings for certain attributes
-      ATTR_FORMATS = {
-        :transaction_tag => "i",
-        :transaction_approved => "i"
-      }
-    
       REQUEST_ENVELOPE_NAMESPACES = {
         "xmlns:xsd" => "http://www.w3.org/2001/XMLSchema",
         "xmlns:soap" => "http://schemas.xmlsoap.org/soap/envelope/",

data/lib/ews/transporter.rb

@@ -52,7 +52,7 @@ module EWS # :nodoc:
       request = build_http_request(transaction, transport_type, transport_details[:suffix])
       request.basic_auth(transaction.gateway_id, transaction.password)
       request.add_field "Accept", transport_details[:content_type]
-      request.add_field "User-Agent", "exact4r v0.7"
+      request.add_field "User-Agent", "exact4r v0.9"
       request.add_field "Content-type", "#{transport_details[:content_type]}; charset=UTF-8"
 
       response = get_connection.request(request)

data/qa.log

@@ -0,0 +1,14 @@
+(in /Volumes/Exact/WebService/exact4r)
+..............[].[].[].[]F.........
+
+1)
+RuntimeError in 'Submitting Find Requests should support SOAP'
+Malformed XML Request.
+./spec/../lib/ews/transaction/mapping.rb:133:in `soap_to_response'
+./spec/../lib/ews/transporter.rb:66:in `send'
+./spec/../lib/ews/transporter.rb:66:in `submit'
+./spec/request_spec.rb:135:
+
+Finished in 102.726155 seconds
+
+27 examples, 1 failure

data/spec/request_spec.rb

@@ -50,6 +50,7 @@ describe "Submitting New Requests" do
 
     resp.exact_resp_code.should == "00"
     resp.exact_message.should == "Transaction Normal"
+    resp.transaction_approved.should == 1
     resp.bank_message.downcase.should match(/approved/)
     resp.transaction_tag.should_not be_nil
   end
@@ -60,6 +61,7 @@ describe "Submitting New Requests" do
 
     resp.exact_resp_code.should == "00"
     resp.exact_message.should == "Transaction Normal"
+    resp.transaction_approved.should == 1
     resp.bank_message.downcase.should match(/approved/)
     resp.transaction_tag.should_not be_nil
   end
@@ -70,6 +72,7 @@ describe "Submitting New Requests" do
 
     resp.exact_resp_code.should == "00"
     resp.exact_message.should == "Transaction Normal"
+    resp.transaction_approved.should == 1
     resp.bank_message.downcase.should match(/approved/)
     resp.transaction_tag.should_not be_nil
   end
@@ -80,6 +83,7 @@ describe "Submitting New Requests" do
 
     resp.exact_resp_code.should == "00"
     resp.exact_message.should == "Transaction Normal"
+    resp.transaction_approved.should == 1
     resp.bank_message.downcase.should match(/approved/)
     resp.transaction_tag.should_not be_nil
   end

data/spec/spec_helper.rb

@@ -7,13 +7,13 @@ require 'ruby-debug'
 REPLICATION_TIME = 20
 
 # address & authentication for testing against api.e-xact.com
-LOCATION = "https://api.e-xact.com/"
-BASIC_AUTH = {:gateway_id => "A00049-01", :password => "test1"}
+# LOCATION = "https://api.e-xact.com/"
+# BASIC_AUTH = {:gateway_id => "A00049-01", :password => "test1"}
 
 # address & authentication for local testing
-# LOCATION = "http://ws.local/"   # I am a Passenger...
+LOCATION = "http://ws.local/"   # I am a Passenger...
 # LOCATION = "http://localhost:3000/"   # old skool
-# BASIC_AUTH = {:gateway_id => "AD0008-01", :password => "7nfcpc7n"}
+BASIC_AUTH = {:gateway_id => "AD0008-01", :password => "7nfcpc7n"}
 
 Spec::Runner.configure do |config|
   include EWS::Transaction

data/spec/transporter_spec.rb

@@ -30,14 +30,14 @@ describe "Transporter creating transactions" do
     resp.error_description.should == "Not Found"
   end
   
-  it "should throw an exception when parsing a response to sending nonsense SOAP" do
+  it "should correctly decode error when sending nonsense SOAP" do
     req = basic_find_transaction
 
     EWS::Transaction::Mapping.stubs(:request_to_soap).returns("Complete and utter rubbish. It's not even XML!!")
     tr = ::EWS::Transporter.new(LOCATION)
-    lambda {
-      tr.submit(req, :soap)
-    }.should raise_error
+    r = tr.submit(req, :soap)
+    r.error_number.should == 401
+    r.error_description.should == "Malformed XML Request."
   end
   
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: exact4r
 version: !ruby/object:Gem::Version 
-  version: "0.8"
+  version: "0.9"
 platform: ruby
 authors: 
 - E-xact Transactions Ltd.
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-06-10 00:00:00 +10:00
+date: 2009-07-08 00:00:00 +10:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -45,6 +45,7 @@ extra_rdoc_files:
 - VERSION
 files: 
 - ./after.log
+- ./before.log
 - ./certs
 - ./certs/equifax_ca.cer
 - ./certs/exact.cer
@@ -90,6 +91,7 @@ files:
 - ./lib/ews/transporter.rb
 - ./lib/exact4r.rb
 - ./LICENCE
+- ./qa.log
 - ./Rakefile
 - ./README
 - ./spec