ews-api 0.1.0 → 0.1.1

data/VERSION

@@ -1 +1 @@
-0.1.0
+0.1.1

data/ews-api.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{ews-api}
-  s.version = "0.1.0"
+  s.version = "0.1.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["jrun"]
@@ -65,17 +65,17 @@ Gem::Specification.new do |s|
   s.rubygems_version = %q{1.3.5}
   s.summary = %q{Exchange Web Services API}
   s.test_files = [
-    "spec/spec_helper.rb",
-     "spec/integration.rb",
-     "spec/ews/parser_spec.rb",
-     "spec/ews/message_spec.rb",
+    "spec/ews/attachment_spec.rb",
      "spec/ews/builder_spec.rb",
-     "spec/ews/attachment_spec.rb",
-     "spec/ews/folder_spec.rb",
-     "spec/ews/service_spec.rb",
      "spec/ews/builders/resolve_names_builder_spec.rb",
      "spec/ews/builders/shape_builder_spec.rb",
-     "spec/ews/model_spec.rb"
+     "spec/ews/folder_spec.rb",
+     "spec/ews/message_spec.rb",
+     "spec/ews/model_spec.rb",
+     "spec/ews/parser_spec.rb",
+     "spec/ews/service_spec.rb",
+     "spec/integration.rb",
+     "spec/spec_helper.rb"
   ]
 
   if s.respond_to? :specification_version then

data/lib/ews/builder.rb

@@ -48,7 +48,7 @@ module EWS
     
     def id_container!(container_node_name, ids)
       @action_node.add(container_node_name) do |container_node|
-        to_a(ids).each {|id| yield container_node, id }
+        Array(ids).each {|id| yield container_node, id }
       end
     end
 
@@ -91,17 +91,6 @@ module EWS
         id_node.set_attr 'ChangeKey', opts[:change_key] if opts[:change_key]
       end 
     end
-
-    # TODO: core_ext?
-    def to_a(ids)
-      case ids
-      when Enumerable
-        ids
-      else
-        [ids]
-      end
-    end
-
   end
   
 end

data/lib/ews/error.rb

@@ -3,6 +3,9 @@ module EWS
   class Error < StandardError
   end
   
+  class PreconditionFailed < Error
+  end
+  
   class ResponseError < Error
     attr_reader :response_code
 

data/lib/ews/folder.rb

@@ -33,7 +33,7 @@ module EWS
       # NOTE: This assumes Service#find_item only returns
       # Messages. That is true now but will change as more
       # of the parser is implemented.
-      service.find_item(self.name, :base_shape => :AllProperties)
+      service.find_item(self.id, :base_shape => :AllProperties)
     end
 
     def find_folders

data/lib/ews/model.rb

@@ -1,8 +1,11 @@
 module EWS
     
   class Model
+    attr_accessor :service
+    
     def initialize(attrs = {})
       @attrs = attrs.dup
+      @service = EWS::Service
     end
 
     def shallow?
@@ -12,10 +15,6 @@ module EWS
     protected
     attr_reader :attrs
     
-    def service
-      EWS::Service
-    end
-
     public
     def method_missing(meth, *args)
       method_name = meth.to_s

data/lib/ews/service.rb

@@ -275,6 +275,8 @@ module EWS
     # @see http://msdn.microsoft.com/en-us/library/aa563525.aspx
     # ItmeIds
     def get_item(item_id, opts = {})
+      raise PreconditionFailed, "Id must be non-empty" if item_id.nil?
+      
       soap_action = 'http://schemas.microsoft.com/exchange/services/2006/messages/GetItem'
       response = invoke('tns:GetItem', soap_action) do |get_item|
         builder(get_item, opts) do
@@ -379,6 +381,8 @@ module EWS
     # @see http://msdn.microsoft.com/en-us/library/aa494316.aspx
     # GetAttachment
     def get_attachment(attachment_id, opts = {})
+      raise PreconditionFailed, "Id must be non-empty" if attachment_id.nil?
+      
       soap_action = 'http://schemas.microsoft.com/exchange/services/2006/messages/GetAttachment'
       response = invoke('tns:GetAttachment', soap_action) do |get_attachment|
         builder(get_attachment, opts) do

data/spec/ews/builder_spec.rb

@@ -12,7 +12,7 @@ describe EWS::Builder do
   before(:each) do
     @doc = new_document
   end      
-  
+
   context '#item_id! should build ItemId' do
     def expected_item_id
       %Q|<t:ItemId #{TNS} Id="XYZ" />|

data/spec/ews/folder_spec.rb

@@ -6,6 +6,18 @@ module EWS
       @parser = Parser.new
     end
 
+    context "#iems" do
+      it "should call service#find_item with the folder id" do
+        service = mock(:service)
+        service.should_receive(:find_item).with('maid of tarth', anything())
+        
+        folder = Folder.new(:folder_id => {:id => 'maid of tarth'})
+        folder.service = service
+        
+        folder.items
+      end      
+    end
+    
     context '#folders' do
       it "should be indexed by display name" do
         mock_response response(:find_folder)
@@ -21,7 +33,7 @@ module EWS
         
         message_count = 0
         subjects = ['test', 'Regarding Brandon Stark', 'Re: Regarding Brandon Stark']
-        folder = Folder.new(:display_name => 'Inbox')
+        folder = Folder.new(:display_name => 'Inbox', :folder_id => {:id => 'maid of tarth'})
         
         folder.each_message do |message|
           message_count += 1

data/spec/ews/service_spec.rb

@@ -5,10 +5,17 @@ EWS::Service.endpoint 'http://localhost/ews/exchange.aspx'
 describe EWS::Service do
   context '#get_item' do    
     it "should raise an error when the id is not found" do
-      mock_response response(:get_item_with_error)
       lambda do
         EWS::Service.get_item nil
-      end.should raise_error(EWS::ResponseError, 'Id must be non-empty.')
+      end.should raise_error(EWS::PreconditionFailed, /Id must be non-empty/)
     end
   end
+
+  context "#get_attachment" do
+    it "should raise an error when the id is not found" do
+      lambda do
+        EWS::Service.get_attachment nil
+      end.should raise_error(EWS::PreconditionFailed, /Id must be non-empty/)
+    end    
+  end
 end

data/spec/integration.rb

@@ -111,11 +111,11 @@ describe 'Integration Tests' do
       item = EWS::Service.get_item EWS_CONFIG['item_id'], :base_shape => :AllProperties
       item.should be_instance_of(EWS::Message)
     end
-
-    it "should raise a SoapError when the ResponseMessage is an Error" do
+    
+    it "should raise an error when the requested id is nil" do
       lambda do
         EWS::Service.get_item(nil)
-      end.should raise_error(EWS::ResponseError, /Id must be non-empty/)
+      end.should raise_error(EWS::PreconditionFailed, /Id must be non-empty/)
     end
   end
 
@@ -125,11 +125,11 @@ describe 'Integration Tests' do
         rtn = EWS::Service.get_attachment EWS_CONFIG['attachment_id'] # lame
       end.should_not raise_error
     end
-
-    it "should raise a EWS::ResponseError when the ResponseMessage is an Error" do
+    
+    it "should raise an error when the requested id is nil" do
       lambda do
         EWS::Service.get_attachment(nil)
-      end.should raise_error(EWS::ResponseError, /Id must be non-empty/)
+      end.should raise_error(EWS::PreconditionFailed, /Id must be non-empty/)
     end
   end
 
@@ -153,5 +153,14 @@ describe 'Integration Tests' do
       end.should raise_error(EWS::ResponseError, /Id is malformed/)      
     end
   end
-  
+
+  context "EWS.inbox" do
+    it "#each_message should iterate through the inbox without errors" do
+      # lame test but will help protect against a regression until a
+      # proper inbox setup is complete
+      count = 0
+      EWS.inbox.each_message {|m| count += 1}
+      count.should > 0
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: ews-api
 version: !ruby/object:Gem::Version 
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors: 
 - jrun
@@ -142,14 +142,14 @@ signing_key:
 specification_version: 3
 summary: Exchange Web Services API
 test_files: 
-- spec/spec_helper.rb
-- spec/integration.rb
-- spec/ews/parser_spec.rb
-- spec/ews/message_spec.rb
-- spec/ews/builder_spec.rb
 - spec/ews/attachment_spec.rb
-- spec/ews/folder_spec.rb
-- spec/ews/service_spec.rb
+- spec/ews/builder_spec.rb
 - spec/ews/builders/resolve_names_builder_spec.rb
 - spec/ews/builders/shape_builder_spec.rb
+- spec/ews/folder_spec.rb
+- spec/ews/message_spec.rb
 - spec/ews/model_spec.rb
+- spec/ews/parser_spec.rb
+- spec/ews/service_spec.rb
+- spec/integration.rb
+- spec/spec_helper.rb