evil-metrics-sidekiq 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: de3126c7e5682d96325b81bbef7cfb5a432eab92257f557cba134c337cb5cc5d
-  data.tar.gz: 0a1bfcbc03fda0a05cbc5b12d86e3835c67d72b713bde0b3609291fdab94829c
+  metadata.gz: 8d8fb6bbeb42739176e5fb140daf63be8e3d609a888527f97b4835ac4f6b0136
+  data.tar.gz: e55265b9c18f7f1931afb63020208edcb0d121c36414d69591db38cd0d66b234
 SHA512:
-  metadata.gz: 0af5fb775ea6fba35ac0ff9302abb445ba843fe5240a425e4a18ab7822f587e204a15a724dc9cde261237063a0192be19ab5a2ff4c81fae6a81bfefe271bb1e3
-  data.tar.gz: e8dba821ab1d688b91150b43fe15987a997e18cc284aa02e8a3d6ec840bd188beb47bfb95e7a29b50ca763dc26ad70de9406fd778a4513fc986334bf9699d058
+  metadata.gz: d57c91697e9f580682e4cc52ad34209a0887c26227e020d0e5162b230487bcf0af2d212936ab3933f1fa8019a566ef5028c9734c789f6cc4a3f58495852e0df6
+  data.tar.gz: 2abc6c3e185de6a849bf6adf1ff9490fcec9b4f64015897755eda02a505ff52f815fac89a3c270ad4055f9fc2323d5fd2e65296fb8da137d3d1afa0b2943934f

data/README.md

@@ -1,44 +1,29 @@
 # Evil::Metrics::[Sidekiq]
 
-Built-in metrics for [Sidekiq] monitoring out of the box!
+Built-in metrics for [Sidekiq] monitoring out of the box! Part of the [evil-metrics] suite.
 
 ## Installation
 
- 1. Add this line to your application's Gemfile:
+```ruby
+gem 'evil-metrics-rails'
+# Then add monitoring system adapter, e.g.:
+# gem 'evil-metrics-prometheus'
+```
 
-    ```ruby
-    gem 'evil-metrics-rails'
-    # Then add monitoring system adapter, e.g.:
-    # gem 'evil-metrics-prometheus'
-    ```
+And then execute:
 
-    And then execute:
+    $ bundle
 
-        $ bundle
+**And that is it!** Sidekiq metrics are being collected!
 
+Additionally, depending on your adapter, you may want to setup metrics export. E.g. for [evil-metrics-prometheus]:
 
- 2. Add middlewares to your Sidekiq server and client:
-
-    ```ruby
-    # config/initializers/sidekiq or elsewhere
-    Sidekiq.configure_server do |config|
-      config.redis = your_redis_credentials
-      config.server_middleware do |chain|
-        chain.add Evil::Metrics::Sidekiq::ServerMiddleware
-      end
-      # Additional setup may be required depending on adapter. E.g. for prometheus:
-      # Evil::Metrics::Prometheus::Exporter.start_metrics_server!
-    end
-
-    Sidekiq.configure_client do |config|
-      config.redis = your_redis_credentials
-      config.client_middleware do |chain|
-        chain.add Evil::Metrics::Sidekiq::ClientMiddleware
-      end
-    end
-    ```
-
- 3. You're done!
+```ruby
+# config/initializers/sidekiq or elsewhere
+Sidekiq.configure_server do |_config|
+  Evil::Metrics::Prometheus::Exporter.start_metrics_server!
+end
+```
 
 ## Metrics
 
@@ -59,7 +44,7 @@ Built-in metrics for [Sidekiq] monitoring out of the box!
 
    It should be disabled by default as it requires to iterate over all jobs in sets and may be very slow on large sets.
 
- - Maybe hooks for ease of plugging in metrics for myriads of Sidekiq plugins?
+ - Maybe add some hooks for ease of plugging in metrics for myriads of Sidekiq plugins?
 
 ## Development
 
@@ -76,3 +61,5 @@ Bug reports and pull requests are welcome on GitHub at https://github.com/evil-m
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
 
 [Sidekiq]: https://github.com/mperham/sidekiq/ "Simple, efficient background processing for Ruby"
+[evil-metrics]: https://github.com/evil-metrics/evil-metrics
+[evil-metrics-prometheus]: https://github.com/evil-metrics/evil-metrics-prometheus

data/lib/evil/metrics/sidekiq.rb

@@ -58,12 +58,27 @@ module Evil
         end
       end
 
+      ::Sidekiq.configure_server do |config|
+        config.server_middleware do |chain|
+          chain.add ServerMiddleware
+        end
+        config.client_middleware do |chain|
+          chain.add ClientMiddleware
+        end
+      end
+
+      ::Sidekiq.configure_client do |config|
+        config.client_middleware do |chain|
+          chain.add ClientMiddleware
+        end
+      end
+
       class << self
-        def labelize(worker, _job, queue)
-          { queue: queue, worker: worker_class(worker) }
+        def labelize(worker, job, queue)
+          { queue: queue, worker: worker_class(worker, job) }
         end
 
-        def worker_class(worker)
+        def worker_class(worker, job)
           if defined?(ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper)
             return job["wrapped"] if worker.is_a?(ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper)
           end

data/lib/evil/metrics/sidekiq/version.rb

@@ -3,7 +3,7 @@
 module Evil
   module Metrics
     module Sidekiq
-      VERSION = "0.1.0"
+      VERSION = "0.1.1"
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: evil-metrics-sidekiq
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Andrey Novikov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-03 00:00:00.000000000 Z
+date: 2018-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: evil-metrics