eventsimple 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46f6a80be5a43cb84c321b67e9a27dde596b2eb3aa3d55ce8f635e395f42ce19
-  data.tar.gz: c3abab5c2bd25bee61695d24cdb9104cd11d403bb2b360ad1417f71f3006cd54
+  metadata.gz: 989aab149125d77a97510193a1905233eef5714a798a821e14fa7697247b5403
+  data.tar.gz: 7dc3276c03f6ab9617733ef292297ba2e5dc9b414c5d221621b2bed5a8635151
 SHA512:
-  metadata.gz: 3eb05c140311c7466f6cc27fe2a63e033f4464123449d9c9bc20b4b3ae9dd207b03bfe3acfd00cbf6c04bfa4c55456910fb2cee80056e04b5ec5aff70a4b73c1
-  data.tar.gz: fe56e5c4b5fa1608bd05a01f2b05f2051c8d7491170dc0c06790279a134a5d2b19465feca5104420d7dc43dcf2816e982d7aafbaa0aa65bfeadcca0ad476948d
+  metadata.gz: a378b62e0dc1e50540b85f002b06d5a8ff8b17d338b9b7a860d97f630538c919dde28bd1ff44c1d0ef62e29044e26f11089115e03bbd08545c60566fd893a9c5
+  data.tar.gz: 34cd12770a08ff80b4c6e7ee6e01e0c8e347415d7303ee646d4328a734ca2214180cd64e223e38fe7bae1bb6f39a702aa44ad2dc9e440677cd42e3ce1424618b

data/CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## 1.1.2 - 2023-06-22
+### Changed
+- Fix exception noise generated by early global_id desrialization
+
 ## 1.1.1 - 2023-06-19
 ### Changed
 - Remove active_job_parent_klass config introduced in 1.1.0. There isn't a usecase for it yet,

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    eventsimple (1.1.1)
+    eventsimple (1.1.2)
       dry-struct (~> 1.6)
       dry-types (~> 1.7)
       pg (~> 1.4)

data/lib/eventsimple/active_job/arguments.rb

@@ -0,0 +1,20 @@
+require 'active_job/arguments'
+
+module ActiveJob
+  module Arguments
+    extend self
+
+    def deserialize_global_id(hash)
+      # For non database based processors like sidekiq, the reactor may trigger before the
+      # transaction is committed. Attempt to wait for the transaction to be commited before
+      # running the reactor. This is not a perfect solution, but it's better than nothing.
+      if Eventsimple.configuration.retry_reactor_on_record_not_found
+        Retriable.with_context(:reactor) do
+          ApplicationRecord.uncached { GlobalID::Locator.locate hash[GLOBALID_KEY] }
+        end
+      else
+        GlobalID::Locator.locate hash[GLOBALID_KEY]
+      end
+    end
+  end
+end

data/lib/eventsimple/reactor.rb

@@ -4,29 +4,12 @@ module Eventsimple
   class Reactor < ActiveJob::Base # rubocop:disable Rails/ApplicationJob
     queue_as :eventsimple
 
-    def perform(event)
-      call(event)
+    discard_on ActiveJob::DeserializationError do |job, error|
+      Rails.logger.warn("Event #{job.arguments.first} not found for reactor: #{self.class}")
     end
 
-    around_perform do |job, block|
-      event_global_id = job.arguments.first
-      reactor_class = job.arguments.second
-
-      # For non database based processors like sidekiq, the reactor may trigger before the
-      # transaction is committed. Attempt to wait for the transaction to be commited before
-      # running the reactor. This is not a perfect solution, but it's better than nothing.
-      if Eventsimple.configuration.retry_reactor_on_record_not_found
-        begin
-          Retriable.with_context(:reactor) do
-            ApplicationRecord.uncached { GlobalID::Locator.locate(event_global_id) }
-          end
-        rescue ActiveRecord::RecordNotFound
-          Rails.logger.error("Event #{event_global_id} not found for reactor: #{reactor_class}")
-          return
-        end
-      end
-
-      block.call
+    def perform(event)
+      call(event)
     end
   end
 end

data/lib/eventsimple/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Eventsimple
-  VERSION = '1.1.1'
+  VERSION = '1.1.2'
 end

data/lib/eventsimple.rb

@@ -13,6 +13,7 @@ require 'sidekiq'
 
 require 'dry_types'
 
+require 'eventsimple/active_job/arguments'
 require 'eventsimple/configuration'
 require 'eventsimple/message'
 require 'eventsimple/data_type'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eventsimple
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Zulfiqar Ali
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-06-19 00:00:00.000000000 Z
+date: 2023-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-struct
@@ -253,6 +253,7 @@ files:
 - eventsimple.gemspec
 - lib/dry_types.rb
 - lib/eventsimple.rb
+- lib/eventsimple/active_job/arguments.rb
 - lib/eventsimple/configuration.rb
 - lib/eventsimple/data_type.rb
 - lib/eventsimple/dispatcher.rb