evelpidon_validators 0.4.4 → 0.5.0

checksums.yaml

@@ -0,0 +1,15 @@
+---
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    NWNiMWUwMWZiMzYzZmE3YjhjNTQ2NWM2MDZlYzg3YjNmNDlkZGViZg==
+  data.tar.gz: !binary |-
+    ZDBkMTliNDgwMzkzYmFlYzMyMTY1YWEzMDM1YzVlMjNkZWRjOTUzYw==
+!binary "U0hBNTEy":
+  metadata.gz: !binary |-
+    OTAyNTVkOTVjZWRhMzc1YWY4YzExYTU1MTFhYjQzZThhM2UzMjMwYmE5NmQ4
+    NDU5YmU0YmJhOGY3NWY5ZjRjZTBiMWRlNTU2Y2VjYzIxZDk2MTNiMTA3NGY5
+    YjY1OGQyNTM0MGM3ZGM5ZjQ1MWRjZjFjYmJmOTM3NzdhZGY2MDM=
+  data.tar.gz: !binary |-
+    NDRhZWZmOTkxYTgwZDU3YjM1NTk3NDZmMTllZTMyOWQ5Njc1NWJlZjBjZmJk
+    YjkxYmQwNGZiYjYzZDEwM2U3ZDZkNGUwNzAwMjIzNWY0NTUzNDQ2ZTljMzdj
+    OTZmM2JjMjUwMGY4ZTllZjM2MmFhZWI2ODZiZGEwMzcxNWQ0ZjU=

data/.gitignore

@@ -2,6 +2,8 @@
 .bundle
 Gemfile.lock
 .rvmrc
+.ruby-version
+.ruby-gemset
 pkg/*
 .idea
 *.iml

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Evelpidon Validators changelog
 
+## 0.5.0 / 2013-08-29
+
+* CreditCardValidator learned the option of `:luhn_only` bypassing the actual cc type check.
+  Includes pure JS implementation.
+
 ## 0.4.4 / 2013-06-18
 
 * Test numbers are considered valid in all Rails environments except production.

data/lib/assets/javascripts/evelpidon_validators/credit_card.js

@@ -1,7 +1,38 @@
+clientSideValidations.helpers = clientSideValidations.helpers || {};
+
+/**
+ * Variant of Avraham Plotnitzky's String.prototype method mixed with the "fast" version
+ * see: https://sites.google.com/site/abapexamples/javascript/luhn-validation.
+ *
+ * Taken from https://gist.github.com/ShirtlessKirk/2134376
+ *
+ * @param luhn {Integer}
+ * @returns {boolean}
+ */
+clientSideValidations.helpers.luhnChk = function(luhn) {
+    var len = luhn.length,
+        mul = 0,
+        prodArr = [[0, 1, 2, 3, 4, 5, 6, 7, 8, 9], [0, 2, 4, 6, 8, 1, 3, 5, 7, 9]],
+        sum = 0;
+
+    while (len--) {
+        sum += prodArr[mul][parseInt(luhn.charAt(len), 10)];
+        mul ^= 1;
+    }
+
+    return sum % 10 === 0 && sum > 0;
+};
+
 clientSideValidations.validators.remote['credit_card'] = function(element, options) {
-    if ($.ajax({
-        url: '/validators/credit_card.json',
-        data: { value: element.val(), type: clientSideValidations.helpers.getSiblingField(element, options.type_attribute).val() },
-        async: false
-    }).status == 404) { return options.message; }
+    if (options.luhn_only) {
+        if (clientSideValidations.helpers.luhnChk(element.val()) == false) {
+            return options.message;
+        }
+    } else {
+        if ($.ajax({
+            url: '/validators/credit_card.json',
+            data: { value: element.val(), type: clientSideValidations.helpers.getSiblingField(element, options.type_attribute).val()},
+            async: false
+        }).status == 404) { return options.message; }
+    }
 };

data/lib/evelpidon_validators/credit_card.rb

@@ -27,10 +27,20 @@ module ActiveModel
         ::CreditCardValidator::Validator.valid?(number)
       end
 
+      def self.valid_luhn?(number)
+        ::CreditCardValidator::Validator.verify_luhn(number)
+      end
+
       def validate_each(record, attribute, value)
-        type = record.send(options[:type_attribute]) if options[:type_attribute]
-        unless self.class.valid_credit_card? value, type
-          record.errors.add(attribute, :credit_card, options)
+        if options[:luhn_only]
+          unless self.class.valid_luhn? value
+            record.errors.add(attribute, :credit_card, options)
+          end
+        else
+          type = record.send(options[:type_attribute]) if options[:type_attribute]
+          unless self.class.valid_credit_card? value, type
+            record.errors.add(attribute, :credit_card, options)
+          end
         end
       end
     end
@@ -40,7 +50,12 @@ end
 module ClientSideValidations::Middleware
   class CreditCard < Base
     def response
-      self.status = ActiveModel::Validations::CreditCardValidator.valid_credit_card?(request.params[:value], request.params[:type]) ? 200 : 404
+      if request.params[:luhn_only]
+        self.status = ActiveModel::Validations::CreditCardValidator.valid_luhn?(request.params[:value]) ? 200 : 404
+      else
+        self.status = ActiveModel::Validations::CreditCardValidator.valid_credit_card?(request.params[:value], request.params[:type]) ? 200 : 404
+      end
+
       super
     end
   end

data/lib/evelpidon_validators/version.rb

@@ -1,3 +1,3 @@
 module EvelpidonValidators
-  VERSION = "0.4.4"
+  VERSION = "0.5.0"
 end

data/test/credit_card_test.rb

@@ -113,6 +113,24 @@ class CreditCardValidatorTest < ActiveSupport::TestCase
     assert_valid_card_type_and_number 'Maestro', '4111111111111111'
   end
 
+  test "luhn check only" do
+    class PaymentWithNoTypeValidation
+      include ActiveModel::Validations
+      attr_accessor :card_type, :card_number
+      validates :card_number, :credit_card => {:luhn_only => true}
+    end
+
+    @payment = PaymentWithNoTypeValidation.new
+
+    %w(
+      50339619890917 586824160825533338 6759411100000008 5641821111166669 6759560045005727054
+      3530111333300000 4111111111111111 5555555555554444 30569309025904 371449635398431
+      6011000990139424
+    ).each do |cc_number|
+      assert_valid_card_number cc_number
+    end
+  end
+
   #########
   protected
   #########
@@ -123,6 +141,11 @@ class CreditCardValidatorTest < ActiveSupport::TestCase
     assert_valid_attribute @payment, :card_number
   end
 
+  def assert_valid_card_number(number)
+    @payment.card_number = number
+    assert_valid_attribute @payment, :card_number
+  end
+
   def assert_invalid_card_type_and_number(type, number)
     @payment.card_type = type
     @payment.card_number = number

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: evelpidon_validators
 version: !ruby/object:Gem::Version
-  version: 0.4.4
-  prerelease: 
+  version: 0.5.0
 platform: ruby
 authors:
 - Nikos Dimitrakopoulos
@@ -10,12 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-18 00:00:00.000000000 Z
+date: 2013-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -23,7 +21,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -31,7 +28,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -39,7 +35,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -47,7 +42,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: evelpidon_test_helpers
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -55,7 +49,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -63,7 +56,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: test-unit
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -71,7 +63,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -79,7 +70,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -87,7 +77,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -95,7 +84,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: credit_card_validator
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -103,7 +91,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -145,33 +132,26 @@ files:
 - test/test_helper.rb
 homepage: ''
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 692248226337988979
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 692248226337988979
 requirements: []
 rubyforge_project: evelpidon_validators
-rubygems_version: 1.8.25
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Useful ActiveModel validators
 test_files:
 - test/associated_test.rb