evelpidon_validators 0.3.0 → 0.4.0

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Evelpidon Validators changelog
 
+## 0.4.0 / 2012-01-13
+
+* Fix for nested forms and sibling finding
+* Added CreditCardValidator
+
 ## 0.3.0 / 2011-12-29
 
 * Added AssociationValidator

data/README.md

@@ -13,6 +13,8 @@ already loaded.
 * Different
 * Less
 * More
+* Associated
+* Credit Card
 
 ## Installation
 

data/evelpidon_validators.gemspec

@@ -24,4 +24,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency "test-unit"
 
   s.add_runtime_dependency "activemodel"
+  s.add_runtime_dependency "credit_card_validator"
 end

data/lib/assets/javascripts/evelpidon_validators/credit_card.js

@@ -0,0 +1,7 @@
+clientSideValidations.validators.remote['credit_card'] = function(element, options) {
+    if ($.ajax({
+        url: '/validators/credit_card.json',
+        data: { value: element.val(), type: clientSideValidations.helpers.getSiblingField(element, options.type).val() },
+        async: false
+    }).status == 404) { return options.message; }
+};

data/lib/assets/javascripts/evelpidon_validators.js

@@ -4,6 +4,6 @@
 clientSideValidations.helpers = clientSideValidations.helpers || {};
 
 clientSideValidations.helpers.getSiblingField = function(field, siblingName) {
-    var thanName = field.attr('name').replace(/\[[^\]]*\]/, '[' + siblingName + ']');
+    var thanName = field.attr('name').replace(/\[[^\]]*\]$/, '[' + siblingName + ']');
     return field.parents('form').find("[name='" + thanName + "']");
 };

data/lib/evelpidon_validators/all.rb

@@ -2,3 +2,4 @@ require "evelpidon_validators/different"
 require "evelpidon_validators/greater"
 require "evelpidon_validators/less"
 require "evelpidon_validators/associated"
+require "evelpidon_validators/credit_card"

data/lib/evelpidon_validators/credit_card.rb

@@ -0,0 +1,31 @@
+require 'credit_card_validator'
+
+if defined?(Rails) && Rails.env == 'development'
+  ::CreditCardValidator::Validator.options[:test_numbers_are_valid] = true
+end
+
+module ActiveModel
+  module Validations
+    class CreditCardValidator < EachValidator
+      def self.valid_credit_card?(number, type)
+        ::CreditCardValidator::Validator.options[:allowed_card_types] = [(type || '').underscore.to_sym]
+        ::CreditCardValidator::Validator.valid?(number)
+      end
+
+      def validate_each(record, attribute, value)
+        unless self.class.valid_credit_card? value, record.send(options[:type])
+          record.errors.add(attribute, :credit_card, options)
+        end
+      end
+    end
+  end
+end
+
+module ClientSideValidations::Middleware
+  class CreditCard < Base
+    def response
+      self.status = ActiveModel::Validations::CreditCardValidator.valid_credit_card?(request.params[:value], request.params[:type]) ? 200 : 404
+      super
+    end
+  end
+end if defined?(ClientSideValidations)

data/lib/evelpidon_validators/version.rb

@@ -1,3 +1,3 @@
 module EvelpidonValidators
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

data/test/credit_card_test.rb

@@ -0,0 +1,98 @@
+require 'test_helper'
+require 'evelpidon_validators/credit_card'
+
+class CreditCardValidatorTest < ActiveSupport::TestCase
+
+  class Payment
+    include ActiveModel::Validations
+    attr_accessor :card_type, :card_number
+    validates :card_number, :credit_card => { :type => :card_type }
+  end
+
+  setup do
+    CreditCardValidator::Validator.options[:test_numbers_are_valid] = true
+    @payment = Payment.new
+  end
+
+  test "visa cards" do
+    assert_valid_card_type_and_number 'Visa', '4111111111111111'
+    assert_valid_card_type_and_number 'visa', '4111111111111111'
+
+    assert_invalid_card_type_and_number 'MasterCard', '4111111111111111'
+    assert_invalid_card_type_and_number 'DinersClub', '4111111111111111'
+    assert_invalid_card_type_and_number 'Amex', '4111111111111111'
+    assert_invalid_card_type_and_number 'Discover', '4111111111111111'
+    assert_invalid_card_type_and_number 'Maestro', '4111111111111111'
+  end
+
+  test "master card cards" do
+    assert_valid_card_type_and_number 'MasterCard', '5555555555554444'
+    assert_valid_card_type_and_number 'master_card', '5555555555554444'
+
+    assert_invalid_card_type_and_number 'Visa', '5555555555554444'
+    assert_invalid_card_type_and_number 'DinersClub', '5555555555554444'
+    assert_invalid_card_type_and_number 'Amex', '5555555555554444'
+    assert_invalid_card_type_and_number 'Discover', '5555555555554444'
+    assert_invalid_card_type_and_number 'Maestro', '5555555555554444'
+  end
+
+  test "diners club cards" do
+    assert_valid_card_type_and_number 'DinersClub', '30569309025904'
+    assert_valid_card_type_and_number 'diners_club', '30569309025904'
+
+    assert_invalid_card_type_and_number 'Visa', '30569309025904'
+    assert_invalid_card_type_and_number 'MasterCard', '30569309025904'
+    assert_invalid_card_type_and_number 'Amex', '30569309025904'
+    assert_invalid_card_type_and_number 'Discover', '30569309025904'
+    assert_invalid_card_type_and_number 'Maestro', '30569309025904'
+  end
+
+  test "amex cards" do
+    assert_valid_card_type_and_number 'Amex', '371449635398431'
+    assert_valid_card_type_and_number 'amex', '371449635398431'
+
+    assert_invalid_card_type_and_number 'Visa', '371449635398431'
+    assert_invalid_card_type_and_number 'MasterCard', '371449635398431'
+    assert_invalid_card_type_and_number 'DinersClub', '371449635398431'
+    assert_invalid_card_type_and_number 'Discover', '371449635398431'
+    assert_invalid_card_type_and_number 'Maestro', '371449635398431'
+  end
+
+  test "discover cards" do
+    assert_valid_card_type_and_number 'Discover', '6011000990139424'
+    assert_valid_card_type_and_number 'discover', '6011000990139424'
+
+    assert_invalid_card_type_and_number 'Visa', '6011000990139424'
+    assert_invalid_card_type_and_number 'MasterCard', '6011000990139424'
+    assert_invalid_card_type_and_number 'DinersClub', '6011000990139424'
+    assert_invalid_card_type_and_number 'Amex', '6011000990139424'
+    assert_invalid_card_type_and_number 'Maestro', '6011000990139424'
+  end
+
+  test "maestro cards" do
+    assert_valid_card_type_and_number 'Maestro', '6759671431256542'
+    assert_valid_card_type_and_number 'maestro', '6759671431256542'
+
+    assert_invalid_card_type_and_number 'Visa', '6759671431256542'
+    assert_invalid_card_type_and_number 'MasterCard', '6759671431256542'
+    assert_invalid_card_type_and_number 'DinersClub', '6759671431256542'
+    assert_invalid_card_type_and_number 'Discover', '6759671431256542'
+    assert_invalid_card_type_and_number 'Discover', '6759671431256542'
+  end
+
+  #########
+  protected
+  #########
+
+  def assert_valid_card_type_and_number(type, number)
+    @payment.card_type = type
+    @payment.card_number = number
+    assert_valid_attribute @payment, :card_number
+  end
+
+  def assert_invalid_card_type_and_number(type, number)
+    @payment.card_type = type
+    @payment.card_number = number
+    assert_invalid_attribute @payment, :card_number
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: evelpidon_validators
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
   prerelease: 
 platform: ruby
 authors:
@@ -10,11 +10,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-12-29 00:00:00.000000000 Z
+date: 2012-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &17211260 !ruby/object:Gem::Requirement
+  requirement: &16770240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *17211260
+  version_requirements: *16770240
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &17210780 !ruby/object:Gem::Requirement
+  requirement: &16769800 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +33,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *17210780
+  version_requirements: *16769800
 - !ruby/object:Gem::Dependency
   name: evelpidon_test_helpers
-  requirement: &17210360 !ruby/object:Gem::Requirement
+  requirement: &16769340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +44,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *17210360
+  version_requirements: *16769340
 - !ruby/object:Gem::Dependency
   name: test-unit
-  requirement: &17209920 !ruby/object:Gem::Requirement
+  requirement: &16768860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +55,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *17209920
+  version_requirements: *16768860
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &17209440 !ruby/object:Gem::Requirement
+  requirement: &16768380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,7 +66,18 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *17209440
+  version_requirements: *16768380
+- !ruby/object:Gem::Dependency
+  name: credit_card_validator
+  requirement: &16767920 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: *16767920
 description: Useful ActiveModel validators with ClientSideValidations support.
 email:
 - n.dimitrakopoulos@pamediakopes.gr
@@ -83,18 +94,21 @@ files:
 - Rakefile
 - evelpidon_validators.gemspec
 - lib/assets/javascripts/evelpidon_validators.js
+- lib/assets/javascripts/evelpidon_validators/credit_card.js
 - lib/assets/javascripts/evelpidon_validators/different.js
 - lib/assets/javascripts/evelpidon_validators/greater.js
 - lib/assets/javascripts/evelpidon_validators/less.js
 - lib/evelpidon_validators.rb
 - lib/evelpidon_validators/all.rb
 - lib/evelpidon_validators/associated.rb
+- lib/evelpidon_validators/credit_card.rb
 - lib/evelpidon_validators/different.rb
 - lib/evelpidon_validators/greater.rb
 - lib/evelpidon_validators/less.rb
 - lib/evelpidon_validators/rails.rb
 - lib/evelpidon_validators/version.rb
 - test/associated_test.rb
+- test/credit_card_test.rb
 - test/different_test.rb
 - test/greater_test.rb
 - test/less_test.rb