europeana-blacklight 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2982bfcc30682102ae0f67fb85312a9d6f798fb7
-  data.tar.gz: 83dc0fdd9682b23c1fe0a68505b2c27010a3c0f5
+  metadata.gz: 7442255bc63f0d1b8a6d293d928da2b9ca9f1362
+  data.tar.gz: 976ea304b67311d2be0055d659306b0ff61a0f55
 SHA512:
-  metadata.gz: 5e73721571a9f0fd837e38d5b31e1aba6ecae2320242063907ed7091b5dc2997ce2c55c35f49bf78ef06ae0e2d4c8efe2270495764c400a77334c7a42f34386e
-  data.tar.gz: 85ea8bb7005ad46579410ed34074d6fe21c8ccea0a10b2adc93649d1c8902ab7997e9ec91935727fe6ca99d1d6cf4a5058c3e2c6fae6be1724ac1ea217df1d50
+  metadata.gz: df035e593c9d9f32f0b1867ee9426a9dd0c8e77fc86bc472af76f5d44736819b9867ed3d3d7b6323dbbfb1f3ff362f4d437dcc165ad35fcad5edd85e4774f97f
+  data.tar.gz: 7e2ef1ec830cb661b5cf309b6aab0fbdcc1324a21f52f566070a49c071b88d1535ee28d02df247d6bae026499f5ea4188b1cc6049c71854cc0e22b493f48e15d

data/.codeclimate.yml

@@ -0,0 +1,3 @@
+plugins:
+  rubocop:
+    enabled: true

data/.ruby-style.yml

@@ -3,7 +3,7 @@ AllCops:
     - "vendor/**/*"
     - "db/schema.rb"
   UseCache: false
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
 Style/CollectionMethods:
   Description: Preferred collection methods.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#map-find-select-reduce-size
@@ -14,7 +14,12 @@ Style/CollectionMethods:
     find: detect
     find_all: select
     reduce: inject
-Style/DotPosition:
+Metrics/BlockLength:
+  Exclude:
+    - 'Rakefile'
+    - '**/*.rake'
+    - 'spec/**/*.rb'
+Layout/DotPosition:
   Description: Checks the position of the dot in multi-line method calls.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains
   Enabled: true
@@ -22,7 +27,7 @@ Style/DotPosition:
   SupportedStyles:
   - leading
   - trailing
-Style/FileName:
+Naming/FileName:
   Description: Use snake_case for source file names.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#snake-case-files
   Enabled: false
@@ -36,7 +41,6 @@ Style/IfUnlessModifier:
   Description: Favor modifier if/unless usage when you have a single-line body.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier
   Enabled: false
-  MaxLineLength: 80
 Style/OptionHash:
   Description: Don't use option hashes when you can use keyword arguments.
   Enabled: false
@@ -54,7 +58,7 @@ Style/PercentLiteralDelimiters:
     "%w": "()"
     "%W": "()"
     "%x": "()"
-Style/PredicateName:
+Naming/PredicateName:
   Description: Check the names of predicate methods.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark
   Enabled: true
@@ -120,19 +124,6 @@ Style/TrailingCommaInArguments:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
   Enabled: false
   EnforcedStyleForMultiline: no_comma
-  SupportedStyles:
-  - comma
-  - consistent_comma
-  - no_comma
-Style/TrailingCommaInLiteral:
-  Description: 'Checks for trailing comma in array and hash literals.'
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
-  Enabled: false
-  EnforcedStyleForMultiline: no_comma
-  SupportedStyles:
-  - comma
-  - consistent_comma
-  - no_comma
 Metrics/AbcSize:
   Description: A calculated magnitude based on number of assignments, branches, and
     conditions.
@@ -186,7 +177,7 @@ Lint/AssignmentInCondition:
 Style/InlineComment:
   Description: Avoid inline comments.
   Enabled: false
-Style/AccessorMethodName:
+Naming/AccessorMethodName:
   Description: Check the naming of accessor methods for get_/set_.
   Enabled: false
 Style/Alias:
@@ -244,7 +235,7 @@ Lint/HandleExceptions:
   Description: Don't suppress exception.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#dont-hide-exceptions
   Enabled: false
-Lint/LiteralInCondition:
+Lint/LiteralAsCondition:
   Description: Checks of literals used in conditions.
   Enabled: false
 Lint/LiteralInInterpolation:

data/.travis.yml

@@ -2,8 +2,20 @@ language: ruby
 rvm:
   - 2.3
   - 2.4
+  - 2.5
 notifications:
   email: false
 sudo: false
 cache:
   bundler: true
+before_install:
+  - gem update --system
+  - gem install bundler
+before_script:
+  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+  - chmod +x ./cc-test-reporter
+  - ./cc-test-reporter before-build
+script:
+  - bundle exec rspec
+after_script:
+  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT

data/Gemfile

@@ -6,9 +6,9 @@ gemspec
 gem 'europeana-api', github: 'europeana/europeana-api-client-ruby', branch: 'develop'
 
 group :test do
-  gem 'coveralls', require: false
+  gem 'simplecov', require: false
 end
 
 group :test, :development do
-  gem 'rubocop', '0.39.0', require: false # only update when Hound does
+  gem 'rubocop', '~> 0.53', require: false
 end

data/README.md

@@ -1,6 +1,6 @@
 # Europeana::Blacklight
 
-[![Build Status](https://travis-ci.org/europeana/europeana-blacklight.svg?branch=master)](https://travis-ci.org/europeana/europeana-blacklight) [![Coverage Status](https://coveralls.io/repos/europeana/europeana-blacklight/badge.svg?branch=master&service=github)](https://coveralls.io/github/europeana/europeana-blacklight?branch=master) [![security](https://hakiri.io/github/europeana/europeana-blacklight/master.svg)](https://hakiri.io/github/europeana/europeana-blacklight/master) [![Dependency Status](https://gemnasium.com/europeana/europeana-blacklight.svg)](https://gemnasium.com/europeana/europeana-blacklight)
+[![Build Status](https://travis-ci.org/europeana/europeana-blacklight.svg?branch=master)](https://travis-ci.org/europeana/europeana-blacklight) [![Security](https://hakiri.io/github/europeana/europeana-blacklight/master.svg)](https://hakiri.io/github/europeana/europeana-blacklight/master) [![Dependency Status](https://gemnasium.com/europeana/europeana-blacklight.svg)](https://gemnasium.com/europeana/europeana-blacklight) [![Maintainability](https://api.codeclimate.com/v1/badges/9ca73f2805dce1de01b6/maintainability)](https://codeclimate.com/github/europeana/europeana-blacklight/maintainability) [![Test Coverage](https://api.codeclimate.com/v1/badges/9ca73f2805dce1de01b6/test_coverage)](https://codeclimate.com/github/europeana/europeana-blacklight/test_coverage)
 
 Ruby gem providing an adapter to use the
 [Europeana REST API](http://labs.europeana.eu/api/introduction/) as a data

data/europeana-blacklight.gemspec

@@ -6,7 +6,7 @@ Gem::Specification.new do |spec|
   spec.name          = 'europeana-blacklight'
   spec.version       = Europeana::Blacklight::VERSION
   spec.authors       = ['Richard Doe']
-  spec.email         = ['richard.doe@rwdit.net']
+  spec.email         = ['richard.doe@europeana.eu']
 
   spec.summary       = 'Europeana REST API adapter for Blacklight'
   spec.homepage      = 'https://github.com/europeana/europeana-blacklight'
@@ -21,6 +21,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'blacklight', '~> 6.0.0'
   spec.add_dependency 'europeana-api', '~> 1.0.0'
   spec.add_dependency 'iso-639', '~> 0.2.5'
+  spec.add_dependency 'kaminari', '>= 1.0.0', '< 2'
   spec.add_dependency 'rails', '>= 4.2.2', '< 5'
 
   spec.add_development_dependency 'bundler', '~> 1.8'

data/lib/europeana/blacklight/response/pagination.rb

@@ -29,8 +29,14 @@ module Europeana
           docs.first.model_name
         end
 
-        def max_pages
-          (defined?(@_max_pages) && @_max_pages) || (1000 / limit_value)
+        def max_pages(val = :none)
+          if val == :none
+            # getter
+            (defined?(@_max_pages) && @_max_pages) || (1000 / limit_value)
+          else
+            # setter
+            @_max_pages = val
+          end
         end
 
         def total_pages

data/lib/europeana/blacklight/version.rb

@@ -1,5 +1,5 @@
 module Europeana
   module Blacklight
-    VERSION = '1.1.0'.freeze
+    VERSION = '1.2.0'.freeze
   end
 end

data/spec/spec_helper.rb

@@ -1,7 +1,8 @@
 ENV['RAILS_ENV'] ||= 'test'
 
-require 'coveralls'
-Coveralls.wear! unless Coveralls.will_run?.nil?
+# Generate Simplecov report
+require 'simplecov'
+SimpleCov.start
 
 require File.expand_path('../dummy/config/environment.rb', __FILE__)
 require 'rspec/rails'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: europeana-blacklight
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Richard Doe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-09 00:00:00.000000000 Z
+date: 2018-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: blacklight
@@ -52,6 +52,26 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.2.5
+- !ruby/object:Gem::Dependency
+  name: kaminari
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
@@ -144,13 +164,13 @@ dependencies:
         version: '1.21'
 description: 
 email:
-- richard.doe@rwdit.net
+- richard.doe@europeana.eu
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
-- ".hound.yml"
 - ".rspec"
 - ".rubocop.yml"
 - ".ruby-style.yml"

data/.hound.yml

@@ -1,10 +0,0 @@
-coffeescript:
-  enabled: false
-haml:
-  enabled: false
-javascript:
-  enabled: false
-scss:
-  enabled: false
-ruby:
-  config_file: .ruby-style.yml