europe 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4a0fc2ed7821eb1f8561bdb6421f9921fd23c49a
-  data.tar.gz: 59242fee45c24eb9f258ee7bcaaa8882e0ecad56
+  metadata.gz: b117fbde4812a7c55c95dfe21f6c1c52d792e529
+  data.tar.gz: 1029b7ad3e8c5c310f41e887eb0bb074d1589a09
 SHA512:
-  metadata.gz: adf482a84c8abb1906cc19e9d3cff143b96696dc648c31aae191b1720d04ba8bd8d47acbb4dcf3e902ce1520554258149d3acbf8fe5ef2bf5214036209e39f1c
-  data.tar.gz: 568c9933adfc50a8de039bbdbb9110e166d254de368cb0dbedd10640e77ca3150fe498793cd33ab481933c259641e97cda56d7aa419b5b97c278695cc4ab431f
+  metadata.gz: f7383ca5b11d95988b4e0da4939646379429cca04bfa4a0fa38d2edbff0f89b5de1517817cf609ec2afb305b00fc516395cada25f38b3ad7aa61d1eb5b55c88c
+  data.tar.gz: 854180e88ab6348b08c0bc2ac1e7a335ffbc88c110ef439a62d4782bb3ed2ea29056607d5088bbb2153717dcbf07a14a5fd3acaf38218db9d0655f495bd117ca

data/.gitignore

@@ -13,3 +13,4 @@
 *.a
 mkmf.log
 .DS_Store
+coverage

data/.rubocop.yml

@@ -0,0 +1,3 @@
+AllCops:
+  Exclude:
+    - 'europe.gemspec'

data/README.md

@@ -1,3 +1,4 @@
+![Europe gem logo](https://s3-eu-west-1.amazonaws.com/valorsis.s3-website-eu-west-1.amazonaws.com/static/logo256.png)
 # Europe
 
 This gem provides EU governmental data, extracted from various EU / EC websites. With this gem you can validate VAT numbers, retrieve VAT tax rates and currency exchange rates matched to the Euro. How to use this gem is pretty straightforward and written below.
@@ -138,7 +139,7 @@ Response
 ```
 
 ## Retrieving country information reversed
-Call with optional parameters (name, currency, source_name, official_name, tld, currency and capital) 
+Call with optional parameters (name, currency, source_name, official_name, tld, currency and capital)
 ```ruby
 Europe::Countries::Reversed.generate('name')
 ```
@@ -157,7 +158,7 @@ Response
 
 This gem is tested with the following Ruby versions on Linux and Mac OS X:
 
-- Ruby MRI 1.9.3, 2.0.0, 2.1.8, 2.2.0, 2.2.3, 2.2.4
+- Ruby > 2.2.2
 
 ## Todo
 
@@ -172,4 +173,4 @@ This gem is tested with the following Ruby versions on Linux and Mac OS X:
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
-5. Create a new Pull Request
+5. Create a new Pull Request

data/Rakefile

@@ -5,6 +5,7 @@ Rake::TestTask.new(:test) do |t|
   t.libs << 'test'
   t.libs << 'lib'
   t.test_files = FileList['test/**/*_test.rb']
+  t.warning = false
 end
 
 task default: :test

data/europe.gemspec

@@ -22,13 +22,16 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'nokogiri', '~> 1.6'
-  spec.add_dependency 'savon', '~> 2.10.0'
+  spec.add_dependency 'nokogiri'
+  spec.add_dependency 'savon'
 
-  spec.add_development_dependency 'bundler', '~> 1'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'rake'
   spec.add_development_dependency 'minitest'
+  spec.add_development_dependency 'minitest-reporters'
   spec.add_development_dependency 'awesome_print'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'webmock'
 end

data/lib/europe/countries/countries.rb

@@ -94,6 +94,7 @@ module Europe
       UK: { name: 'United Kingdom', source_name: 'United Kingdom',
             official_name: 'United Kingdom of Great ' \
                            'Britain and Northern Ireland',
-            tld: '.uk', currency: :GBP, capital: 'London' } }
+            tld: '.uk', currency: :GBP, capital: 'London' }
+    }.freeze
   end
 end

data/lib/europe/countries/reversed.rb

@@ -9,8 +9,6 @@ module Europe
         end
       end
 
-      private
-
       def self.reverse_handle_value(out, key, value, country_value)
         if out[value[country_value.to_sym]]
           reverse_handle_array(out, key, value, country_value)

data/lib/europe/currency/currency.rb

@@ -18,6 +18,7 @@ module Europe
       HUF: { name: 'Forint', symbol: 'Ft', html: 'Ft' },
       PLN: { name: 'Zloty', symbol: 'zł', html: 'zł' },
       RON: { name: 'Leu', symbol: 'lei', html: 'lei' },
-      SEK: { name: 'Krona', symbol: 'kr', html: 'kr' } }
+      SEK: { name: 'Krona', symbol: 'kr', html: 'kr' }
+    }.freeze
   end
 end

data/lib/europe/currency/exchange_rates.rb

@@ -8,13 +8,11 @@ module Europe
     # exchange rates
     module ExchangeRates
       EXCHANGE_URL = 'http://www.ecb.europa.eu/stats/' \
-                     'eurofxref/eurofxref-daily.xml'
+                     'eurofxref/eurofxref-daily.xml'.freeze
       def self.retrieve
         extract_rates(Nokogiri::XML(open(EXCHANGE_URL)))
       end
 
-      private
-
       def self.extract_rates(doc)
         rates = { date: Date.parse(doc.css('Cube Cube').first['time']),
                   rates: {} }

data/lib/europe/eurostat/eurostat.rb

@@ -7,20 +7,19 @@ module Europe
   # Eurostat
   module Eurostat
     STAT_URL = 'http://ec.europa.eu/eurostat/wdds' \
-               '/rest/data/v1.1/json/en/'
+               '/rest/data/v1.1/json/en/'.freeze
 
     def self.retrieve(dataset, filters)
       fetch_stats(dataset, filters)
     end
 
-    private
-
     def self.generate_url(dataset, _filters)
       uri = URI.parse(STAT_URL + dataset)
       params = {
         precision: 1, geo: 'EU28',
         unit: 'EUR_HAB', time: '2010',
-        indic_na: 'B1GM', unitLabel: 'code' }
+        indic_na: 'B1GM', unitLabel: 'code'
+      }
       uri.query = URI.encode_www_form(params)
       uri
     end

data/lib/europe/vat/format.rb

@@ -33,17 +33,30 @@ module Europe
         SE: /^SE\d{12}$/,
         SI: /^SI\d{8}$/,
         SK: /^SK\d{10}$/
-      }
+      }.freeze
 
       def self.validate(number)
         country_code = number[0..1].to_sym
+        number = sanitize_number(number, country_code)
         return false unless VAT_REGEX.keys.include?(country_code)
+        match_vat_number(number, country_code)
+      end
+
+      def self.sanitize_number(number, country_code)
+        if [:GB, :DK, :FR].include?(country_code)
+          number.gsub(/\.|\t/, '').upcase
+        else
+          number.gsub(/\.|\t|\s/, '').upcase
+        end
+      end
+
+      def self.match_vat_number(number, country_code)
         if VAT_REGEX[country_code.to_sym].is_a?(Array)
           VAT_REGEX[country_code.to_sym].each do |regex|
             return true if regex.match(number)
           end
-        else
-          return true if VAT_REGEX[country_code.to_sym].match(number)
+        elsif VAT_REGEX[country_code.to_sym].match(number)
+          return true
         end
         false
       end

data/lib/europe/vat/rates.rb

@@ -1,21 +1,15 @@
-require 'net/http'
-require 'uri'
-require 'nokogiri'
-
 module Europe
   module Vat
     # Rates
     module Rates
       RATES_URL = 'http://ec.europa.eu/taxation_customs/tic/' \
-                  'public/vatRates/vatratesSearch.html'
+                  'public/vatRates/vatratesSearch.html'.freeze
       def self.retrieve
         resp = fetch_rates
         return resp if resp == :failed
         extract_rates(resp)
       end
 
-      private
-
       def self.extract_country_code(data)
         Europe::Countries::Reversed.generate(:name) \
           [data.css('td').first.text.strip!]
@@ -40,7 +34,7 @@ module Europe
         params = 'listOfTypes=Standard&dateFilter=' +
                  Time.new.strftime('%d/%m/%Y')
         [*1..Europe::Countries::COUNTRIES.count].each do |index|
-          params += '&listOfMsa=' + (index).to_s
+          params += '&listOfMsa=' + index.to_s
         end
         [uri, params]
       end

data/lib/europe/vat/vat.rb

@@ -7,19 +7,27 @@ module Europe
   # VAT
   module Vat
     WSDL = 'http://ec.europa.eu/taxation_customs/' \
-           'vies/checkVatService.wsdl'
-    NS = 'urn:ec.europa.eu:taxud:vies:services:checkVat:types'
+           'vies/checkVatService.wsdl'.freeze
+    NS = 'urn:ec.europa.eu:taxud:vies:services:checkVat:types'.freeze
     def self.validate(number)
       response = send_request(number[0..1], number[2..-1])
       return :failed unless response.success?
       response.body[:check_vat_response].tap { |x| x.delete(:@xmlns) }
-    rescue Savon::SOAPFault => fault
-      return :timeout \
-        if fault.to_hash[:fault][:faultstring] == 'SERVER_BUSY'
-      :fault
+    rescue Savon::HTTPError, Savon::SOAPFault
+      return :failed
+    rescue Timeout::Error
+      return :timeout
     end
 
-    private
+    def self.charge_vat?(origin_country, number)
+      return false if number.nil? || number.empty?
+      if origin_country.to_sym == number[0..1].to_sym
+        true
+      else
+        Europe::Countries::COUNTRIES
+          .keys.include?(number[0..1].to_sym)
+      end
+    end
 
     def self.send_request(country_code, number)
       client = Savon.client(wsdl: WSDL, namespace: NS,

data/lib/europe/version.rb

@@ -1,4 +1,4 @@
 # Europe version
 module Europe
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'.freeze
 end

data/test/europe/countries/country_test.rb

@@ -11,6 +11,10 @@ module Europe
           Europe::Countries::Reversed.generate(:name)
         assert_equal reversed_hash['Netherlands'], :NL
         assert_equal reversed_hash['Ireland'], :IE
+
+        reversed_hash =
+          Europe::Countries::Reversed.generate(:currency)
+        assert_equal reversed_hash[:EUR].count, 20
       end
     end
   end

data/test/europe/currency/exchange_rates_test.rb

@@ -6,6 +6,10 @@ module Europe
     class ExchangeRatesTest < Minitest::Test
       include Benchmark
 
+      def setup
+        WebMock.disable!
+      end
+
       def test_retrieval_exchange_rates
         rates = Europe::Currency::ExchangeRates.retrieve
         assert rates[:rates].keys.include?(:GBP)

data/test/europe/vat/format_test.rb

@@ -31,13 +31,14 @@ module Europe
         LU: 'LU99999999',
         LV: 'LV99999999999',
         MT: 'MT99999999',
-        NL: 'NL999999999B99',
+        NL: %w(NL999999999B99 NL999.9999.99.B99),
         PL: 'PL9999999999',
         PT: 'PT999999999',
         RO: 'RO999999999',
         SE: 'SE999999999999',
         SI: 'SI99999999',
-        SK: 'SK9999999999' }
+        SK: 'SK9999999999'
+      }.freeze
 
       def test_all_vat_numbers_on_format
         VAT_FORMAT_VALIDATION.each do |_country, number|
@@ -63,23 +64,27 @@ module Europe
       def check_character_and_digit(number)
         assert_equal true, Europe::Vat::Format.validate(
           number[0..1] +
-          number[2..-1].gsub(/X/, [*('A'..'Z'), *('0'..'9')].sample))
+          number[2..-1].gsub(/X/, [*('A'..'Z'), *('0'..'9')].sample)
+        )
       end
 
       def check_integer(number)
-        { number[0..1] + number[2..-1].gsub(/9/, [*('0'..'9')].sample) => true,
+        {
+          number[0..1] + number[2..-1].gsub(/9/, [*('0'..'9')].sample) => true,
           number.gsub(/9/, rand(10).to_s) => true,
           number.gsub(/9/, [*('A'..'Z')].sample(1).join) => false
-          }.each do |key, value|
+        }.each do |key, value|
           assert_equal value, Europe::Vat::Format.validate(key)
         end
       end
 
       def check_alphanumeric(number)
         assert_equal true, Europe::Vat::Format.validate(
-          number[0..1] + number[2..-1].gsub(/L/, [*('A'..'Z')].sample))
+          number[0..1] + number[2..-1].gsub(/L/, [*('A'..'Z')].sample)
+        )
         assert_equal false, Europe::Vat::Format.validate(
-          number[0..1] + number[2..-1].gsub(/L/, [*('0'..'9')].sample))
+          number[0..1] + number[2..-1].gsub(/L/, [*('0'..'9')].sample)
+        )
       end
 
       def check_true_values(number)
@@ -88,9 +93,11 @@ module Europe
 
       def check_false_values(number)
         assert_equal false, Europe::Vat::Format.validate(
-          number + [*('A'..'Z'), *('0'..'9')].sample(3).join)
+          number + [*('A'..'Z'), *('0'..'9')].sample(3).join
+        )
         assert_equal false, Europe::Vat::Format.validate(
-          [*('A'..'Z'), *('0'..'9')].sample + number)
+          [*('A'..'Z'), *('0'..'9')].sample + number
+        )
       end
     end
   end

data/test/europe/vat/rates_test.rb

@@ -6,6 +6,10 @@ module Europe
     class RatesTest < Minitest::Test
       include Benchmark
 
+      def setup
+        WebMock.disable!
+      end
+
       def test_retrieval_of_vat_rates
         rates = Europe::Vat::Rates.retrieve
         assert_equal rates.count, Europe::Countries::COUNTRIES.count

data/test/europe/vat/validation_test.rb

@@ -6,6 +6,10 @@ module Europe
     class ValidationTest < Minitest::Test
       include Benchmark
 
+      def setup
+        WebMock.disable!
+      end
+
       def test_validation_of_false_vat_number
         validate_false_vat = Europe::Vat.validate('NL123456789B01')
         assert_equal false, validate_false_vat[:valid]
@@ -15,15 +19,30 @@ module Europe
         # PostNL
         validate_correct_vat = Europe::Vat.validate('NL009291477B01')
         assert validate_correct_vat[:valid] \
-          unless validate_correct_vat == :fault
+          unless validate_correct_vat == :failed
 
         # Sky
         validate_correct_vat = Europe::Vat.validate('GB440627467')
-        assert validate_correct_vat[:valid]
+        assert validate_correct_vat[:valid] \
+          unless validate_correct_vat == :failed
 
         # Volkswagen
         validate_correct_vat = Europe::Vat.validate('DE115235681')
-        assert validate_correct_vat[:valid]
+        assert validate_correct_vat[:valid] \
+          unless validate_correct_vat == :failed
+      end
+
+      def test_failed_request_to_soap_service
+        WebMock.enable!
+        stub_request(:any, 'http://ec.europa.eu/taxation_customs' \
+                           '/vies/checkVatService.wsdl').to_timeout
+        Europe::Vat.validate('DE115235681')
+
+        stub_request(:get, 'http://ec.europa.eu/taxation_customs/vies/checkVatService.wsdl')
+          .with(headers: { 'Accept' => '*/*', 'User-Agent' => 'Ruby' })
+          .to_return(status: 421, body: '')
+        Europe::Vat.validate('DE115235681')
+        WebMock.disable!
       end
     end
   end

data/test/test_helper.rb

@@ -1,5 +1,11 @@
+require 'simplecov'
+SimpleCov.start
+
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 require 'europe'
 require 'minitest/autorun'
+require 'webmock/minitest'
 require 'awesome_print'
 require 'benchmark'
+require 'minitest/reporters'
+Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new

metadata

@@ -1,71 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: europe
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - VvanGemert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-21 00:00:00.000000000 Z
+date: 2017-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: savon
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.10.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.10.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest-reporters
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: awesome_print
   requirement: !ruby/object:Gem::Requirement
@@ -122,6 +136,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Europe is a simple library for retrieving EU government data such as
   VAT information, VAT validation, currency exchange rates and country information.
 email:
@@ -133,6 +175,7 @@ files:
 - ".coveralls.yml"
 - ".gitignore"
 - ".pryrc"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE
@@ -177,7 +220,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Europe is a gem for retrieving and validating EU government data.