europe 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1988661d9baa8aa81157d3410e0594db756f5c26
-  data.tar.gz: c3d31136673ace601aaff0cf31f4738ab8444208
+  metadata.gz: 4a0fc2ed7821eb1f8561bdb6421f9921fd23c49a
+  data.tar.gz: 59242fee45c24eb9f258ee7bcaaa8882e0ecad56
 SHA512:
-  metadata.gz: c9db83e2b89a39d0b5899ae26d51673f15edf98bc56b0f3d84d27648eb0f322b52cd26a33bf7e85c27f084656e365e92b4f7d5cd0e2296a2d30f95ec135c5a0e
-  data.tar.gz: b1b32e3e0b6bf72e9f49c5532bc1648f505d50f10718a412901fda44293caab8e0401702c061980ce1bdf2323e0aeaaf24c706cf92475d7526eea467bc57773a
+  metadata.gz: adf482a84c8abb1906cc19e9d3cff143b96696dc648c31aae191b1720d04ba8bd8d47acbb4dcf3e902ce1520554258149d3acbf8fe5ef2bf5214036209e39f1c
+  data.tar.gz: 568c9933adfc50a8de039bbdbb9110e166d254de368cb0dbedd10640e77ca3150fe498793cd33ab481933c259641e97cda56d7aa419b5b97c278695cc4ab431f

data/README.md

@@ -2,6 +2,20 @@
 
 This gem provides EU governmental data, extracted from various EU / EC websites. With this gem you can validate VAT numbers, retrieve VAT tax rates and currency exchange rates matched to the Euro. How to use this gem is pretty straightforward and written below.
 
+## Table of Contents
+- [Installation](#installation)
+- [Usage](#usage)
+  - [Validating VAT numbers](#validating-vat-numbers)
+  - [Validate VAT number format](#validate-vat-number-format)
+  - [Retrieving VAT rates for each EC/EU member](#retrieving-vat-rates-for-each-eceu-member)
+  - [Retrieving currency exchange rates](#retrieving-currency-exchange-rates)
+  - [Retrieving currency information](#retrieving-currency-information)
+  - [Retrieving country information](#retrieving-country-information)
+  - [Retrieving country information reversed](#retrieving-country-information-reversed)
+- [Compatibility](#compatibility)
+- [Todo](#todo)
+- [Contributing](#contributing)
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -24,9 +38,10 @@ There are several calls you can make with this gem. Below are a few examples
 where this gem can be used for.
 
 ### Validating VAT numbers
-Call
+** Updated: Parameter now consists of one value.**
+Call to validate VAT number (always starts with country code as specified in VIES)
 ```ruby
-Europe::Vat.validate('GB', '440627467')
+Europe::Vat.validate('GB440627467')
 ```
 Response
 ```ruby
@@ -94,9 +109,10 @@ Response
 CURRENCIES = {
   EUR: { name: 'Euro', symbol: '€', html: '€' },
   BGN: { name: 'Lev', symbol: 'лв', html: 'лв' },
+  # etc...
 ```
 
-## Retrieving country information
+### Retrieving country information
 Call
 ```ruby
 Europe::Countries::COUNTRIES
@@ -118,7 +134,7 @@ Response
    :tld=>".bg",
    :currency=>:BGN,
    :capital=>"Sofia"},
-...
+ # etc...
 ```
 
 ## Retrieving country information reversed
@@ -134,7 +150,7 @@ Response
    "Denmark" => :DK,
    "Germany" => :DE,
    "Estonia" => :EE,
-...
+   # etc...
 ```
 
 ## Compatibility

data/europe.gemspec

@@ -8,11 +8,11 @@ Gem::Specification.new do |spec|
   spec.version       = Europe::VERSION
   spec.authors       = ['VvanGemert']
   spec.email         = ['vincent@floorplanner.com']
-  spec.summary       = 'Europe is a gem for retrieving and validating' \
+  spec.summary       = 'Europe is a gem for retrieving and validating ' \
                        'EU government data.'
   spec.description   = 'Europe is a simple library for retrieving ' \
                        'EU government data such as VAT information, ' \
-                       'VAT validation, currency exchange rates and' \
+                       'VAT validation, currency exchange rates and ' \
                        'country information.'
   spec.homepage      = 'https://github.com/VvanGemert/europe'
   spec.license       = 'MIT'

data/lib/europe/vat/vat.rb

@@ -9,8 +9,8 @@ module Europe
     WSDL = 'http://ec.europa.eu/taxation_customs/' \
            'vies/checkVatService.wsdl'
     NS = 'urn:ec.europa.eu:taxud:vies:services:checkVat:types'
-    def self.validate(country_code, number)
-      response = send_request(country_code, number)
+    def self.validate(number)
+      response = send_request(number[0..1], number[2..-1])
       return :failed unless response.success?
       response.body[:check_vat_response].tap { |x| x.delete(:@xmlns) }
     rescue Savon::SOAPFault => fault

data/lib/europe/version.rb

@@ -1,4 +1,4 @@
 # Europe version
 module Europe
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/test/europe/vat/validation_test.rb

@@ -7,22 +7,22 @@ module Europe
       include Benchmark
 
       def test_validation_of_false_vat_number
-        validate_false_vat = Europe::Vat.validate('NL', '123456789B01')
+        validate_false_vat = Europe::Vat.validate('NL123456789B01')
         assert_equal false, validate_false_vat[:valid]
       end
 
       def test_validation_of_correct_vat_number
         # PostNL
-        validate_correct_vat = Europe::Vat.validate('NL', '009291477B01')
+        validate_correct_vat = Europe::Vat.validate('NL009291477B01')
         assert validate_correct_vat[:valid] \
           unless validate_correct_vat == :fault
 
         # Sky
-        validate_correct_vat = Europe::Vat.validate('GB', '440627467')
+        validate_correct_vat = Europe::Vat.validate('GB440627467')
         assert validate_correct_vat[:valid]
 
         # Volkswagen
-        validate_correct_vat = Europe::Vat.validate('DE', '115235681')
+        validate_correct_vat = Europe::Vat.validate('DE115235681')
         assert validate_correct_vat[:valid]
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: europe
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - VvanGemert
@@ -123,7 +123,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 description: Europe is a simple library for retrieving EU government data such as
-  VAT information, VAT validation, currency exchange rates andcountry information.
+  VAT information, VAT validation, currency exchange rates and country information.
 email:
 - vincent@floorplanner.com
 executables: []
@@ -180,7 +180,7 @@ rubyforge_project:
 rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
-summary: Europe is a gem for retrieving and validatingEU government data.
+summary: Europe is a gem for retrieving and validating EU government data.
 test_files:
 - test/europe/countries/country_test.rb
 - test/europe/currency/currency_test.rb